Re: [gem5-dev] Review Request 3480: misc: add a MasterId to the ExternalPort
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/ --- (Updated Jan. 9, 2017, 12:19 p.m.) Review request for Default. Repository: gem5 Description (updated) --- misc: add a MasterId to the ExternalPort The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster to allow external modules to easily genrerate new Requests. Diffs - src/mem/external_master.cc c10c50cb8ac9 src/mem/ExternalMaster.py c10c50cb8ac9 src/mem/external_master.hh c10c50cb8ac9 Diff: http://reviews.gem5.org/r/3480/diff/ Testing --- Used in a SystemC transactor Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3480: misc: add a MasterId to the ExternalPort
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/ --- (Updated Jan. 9, 2017, 12:19 p.m.) Review request for Default. Repository: gem5 Description (updated) --- Changeset 11793:3a8e34a03c9e --- misc: add a MasterId to the ExternalPort The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster to allow external modules to easily genrerate new Requests. Diffs (updated) - src/mem/external_master.cc c10c50cb8ac9 src/mem/ExternalMaster.py c10c50cb8ac9 src/mem/external_master.hh c10c50cb8ac9 Diff: http://reviews.gem5.org/r/3480/diff/ Testing --- Used in a SystemC transactor Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3480: misc: add a MasterId to the ExternalPort
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/#review8987 --- Ship it! Ship It! - Andreas Hansson On Oct. 26, 2016, 4:06 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3480/ > --- > > (Updated Oct. 26, 2016, 4:06 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > The Request constructor requires a MasterID. However, an external transactor > has no chance of getting a MasterID as it does not have a pointer to the > System. This patch adds a MasterID to ExternalMaster in order to allow > external modules to genrerate Packets. > > > Diffs > - > > src/mem/ExternalMaster.py b3d5f0e9e258 > src/mem/external_master.hh b3d5f0e9e258 > src/mem/external_master.cc b3d5f0e9e258 > > Diff: http://reviews.gem5.org/r/3480/diff/ > > > Testing > --- > > Used in a SystemC transactor > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3480: misc: add a MasterId to the ExternalPort
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/ --- (Updated Oct. 26, 2016, 4:06 p.m.) Review request for Default. Changes --- updated the diff: rebased on 11691 and generated with mq Repository: gem5 Description --- The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets. Diffs (updated) - src/mem/ExternalMaster.py b3d5f0e9e258 src/mem/external_master.hh b3d5f0e9e258 src/mem/external_master.cc b3d5f0e9e258 Diff: http://reviews.gem5.org/r/3480/diff/ Testing --- Used in a SystemC transactor Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3480: misc: add a MasterId to the ExternalPort
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/ --- (Updated June 6, 2016, 9:57 a.m.) Review request for Default. Summary (updated) - misc: add a MasterId to the ExternalPort Repository: gem5 Description --- The Request constructor requires a MasterID. However, an external transactor has no chance of getting a MasterID as it does not have a pointer to the System. This patch adds a MasterID to ExternalMaster in order to allow external modules to genrerate Packets. Diffs - src/mem/external_master.hh 54cf9a388a9d src/mem/external_master.cc 54cf9a388a9d src/mem/ExternalMaster.py 54cf9a388a9d Diff: http://reviews.gem5.org/r/3480/diff/ Testing --- Used in a SystemC transactor Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
