Re: [gem5-dev] Review Request 3637: mem: Functional page tables data structure change
> On Sept. 27, 2016, 10:17 p.m., Andreas Hansson wrote: > > Surely an unordered_map also only allows a single entry per key. Correct! This patch actually replaced typedef m5::hash_map PTable; with typedef std::map PTable; The problem was m5::hash_map was implemented as a multimap which holds multiple values for the same key. However, your commit: changeset: 11168:f98eb2da15a4 user:Andreas Hansson date:Mon Oct 12 04:07:59 2015 -0400 summary: misc: Remove redundant compiler-specific defines changed typedef m5::hash_map PTable; to typedef std::unordered_map PTable; which does not hold multiple values for one key. Therefore, there is no need for this patch. - Alexandru --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3637/#review8739 --- On Sept. 27, 2016, 10:11 p.m., Alexandru Dutu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3637/ > --- > > (Updated Sept. 27, 2016, 10:11 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11656:82d65f294a37 > --- > mem: Functional page tables data structure change > This patch changes the inner data structure of the functional page table from > a std::unodereded_map, which allows duplicates, to a std::map, which does not. > > > Diffs > - > > src/mem/page_table.hh 2c111e634da005e2b78981fadd0368662454f2ed > > Diff: http://reviews.gem5.org/r/3637/diff/ > > > Testing > --- > > > Thanks, > > Alexandru Dutu > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3637: mem: Functional page tables data structure change
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3637/#review8739 --- Surely an unordered_map also only allows a single entry per key. - Andreas Hansson On Sept. 27, 2016, 10:11 p.m., Alexandru Dutu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3637/ > --- > > (Updated Sept. 27, 2016, 10:11 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11656:82d65f294a37 > --- > mem: Functional page tables data structure change > This patch changes the inner data structure of the functional page table from > a std::unodereded_map, which allows duplicates, to a std::map, which does not. > > > Diffs > - > > src/mem/page_table.hh 2c111e634da005e2b78981fadd0368662454f2ed > > Diff: http://reviews.gem5.org/r/3637/diff/ > > > Testing > --- > > > Thanks, > > Alexandru Dutu > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Review Request 3637: mem: Functional page tables data structure change
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3637/ --- Review request for Default. Repository: gem5 Description --- Changeset 11656:82d65f294a37 --- mem: Functional page tables data structure change This patch changes the inner data structure of the functional page table from a std::unodereded_map, which allows duplicates, to a std::map, which does not. Diffs - src/mem/page_table.hh 2c111e634da005e2b78981fadd0368662454f2ed Diff: http://reviews.gem5.org/r/3637/diff/ Testing --- Thanks, Alexandru Dutu ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
