Re: [gem5-dev] Review Request 3686: misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3686/#review9119 --- Ship it! Ship It! - Andreas Hansson On Oct. 28, 2016, 4:55 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3686/ > --- > > (Updated Oct. 28, 2016, 4:55 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11691:9733d3adf993 > --- > misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port > > > Diffs > - > > util/tlm/sc_slave_port.hh PRE-CREATION > util/tlm/sc_slave_port.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3686/diff/ > > > Testing > --- > > Example applications are still running. > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3686: misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3686/#review9005 --- Ship it! Ship It! - Matthias Jung On Okt. 28, 2016, 4:55 nachm., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3686/ > --- > > (Updated Okt. 28, 2016, 4:55 nachm.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11691:9733d3adf993 > --- > misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port > > > Diffs > - > > util/tlm/sc_slave_port.hh PRE-CREATION > util/tlm/sc_slave_port.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3686/diff/ > > > Testing > --- > > Example applications are still running. > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3686: misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3686/ --- (Updated Oct. 28, 2016, 4:55 p.m.) Review request for Default. Summary (updated) - misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port Repository: gem5 Description (updated) --- Changeset 11691:9733d3adf993 --- misc: use a simple_initiator_socket to implement the SystemC TLM Slave Port Diffs (updated) - util/tlm/sc_slave_port.hh PRE-CREATION util/tlm/sc_slave_port.cc PRE-CREATION Diff: http://reviews.gem5.org/r/3686/diff/ Testing --- Example applications are still running. Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3686: misc: use a simple_initiator_socket to implement the SystemC TLM slave port
> On Oct. 26, 2016, 7:22 p.m., Andreas Hansson wrote: > > Somehow the patch is not displaying. Did you use hg postreview? > > Christian Menard wrote: > Hi Andreas! Thanks for your reviews, I will give them a look soon. I > wanted to do some cleaning up anyway as there are still some inconsistencies > in master and slave port. > > I uploaded the patches manually since I don't have the postreview > extension. Where can I get it? The link on the wiki is broken. No worries. The link is updated. - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3686/#review8990 --- On Oct. 26, 2016, 4:26 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3686/ > --- > > (Updated Oct. 26, 2016, 4:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > This patch simplifies the implementation of the SystemC TLM slave port. > > > Diffs > - > > util/tlm/sc_slave_port.hh c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 > util/tlm/sc_slave_port.cc c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 > > Diff: http://reviews.gem5.org/r/3686/diff/ > > > Testing > --- > > Example applications are still running. > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3686: misc: use a simple_initiator_socket to implement the SystemC TLM slave port
> On Oct. 26, 2016, 7:22 p.m., Andreas Hansson wrote: > > Somehow the patch is not displaying. Did you use hg postreview? Hi Andreas! Thanks for your reviews, I will give them a look soon. I wanted to do some cleaning up anyway as there are still some inconsistencies in master and slave port. I uploaded the patches manually since I don't have the postreview extension. Where can I get it? The link on the wiki is broken. - Christian --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3686/#review8990 --- On Oct. 26, 2016, 4:26 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3686/ > --- > > (Updated Oct. 26, 2016, 4:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > This patch simplifies the implementation of the SystemC TLM slave port. > > > Diffs > - > > util/tlm/sc_slave_port.hh c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 > util/tlm/sc_slave_port.cc c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 > > Diff: http://reviews.gem5.org/r/3686/diff/ > > > Testing > --- > > Example applications are still running. > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3686: misc: use a simple_initiator_socket to implement the SystemC TLM slave port
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3686/#review8990 --- Somehow the patch is not displaying. Did you use hg postreview? - Andreas Hansson On Oct. 26, 2016, 4:26 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3686/ > --- > > (Updated Oct. 26, 2016, 4:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > This patch simplifies the implementation of the SystemC TLM slave port. > > > Diffs > - > > util/tlm/sc_slave_port.hh c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 > util/tlm/sc_slave_port.cc c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 > > Diff: http://reviews.gem5.org/r/3686/diff/ > > > Testing > --- > > Example applications are still running. > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Review Request 3686: misc: use a simple_initiator_socket to implement the SystemC TLM slave port
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3686/ --- Review request for Default. Repository: gem5 Description --- This patch simplifies the implementation of the SystemC TLM slave port. Diffs - util/tlm/sc_slave_port.hh c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 util/tlm/sc_slave_port.cc c6e92c923a9e1c8cfd06ce9da1f61476ae4cb007 Diff: http://reviews.gem5.org/r/3686/diff/ Testing --- Example applications are still running. Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
