Re: [gem5-dev] Review Request 3689: tests, ruby: Move rubytests from ALPHA (linux) to NULL (none)
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3689/#review9040 --- Ship it! Ship It! - Brad Beckmann On Oct. 27, 2016, 7:50 a.m., Andreas Hansson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3689/ > --- > > (Updated Oct. 27, 2016, 7:50 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11706:e542abbd3730 > --- > tests, ruby: Move rubytests from ALPHA (linux) to NULL (none) > > This patch avoids compiling ALPHA six times as part of running > 'util/regress', and instead relis on NULL with different protocols to > run the rubytest. All we need is the memory system, so there is really > no need to compile the ISA over and over again. > > The one downside is the removal of running 'hello' for the variuos > ALPHA and protocol combinations, but if this is a concern we should > rather beef up the synthetic tests for the variuos protocols. > > > Diffs > - > > tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby/simout PRE-CREATION > tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby/stats.txt > PRE-CREATION > util/regress c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/config.ini > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/simerr > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/simout > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/stats.txt > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/config.ini > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/simerr > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/simout > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/stats.txt > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/config.ini > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/simerr > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/simout > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/stats.txt > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/config.ini > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/simerr > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/simout > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/stats.txt > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/config.ini > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/simerr > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/simout > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/stats.txt > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/config.ini > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/simerr > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/simout > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/stats.txt > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/config.ini > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/simerr > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/simout > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/stats.txt > c38fcdaa5fe5 > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/config.ini > c38fcdaa5fe5 > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/simerr > c38fcdaa5fe5 > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/simout > c38fcdaa5fe5 > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/stats.txt > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby-MESI_Two_Level/config.ini > PRE-CREATION > >
Re: [gem5-dev] Review Request 3689: tests, ruby: Move rubytests from ALPHA (linux) to NULL (none)
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3689/#review8996 --- Ship it! I'd like to update these tests to do more than 100 "checks". You could do it now (line 72 of rubytest-ruby.py). I tested 10 which took ~20 seconds on my Skylake machine. Or, I can submit a patch after this is checked in. It's up to you. Thanks for doing this! - Jason Lowe-Power On Oct. 27, 2016, 7:50 a.m., Andreas Hansson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3689/ > --- > > (Updated Oct. 27, 2016, 7:50 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11706:e542abbd3730 > --- > tests, ruby: Move rubytests from ALPHA (linux) to NULL (none) > > This patch avoids compiling ALPHA six times as part of running > 'util/regress', and instead relis on NULL with different protocols to > run the rubytest. All we need is the memory system, so there is really > no need to compile the ISA over and over again. > > The one downside is the removal of running 'hello' for the variuos > ALPHA and protocol combinations, but if this is a concern we should > rather beef up the synthetic tests for the variuos protocols. > > > Diffs > - > > tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby/simout PRE-CREATION > tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby/stats.txt > PRE-CREATION > util/regress c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/config.ini > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/simerr > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/simout > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/stats.txt > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/config.ini > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/simerr > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/simout > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/stats.txt > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/config.ini > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/simerr > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/simout > c38fcdaa5fe5 > > tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/stats.txt > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/config.ini > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/simerr > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/simout > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/stats.txt > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/config.ini > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/simerr > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/simout > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/stats.txt > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/config.ini > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/simerr > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/simout > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/stats.txt > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/config.ini > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/simerr > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/simout > c38fcdaa5fe5 > > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/stats.txt > c38fcdaa5fe5 > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/config.ini > c38fcdaa5fe5 > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/simerr > c38fcdaa5fe5 > tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/simout > c38fcdaa5fe5
[gem5-dev] Review Request 3689: tests, ruby: Move rubytests from ALPHA (linux) to NULL (none)
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3689/ --- Review request for Default. Repository: gem5 Description --- Changeset 11706:e542abbd3730 --- tests, ruby: Move rubytests from ALPHA (linux) to NULL (none) This patch avoids compiling ALPHA six times as part of running 'util/regress', and instead relis on NULL with different protocols to run the rubytest. All we need is the memory system, so there is really no need to compile the ISA over and over again. The one downside is the removal of running 'hello' for the variuos ALPHA and protocol combinations, but if this is a concern we should rather beef up the synthetic tests for the variuos protocols. Diffs - tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby/simout PRE-CREATION tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby/stats.txt PRE-CREATION util/regress c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/config.ini c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/simerr c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/simout c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_directory/stats.txt c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/config.ini c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/simerr c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/simout c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_CMP_token/stats.txt c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/config.ini c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/simerr c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/simout c38fcdaa5fe5 tests/quick/se/00.hello/ref/alpha/linux/simple-timing-ruby-MOESI_hammer/stats.txt c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/config.ini c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/simerr c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/simout c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MESI_Two_Level/stats.txt c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/config.ini c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/simerr c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/simout c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_directory/stats.txt c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/config.ini c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/simerr c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/simout c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_CMP_token/stats.txt c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/config.ini c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/simerr c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/simout c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby-MOESI_hammer/stats.txt c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/config.ini c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/simerr c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/simout c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/alpha/linux/rubytest-ruby/stats.txt c38fcdaa5fe5 tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby-MESI_Two_Level/config.ini PRE-CREATION tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby-MESI_Two_Level/simerr PRE-CREATION tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby-MESI_Two_Level/simout PRE-CREATION tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby-MESI_Two_Level/stats.txt PRE-CREATION tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby-MOESI_CMP_directory/config.ini PRE-CREATION tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby-MOESI_CMP_directory/simerr PRE-CREATION tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby-MOESI_CMP_directory/simout PRE-CREATION tests/quick/se/60.rubytest/ref/null/none/rubytest-ruby-MOESI_CMP_directory/stats.txt PRE-CREATION
