Re: [gem5-dev] Review Request 3695: misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/6]

2017-02-02 Thread Matthias Jung

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3695/#review9371
---

Ship it!


Ship It!

- Matthias Jung


On Jan. 30, 2017, 4:49 nachm., Christian Menard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3695/
> ---
> 
> (Updated Jan. 30, 2017, 4:49 nachm.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11797:10f25f7e5c12
> ---
> misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/6]
> 
> The current TLM bridge only provides a Slave Port that allows the gem5 world 
> to
> send request to the SystemC world. This patch series refractors and cleans up
> the existing code, and adds a Master Port that allows the SystemC world to 
> send
> requests to the gem5 world.
> 
> This patch:
>  * Move common code of the example to a common directory.
>  * Move the cli parsing from the SimControl module to a separate example 
> object.
>  * Add comments describing the Gem5SimControl module.
> 
> 
> Diffs
> -
> 
>   util/tlm/examples/common/cli_parser.hh PRE-CREATION 
>   util/tlm/examples/common/cli_parser.cc PRE-CREATION 
>   util/tlm/examples/common/report_handler.hh PRE-CREATION 
>   util/tlm/examples/common/report_handler.cc PRE-CREATION 
>   util/tlm/examples/master_port/SConstruct PRE-CREATION 
>   util/tlm/examples/master_port/main.cc PRE-CREATION 
>   util/tlm/examples/slave_port/SConstruct PRE-CREATION 
>   util/tlm/examples/slave_port/main.cc PRE-CREATION 
>   util/tlm/sim_control.hh PRE-CREATION 
>   util/tlm/sim_control.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3695/diff/
> 
> 
> Testing
> ---
> 
> Examples compile and run.
> 
> 
> Thanks,
> 
> Christian Menard
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request 3695: misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/6]

2017-01-09 Thread Christian Menard

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3695/
---

(Updated Jan. 9, 2017, 12:28 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/6]

The current TLM bridge only provides a Slave Port that allows the gem5 world to
send request to the SystemC world. This patch series refractors and cleans up
the existing code, and adds a Master Port that allows the SystemC world to send
requests to the gem5 world.

This patch:
 * Move common code of the example to a common directory.
 * Move the cli parsing from the SimControl module to a separate example object.


Diffs
-

  util/tlm/examples/common/cli_parser.hh PRE-CREATION 
  util/tlm/examples/common/cli_parser.cc PRE-CREATION 
  util/tlm/examples/common/report_handler.hh PRE-CREATION 
  util/tlm/examples/common/report_handler.cc PRE-CREATION 
  util/tlm/examples/master_port/SConstruct PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/slave_port/SConstruct PRE-CREATION 
  util/tlm/examples/slave_port/main.cc PRE-CREATION 
  util/tlm/sim_control.hh PRE-CREATION 
  util/tlm/sim_control.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3695/diff/


Testing
---

Examples compile and run.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request 3695: misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/6]

2017-01-09 Thread Christian Menard

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3695/
---

(Updated Jan. 9, 2017, 12:28 p.m.)


Review request for Default.


Summary (updated)
-

misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/6]


Repository: gem5


Description (updated)
---

Changeset 11797:035faad3e946
---
misc: Clean up and complete the gem5<->SystemC-TLM bridge [4/6]

The current TLM bridge only provides a Slave Port that allows the gem5 world to
send request to the SystemC world. This patch series refractors and cleans up
the existing code, and adds a Master Port that allows the SystemC world to send
requests to the gem5 world.

This patch:
 * Move common code of the example to a common directory.
 * Move the cli parsing from the SimControl module to a separate example object.


Diffs (updated)
-

  util/tlm/examples/common/cli_parser.hh PRE-CREATION 
  util/tlm/examples/common/cli_parser.cc PRE-CREATION 
  util/tlm/examples/common/report_handler.hh PRE-CREATION 
  util/tlm/examples/common/report_handler.cc PRE-CREATION 
  util/tlm/examples/master_port/SConstruct PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/slave_port/SConstruct PRE-CREATION 
  util/tlm/examples/slave_port/main.cc PRE-CREATION 
  util/tlm/sim_control.hh PRE-CREATION 
  util/tlm/sim_control.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3695/diff/


Testing
---

Examples compile and run.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev