Re: [gem5-dev] Review Request 3740: commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60

2016-11-30 Thread Andreas Sandberg 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3740/#review9176
---

Ship it!


Ship It!

- Andreas Sandberg


On Nov. 29, 2016, 11:54 p.m., Rahul Thakur wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3740/
> ---
> 
> (Updated Nov. 29, 2016, 11:54 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11708:02ce0fdd4929
> ---
> commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60
> Author: Rahul Thakur 
> Date:   Thu Oct 27 20:36:16 2016 -0700
> 
> mem: Refactor CommMonitor stats, add basic atomic mode stats
> 
> Change-Id: I978f1155873b3882e16d9cd74e86400efd9c5e3b
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.hh 1d085f66c4ca 
>   src/mem/comm_monitor.cc 1d085f66c4ca 
> 
> Diff: http://reviews.gem5.org/r/3740/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rahul Thakur
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3740: commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60

2016-11-29 Thread Rahul Thakur 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3740/
---

(Updated Nov. 29, 2016, 11:54 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11708:02ce0fdd4929
---
commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60
Author: Rahul Thakur 
Date:   Thu Oct 27 20:36:16 2016 -0700

mem: Refactor CommMonitor stats, add basic atomic mode stats

Change-Id: I978f1155873b3882e16d9cd74e86400efd9c5e3b


Diffs (updated)
-

  src/mem/comm_monitor.hh 1d085f66c4ca 
  src/mem/comm_monitor.cc 1d085f66c4ca 

Diff: http://reviews.gem5.org/r/3740/diff/


Testing
---


Thanks,

Rahul Thakur

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3740: commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60

2016-11-24 Thread Andreas Sandberg 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3740/#review9170
---

Ship it!


Looks good, thanks for fixing! You might want to consider the comments below 
before pushing the change.


src/mem/comm_monitor.cc (line 280)


This condition seems redunant since you check the same thing in the 
MonitorStats class. In fact, it might be a bit confusing if someone descides to 
extend the stat class in the future.



src/mem/comm_monitor.cc (line 332)


See above.


- Andreas Sandberg


On Nov. 21, 2016, 7:03 p.m., Rahul Thakur wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3740/
> ---
> 
> (Updated Nov. 21, 2016, 7:03 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11708:33c0089caa50
> ---
> commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60
> Author: Rahul Thakur 
> Date:   Thu Oct 27 20:36:16 2016 -0700
> 
> mem: Refactor CommMonitor stats, add basic atomic mode stats
> 
> Change-Id: I978f1155873b3882e16d9cd74e86400efd9c5e3b
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.hh 1d085f66c4ca 
>   src/mem/comm_monitor.cc 1d085f66c4ca 
> 
> Diff: http://reviews.gem5.org/r/3740/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rahul Thakur
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3740: commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60

2016-11-22 Thread Andreas Hansson 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3740/#review9155
---



src/mem/comm_monitor.hh (line 5)


I think this should be:

Copyright [1]
Copyright [2]
All rights reserved

Also, if you do not _need_ the first paragraph (which is  not vanilla 
3-clause BSD), I would suggest to move the Google Inc copyright so that it 
appears after the first paragraph, and only applying to the following two 
paragraphs.

If you do move it, please keep the All rights reserved as is. Also check 
the other patch concerning the license.


- Andreas Hansson


On Nov. 21, 2016, 7:03 p.m., Rahul Thakur wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3740/
> ---
> 
> (Updated Nov. 21, 2016, 7:03 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11708:33c0089caa50
> ---
> commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60
> Author: Rahul Thakur 
> Date:   Thu Oct 27 20:36:16 2016 -0700
> 
> mem: Refactor CommMonitor stats, add basic atomic mode stats
> 
> Change-Id: I978f1155873b3882e16d9cd74e86400efd9c5e3b
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.hh 1d085f66c4ca 
>   src/mem/comm_monitor.cc 1d085f66c4ca 
> 
> Diff: http://reviews.gem5.org/r/3740/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rahul Thakur
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3740: commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60

2016-11-22 Thread Pierre-Yves Péneau 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3740/#review9148
---

Ship it!


Ship It!

- Pierre-Yves Péneau


On Nov. 21, 2016, 8:03 p.m., Rahul Thakur wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3740/
> ---
> 
> (Updated Nov. 21, 2016, 8:03 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11708:33c0089caa50
> ---
> commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60
> Author: Rahul Thakur 
> Date:   Thu Oct 27 20:36:16 2016 -0700
> 
> mem: Refactor CommMonitor stats, add basic atomic mode stats
> 
> Change-Id: I978f1155873b3882e16d9cd74e86400efd9c5e3b
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.hh 1d085f66c4ca 
>   src/mem/comm_monitor.cc 1d085f66c4ca 
> 
> Diff: http://reviews.gem5.org/r/3740/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rahul Thakur
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3740: commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60

2016-11-21 Thread Rahul Thakur 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3740/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11708:33c0089caa50
---
commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60
Author: Rahul Thakur 
Date:   Thu Oct 27 20:36:16 2016 -0700

mem: Refactor CommMonitor stats, add basic atomic mode stats

Change-Id: I978f1155873b3882e16d9cd74e86400efd9c5e3b


Diffs
-

  src/mem/comm_monitor.hh 1d085f66c4ca 
  src/mem/comm_monitor.cc 1d085f66c4ca 

Diff: http://reviews.gem5.org/r/3740/diff/


Testing
---


Thanks,

Rahul Thakur

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev