Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]
> On Feb. 11, 2017, 6:09 p.m., Jason Lowe-Power wrote: > > This no longer applies cleanly. I think it's probably something I screwed > > up when pushing all of the patches. I tried to go through and manually fix > > the rejections, but I'm not confident in how to do it. > > > > Could you update this diff on top of the current mainline? I'll commit it > > immediately once you do. > > > > Sorry for the inconvenience. On my machine the patch applied cleanly after pulling from upstream. I updated the diff anyway and hope it works now. - Christian --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3777/#review9417 --- On Feb. 12, 2017, 9:37 a.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3777/ > --- > > (Updated Feb. 12, 2017, 9:37 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11831:d89e145b7665 > --- > misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] > > The current TLM bridge only provides a Slave Port that allows the gem5 world > to > send request to the SystemC world. This patch series refractors and cleans up > the existing code, and adds a Master Port that allows the SystemC world to > send > requests to the gem5 world. > > This patch: > * Update the README > > > Diffs > - > > util/tlm/README c10c50cb8ac9 > > Diff: http://reviews.gem5.org/r/3777/diff/ > > > Testing > --- > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3777/ --- (Updated Feb. 12, 2017, 9:37 a.m.) Review request for Default. Repository: gem5 Description (updated) --- Changeset 11831:d89e145b7665 --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Update the README Diffs (updated) - util/tlm/README c10c50cb8ac9 Diff: http://reviews.gem5.org/r/3777/diff/ Testing --- Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3777/#review9417 --- This no longer applies cleanly. I think it's probably something I screwed up when pushing all of the patches. I tried to go through and manually fix the rejections, but I'm not confident in how to do it. Could you update this diff on top of the current mainline? I'll commit it immediately once you do. Sorry for the inconvenience. - Jason Lowe-Power On Feb. 5, 2017, 1:15 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3777/ > --- > > (Updated Feb. 5, 2017, 1:15 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11815:357f61d007cd > --- > misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] > > The current TLM bridge only provides a Slave Port that allows the gem5 world > to > send request to the SystemC world. This patch series refractors and cleans up > the existing code, and adds a Master Port that allows the SystemC world to > send > requests to the gem5 world. > > This patch: > * Update the README > > > Diffs > - > > util/tlm/README c10c50cb8ac9 > > Diff: http://reviews.gem5.org/r/3777/diff/ > > > Testing > --- > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]
> On Feb. 11, 2017, 5:43 p.m., Andreas Hansson wrote: > > I think this one did not get committed. Is that right? Oops. That was an accidental oversight. Thanks for pointing it out. - Jason --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3777/#review9415 --- On Feb. 5, 2017, 1:15 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3777/ > --- > > (Updated Feb. 5, 2017, 1:15 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11815:357f61d007cd > --- > misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] > > The current TLM bridge only provides a Slave Port that allows the gem5 world > to > send request to the SystemC world. This patch series refractors and cleans up > the existing code, and adds a Master Port that allows the SystemC world to > send > requests to the gem5 world. > > This patch: > * Update the README > > > Diffs > - > > util/tlm/README c10c50cb8ac9 > > Diff: http://reviews.gem5.org/r/3777/diff/ > > > Testing > --- > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3777/#review9415 --- Ship it! I think this one did not get committed. Is that right? - Andreas Hansson On Feb. 5, 2017, 1:15 p.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3777/ > --- > > (Updated Feb. 5, 2017, 1:15 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11815:357f61d007cd > --- > misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] > > The current TLM bridge only provides a Slave Port that allows the gem5 world > to > send request to the SystemC world. This patch series refractors and cleans up > the existing code, and adds a Master Port that allows the SystemC world to > send > requests to the gem5 world. > > This patch: > * Update the README > > > Diffs > - > > util/tlm/README c10c50cb8ac9 > > Diff: http://reviews.gem5.org/r/3777/diff/ > > > Testing > --- > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3777: misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10]
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3777/ --- (Updated Feb. 5, 2017, 1:15 p.m.) Review request for Default. Summary (updated) - misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] Repository: gem5 Description (updated) --- Changeset 11815:357f61d007cd --- misc: Clean up and complete the gem5<->SystemC-TLM bridge [6/10] The current TLM bridge only provides a Slave Port that allows the gem5 world to send request to the SystemC world. This patch series refractors and cleans up the existing code, and adds a Master Port that allows the SystemC world to send requests to the gem5 world. This patch: * Update the README Diffs (updated) - util/tlm/README c10c50cb8ac9 Diff: http://reviews.gem5.org/r/3777/diff/ Testing --- Thanks, Christian Menard ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
