Re: [gem5-dev] Review Request 3801: mem, misc: fix building issue with CommMonitor (unused variables)

2017-02-04 Thread Pierre-Yves Péneau 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3801/
---

(Updated Feb. 4, 2017, 8:33 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11808:e0730e1d7afa
---
misc: fix building issue (undefined variables)

Signed-off-by: Pierre-Yves Péneau 
Reviewed-by: Andreas Hansson 
Reviewed-by: Jason Lowe-Power 


Diffs
-

  src/mem/comm_monitor.cc 63325e5b0a9d 

Diff: http://reviews.gem5.org/r/3801/diff/


Testing
---


Thanks,

Pierre-Yves Péneau

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3801: mem, misc: fix building issue with CommMonitor (unused variables)

2017-02-04 Thread Jason Lowe-Power 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3801/#review9399
---

Ship it!


Ship It!

- Jason Lowe-Power


On Feb. 3, 2017, 9:04 a.m., Pierre-Yves Péneau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3801/
> ---
> 
> (Updated Feb. 3, 2017, 9:04 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11808:e0730e1d7afa
> ---
> misc: fix building issue (undefined variables)
> 
> Signed-off-by: Pierre-Yves Péneau 
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 63325e5b0a9d 
> 
> Diff: http://reviews.gem5.org/r/3801/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pierre-Yves Péneau
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3801: mem, misc: fix building issue with CommMonitor (unused variables)

2017-02-03 Thread Pierre-Yves Péneau 


> On Feb. 3, 2017, 9:58 a.m., Andreas Hansson wrote:
> > Thanks for fixing. Could you make it "mem:" and also include CommMonitor in 
> > the description. I also expect this is due to unused variables in fast 
> > builds? Not undefined variables.

Yes, this is unused variables, thank you for pointing this.


- Pierre-Yves


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3801/#review9386
---


On Feb. 3, 2017, 10:04 a.m., Pierre-Yves Péneau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3801/
> ---
> 
> (Updated Feb. 3, 2017, 10:04 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11808:e0730e1d7afa
> ---
> misc: fix building issue (undefined variables)
> 
> Signed-off-by: Pierre-Yves Péneau 
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 63325e5b0a9d 
> 
> Diff: http://reviews.gem5.org/r/3801/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pierre-Yves Péneau
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3801: mem, misc: fix building issue with CommMonitor (unused variables)

2017-02-03 Thread Andreas Hansson 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3801/#review9387
---

Ship it!


Ship It!

- Andreas Hansson


On Feb. 3, 2017, 9:04 a.m., Pierre-Yves Péneau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3801/
> ---
> 
> (Updated Feb. 3, 2017, 9:04 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11808:e0730e1d7afa
> ---
> misc: fix building issue (undefined variables)
> 
> Signed-off-by: Pierre-Yves Péneau 
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 63325e5b0a9d 
> 
> Diff: http://reviews.gem5.org/r/3801/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pierre-Yves Péneau
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3801: mem, misc: fix building issue with CommMonitor (unused variables)

2017-02-03 Thread Pierre-Yves Péneau 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3801/
---

(Updated Feb. 3, 2017, 10:04 a.m.)


Review request for Default.


Summary (updated)
-

mem, misc: fix building issue with CommMonitor (unused variables)


Repository: gem5


Description
---

Changeset 11808:e0730e1d7afa
---
misc: fix building issue (undefined variables)

Signed-off-by: Pierre-Yves Péneau 


Diffs
-

  src/mem/comm_monitor.cc 63325e5b0a9d 

Diff: http://reviews.gem5.org/r/3801/diff/


Testing
---


Thanks,

Pierre-Yves Péneau

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev