Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

[Andreas Hansson]

Great! Thanks Jason.

On 15/02/2017, 21:06, "gem5-dev on behalf of Jason Lowe-Power"
 wrote:

>I just pushed the other patch.
>
>Cheers,
>Jason
>
>On Wed, Feb 15, 2017 at 2:48 PM Brandon Potter 
>wrote:
>
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviews.gem5.org/r/3813/
>>
>> On February 15th, 2017, 8:46 p.m. UTC, *Jason Lowe-Power* wrote:
>>
>> Same as http://reviews.gem5.org/r/3801?
>>
>> Thanks for pointing that out; I hadn't noticed the other review.
>>
>> I'll close this one, but can we ship the other patch now that it has
>>several ShipIts?
>>
>>
>> - Brandon
>>
>> On February 15th, 2017, 8:43 p.m. UTC, Brandon Potter wrote:
>> Review request for Default.
>> By Brandon Potter.
>>
>> *Updated Feb. 15, 2017, 8:43 p.m.*
>> *Repository: * gem5
>> Description
>>
>> Changeset 11834:8623109df37d
>> ---
>> mem: add M5_VAR_USED to comm_monitor function vars
>>
>> Diffs
>>
>>- src/mem/comm_monitor.cc (0e73ec98b6bc0758e43d0bc2cb46228acfa47313)
>>
>> View Diff 
>>
>___
>gem5-dev mailing list
>gem5-dev@gem5.org
>http://m5sim.org/mailman/listinfo/gem5-dev

IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

[Jason Lowe-Power]

I just pushed the other patch.

Cheers,
Jason

On Wed, Feb 15, 2017 at 2:48 PM Brandon Potter 
wrote:

> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3813/
>
> On February 15th, 2017, 8:46 p.m. UTC, *Jason Lowe-Power* wrote:
>
> Same as http://reviews.gem5.org/r/3801?
>
> Thanks for pointing that out; I hadn't noticed the other review.
>
> I'll close this one, but can we ship the other patch now that it has several 
> ShipIts?
>
>
> - Brandon
>
> On February 15th, 2017, 8:43 p.m. UTC, Brandon Potter wrote:
> Review request for Default.
> By Brandon Potter.
>
> *Updated Feb. 15, 2017, 8:43 p.m.*
> *Repository: * gem5
> Description
>
> Changeset 11834:8623109df37d
> ---
> mem: add M5_VAR_USED to comm_monitor function vars
>
> Diffs
>
>- src/mem/comm_monitor.cc (0e73ec98b6bc0758e43d0bc2cb46228acfa47313)
>
> View Diff 
>
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

[Brandon Potter]

> On Feb. 15, 2017, 8:46 p.m., Jason Lowe-Power wrote:
> > Same as http://reviews.gem5.org/r/3801?

Thanks for pointing that out; I hadn't noticed the other review.

I'll close this one, but can we ship the other patch now that it has several 
ShipIts?


- Brandon


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3813/#review9429
---


On Feb. 15, 2017, 8:43 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3813/
> ---
> 
> (Updated Feb. 15, 2017, 8:43 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11834:8623109df37d
> ---
> mem: add M5_VAR_USED to comm_monitor function vars
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 0e73ec98b6bc0758e43d0bc2cb46228acfa47313 
> 
> Diff: http://reviews.gem5.org/r/3813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

[Andreas Hansson]

> On Feb. 15, 2017, 8:46 p.m., Andreas Hansson wrote:
> > It's not the third time this is resolved :-)
> > 
> > http://reviews.gem5.org/r/3801/
> > 
> > Jason, is there any chance you could push the aforementioned patch?

s/not/now/


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3813/#review9430
---


On Feb. 15, 2017, 8:43 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3813/
> ---
> 
> (Updated Feb. 15, 2017, 8:43 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11834:8623109df37d
> ---
> mem: add M5_VAR_USED to comm_monitor function vars
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 0e73ec98b6bc0758e43d0bc2cb46228acfa47313 
> 
> Diff: http://reviews.gem5.org/r/3813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

[Andreas Hansson]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3813/#review9430
---


It's not the third time this is resolved :-)

http://reviews.gem5.org/r/3801/

Jason, is there any chance you could push the aforementioned patch?

- Andreas Hansson


On Feb. 15, 2017, 8:43 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3813/
> ---
> 
> (Updated Feb. 15, 2017, 8:43 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11834:8623109df37d
> ---
> mem: add M5_VAR_USED to comm_monitor function vars
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 0e73ec98b6bc0758e43d0bc2cb46228acfa47313 
> 
> Diff: http://reviews.gem5.org/r/3813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

[Jason Lowe-Power]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3813/#review9429
---


Same as http://reviews.gem5.org/r/3801?

- Jason Lowe-Power


On Feb. 15, 2017, 8:43 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3813/
> ---
> 
> (Updated Feb. 15, 2017, 8:43 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11834:8623109df37d
> ---
> mem: add M5_VAR_USED to comm_monitor function vars
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 0e73ec98b6bc0758e43d0bc2cb46228acfa47313 
> 
> Diff: http://reviews.gem5.org/r/3813/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3813: mem: add M5_VAR_USED to comm_monitor function vars

[Brandon Potter]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3813/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11834:8623109df37d
---
mem: add M5_VAR_USED to comm_monitor function vars


Diffs
-

  src/mem/comm_monitor.cc 0e73ec98b6bc0758e43d0bc2cb46228acfa47313 

Diff: http://reviews.gem5.org/r/3813/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev