Re: [gem5-dev] Review Request 3815: sim: fix out-of-bounds error in syscall_desc

2017-02-16 Thread Jason Lowe-Power 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3815/#review9435
---

Ship it!


Minor thing below. Since this is confusing, I think it could use more comments.


src/sim/syscall_desc.cc (line 55)


Can you add a comment here. This is very confusing code. Maybe something 
like 

// RHS is evaluated before LHS and getSyscallArg increments index (passed 
by reference).

Note: you should also add braces, if you add this inline comment.


- Jason Lowe-Power


On Feb. 16, 2017, 5:39 p.m., Brandon Potter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3815/
> ---
> 
> (Updated Feb. 16, 2017, 5:39 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11849:9152df7d2747
> ---
> sim: fix out-of-bounds error in syscall_desc
> 
> 
> Diffs
> -
> 
>   src/sim/syscall_desc.cc f438fcbab00edbb36075e1403da75cb9a9ac7f55 
> 
> Diff: http://reviews.gem5.org/r/3815/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Brandon Potter
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3815: sim: fix out-of-bounds error in syscall_desc

2017-02-16 Thread Brandon Potter 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3815/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11849:9152df7d2747
---
sim: fix out-of-bounds error in syscall_desc


Diffs
-

  src/sim/syscall_desc.cc f438fcbab00edbb36075e1403da75cb9a9ac7f55 

Diff: http://reviews.gem5.org/r/3815/diff/


Testing
---


Thanks,

Brandon Potter

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev