Re: [gem5-dev] Review Request 3277: sim: Add support for notifying Drainable objects of a fork

2016-02-23 Thread Alexandru Dutu

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3277/#review8029
---

Ship it!


Ship It!

- Alexandru Dutu


On Jan. 14, 2016, 6:30 p.m., Andreas Sandberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3277/
> ---
> 
> (Updated Jan. 14, 2016, 6:30 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11297:80ea5f59f09a
> ---
> sim: Add support for notifying Drainable objects of a fork
> 
> When forking a gem5 process, some objects need to clean up resources
> (mainly file descriptions) shared between the child and the parent of
> the fork. This changeset adds the notifyFork() method to Drainable,
> which is called in the child process.
> 
> Signed-off-by: Andreas Sandberg 
> [sascha.bisch...@arm.com: Rebased patches onto a newer gem5 version]
> Signed-off-by: Sascha Bischoff 
> Signed-off-by: Andreas Sandberg 
> 
> 
> Diffs
> -
> 
>   src/python/m5/simulate.py 14029d75688d 
>   src/sim/drain.hh 14029d75688d 
> 
> Diff: http://reviews.gem5.org/r/3277/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sandberg
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request 3277: sim: Add support for notifying Drainable objects of a fork

2016-02-23 Thread Jason Lowe-Power

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3277/#review8025
---

Ship it!


Ship It!

- Jason Lowe-Power


On Jan. 14, 2016, 6:30 p.m., Andreas Sandberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3277/
> ---
> 
> (Updated Jan. 14, 2016, 6:30 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11297:80ea5f59f09a
> ---
> sim: Add support for notifying Drainable objects of a fork
> 
> When forking a gem5 process, some objects need to clean up resources
> (mainly file descriptions) shared between the child and the parent of
> the fork. This changeset adds the notifyFork() method to Drainable,
> which is called in the child process.
> 
> Signed-off-by: Andreas Sandberg 
> [sascha.bisch...@arm.com: Rebased patches onto a newer gem5 version]
> Signed-off-by: Sascha Bischoff 
> Signed-off-by: Andreas Sandberg 
> 
> 
> Diffs
> -
> 
>   src/python/m5/simulate.py 14029d75688d 
>   src/sim/drain.hh 14029d75688d 
> 
> Diff: http://reviews.gem5.org/r/3277/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Sandberg
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev