Re: [gem5-dev] Review Request 3480: ExternalMaster: add a masterId so that external ports can generate packages
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/#review8383 --- Ship it! Ship It! - Matthias Jung On Mai 26, 2016, 11:38 vorm., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3480/ > --- > > (Updated Mai 26, 2016, 11:38 vorm.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > The Request constructor requires a MasterID. However, an external transactor > has no chance of getting a MasterID as it does not have a pointer to the > System. This patch adds a MasterID to ExternalMaster in order to allow > external modules to genrerate Packets. > > > Diffs > - > > src/mem/external_master.hh 54cf9a388a9d > src/mem/external_master.cc 54cf9a388a9d > src/mem/ExternalMaster.py 54cf9a388a9d > > Diff: http://reviews.gem5.org/r/3480/diff/ > > > Testing > --- > > Used in a SystemC transactor > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3480: ExternalMaster: add a masterId so that external ports can generate packages
> On May 28, 2016, 7:21 p.m., Matthias Jung wrote: > > Are the examples in /util/tlm and /util/systemc still working with this > > change? > > Andreas Hansson wrote: > What is the SystemC license? Should we consider including all/parts in > ext/ so that we can always build (and test) this support? > > Matthias Jung wrote: > Hi Andreas, > SystemC has its own licence, called SystemC Open Source Licence. I don't > know if this fits to gem5's BSD licence ... > > > http://accellera.org/images/about/policies/SystemC_Open_Source_License_v3.3.pdf > > Regards > Matthias > > Andreas Hansson wrote: > Thanks for the pointer. > > Seems there are whole book-chapters on this topic(!). Not as easy as I > had hoped. The Patch has no influence on the examples as /util/systemc does not use external ports and /util/tlm only implements an external TLM slave port. However, I'am working on a external TLM master port, so that I can connect other CPU models to gem5's memory system. I need to generate packets from TLM transactions in the external module and therefore need a MasterID. - Christian --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/#review8371 --- On May 26, 2016, 11:38 a.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3480/ > --- > > (Updated May 26, 2016, 11:38 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > The Request constructor requires a MasterID. However, an external transactor > has no chance of getting a MasterID as it does not have a pointer to the > System. This patch adds a MasterID to ExternalMaster in order to allow > external modules to genrerate Packets. > > > Diffs > - > > src/mem/external_master.hh 54cf9a388a9d > src/mem/external_master.cc 54cf9a388a9d > src/mem/ExternalMaster.py 54cf9a388a9d > > Diff: http://reviews.gem5.org/r/3480/diff/ > > > Testing > --- > > Used in a SystemC transactor > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3480: ExternalMaster: add a masterId so that external ports can generate packages
> On May 28, 2016, 7:21 p.m., Matthias Jung wrote: > > Are the examples in /util/tlm and /util/systemc still working with this > > change? > > Andreas Hansson wrote: > What is the SystemC license? Should we consider including all/parts in > ext/ so that we can always build (and test) this support? > > Matthias Jung wrote: > Hi Andreas, > SystemC has its own licence, called SystemC Open Source Licence. I don't > know if this fits to gem5's BSD licence ... > > > http://accellera.org/images/about/policies/SystemC_Open_Source_License_v3.3.pdf > > Regards > Matthias Thanks for the pointer. Seems there are whole book-chapters on this topic(!). Not as easy as I had hoped. - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/#review8371 --- On May 26, 2016, 11:38 a.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3480/ > --- > > (Updated May 26, 2016, 11:38 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > The Request constructor requires a MasterID. However, an external transactor > has no chance of getting a MasterID as it does not have a pointer to the > System. This patch adds a MasterID to ExternalMaster in order to allow > external modules to genrerate Packets. > > > Diffs > - > > src/mem/external_master.hh 54cf9a388a9d > src/mem/external_master.cc 54cf9a388a9d > src/mem/ExternalMaster.py 54cf9a388a9d > > Diff: http://reviews.gem5.org/r/3480/diff/ > > > Testing > --- > > Used in a SystemC transactor > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3480: ExternalMaster: add a masterId so that external ports can generate packages
> On Mai 28, 2016, 7:21 nachm., Matthias Jung wrote: > > Are the examples in /util/tlm and /util/systemc still working with this > > change? > > Andreas Hansson wrote: > What is the SystemC license? Should we consider including all/parts in > ext/ so that we can always build (and test) this support? Hi Andreas, SystemC has its own licence, called SystemC Open Source Licence. I don't know if this fits to gem5's BSD licence ... http://accellera.org/images/about/policies/SystemC_Open_Source_License_v3.3.pdf Regards Matthias - Matthias --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/#review8371 --- On Mai 26, 2016, 11:38 vorm., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3480/ > --- > > (Updated Mai 26, 2016, 11:38 vorm.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > The Request constructor requires a MasterID. However, an external transactor > has no chance of getting a MasterID as it does not have a pointer to the > System. This patch adds a MasterID to ExternalMaster in order to allow > external modules to genrerate Packets. > > > Diffs > - > > src/mem/external_master.hh 54cf9a388a9d > src/mem/external_master.cc 54cf9a388a9d > src/mem/ExternalMaster.py 54cf9a388a9d > > Diff: http://reviews.gem5.org/r/3480/diff/ > > > Testing > --- > > Used in a SystemC transactor > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3480: ExternalMaster: add a masterId so that external ports can generate packages
> On May 28, 2016, 7:21 p.m., Matthias Jung wrote: > > Are the examples in /util/tlm and /util/systemc still working with this > > change? What is the SystemC license? Should we consider including all/parts in ext/ so that we can always build (and test) this support? - Andreas --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/#review8371 --- On May 26, 2016, 11:38 a.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3480/ > --- > > (Updated May 26, 2016, 11:38 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > The Request constructor requires a MasterID. However, an external transactor > has no chance of getting a MasterID as it does not have a pointer to the > System. This patch adds a MasterID to ExternalMaster in order to allow > external modules to genrerate Packets. > > > Diffs > - > > src/mem/external_master.hh 54cf9a388a9d > src/mem/external_master.cc 54cf9a388a9d > src/mem/ExternalMaster.py 54cf9a388a9d > > Diff: http://reviews.gem5.org/r/3480/diff/ > > > Testing > --- > > Used in a SystemC transactor > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3480: ExternalMaster: add a masterId so that external ports can generate packages
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/#review8371 --- Are the examples in /util/tlm and /util/systemc still working with this change? - Matthias Jung On Mai 26, 2016, 11:38 vorm., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3480/ > --- > > (Updated Mai 26, 2016, 11:38 vorm.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > The Request constructor requires a MasterID. However, an external transactor > has no chance of getting a MasterID as it does not have a pointer to the > System. This patch adds a MasterID to ExternalMaster in order to allow > external modules to genrerate Packets. > > > Diffs > - > > src/mem/external_master.hh 54cf9a388a9d > src/mem/external_master.cc 54cf9a388a9d > src/mem/ExternalMaster.py 54cf9a388a9d > > Diff: http://reviews.gem5.org/r/3480/diff/ > > > Testing > --- > > Used in a SystemC transactor > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3480: ExternalMaster: add a masterId so that external ports can generate packages
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3480/#review8352 --- Ship it! Ship It! - Jason Lowe-Power On May 26, 2016, 11:38 a.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3480/ > --- > > (Updated May 26, 2016, 11:38 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > The Request constructor requires a MasterID. However, an external transactor > has no chance of getting a MasterID as it does not have a pointer to the > System. This patch adds a MasterID to ExternalMaster in order to allow > external modules to genrerate Packets. > > > Diffs > - > > src/mem/external_master.hh 54cf9a388a9d > src/mem/external_master.cc 54cf9a388a9d > src/mem/ExternalMaster.py 54cf9a388a9d > > Diff: http://reviews.gem5.org/r/3480/diff/ > > > Testing > --- > > Used in a SystemC transactor > > > Thanks, > > Christian Menard > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
