Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9290 --- Ship it! Ship It! - Jason Lowe-Power On Jan. 19, 2017, 6:28 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3789/ > --- > > (Updated Jan. 19, 2017, 6:28 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11795:54750ac27cf7 > --- > syscall_emul: #ifdef new system calls to allow builds on OSX and BSD > > > Diffs > - > > src/sim/syscall_emul.cc 97eebddaae84b4c0e555255375f283bbf653862a > src/sim/syscall_emul.hh 97eebddaae84b4c0e555255375f283bbf653862a > > Diff: http://reviews.gem5.org/r/3789/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9289 --- Ship it! Ship It! - Pierre-Yves Péneau On Jan. 19, 2017, 7:28 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3789/ > --- > > (Updated Jan. 19, 2017, 7:28 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11795:54750ac27cf7 > --- > syscall_emul: #ifdef new system calls to allow builds on OSX and BSD > > > Diffs > - > > src/sim/syscall_emul.cc 97eebddaae84b4c0e555255375f283bbf653862a > src/sim/syscall_emul.hh 97eebddaae84b4c0e555255375f283bbf653862a > > Diff: http://reviews.gem5.org/r/3789/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9279 --- Ship it! Ship It! - Tony Gutierrez On Jan. 19, 2017, 10:28 a.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3789/ > --- > > (Updated Jan. 19, 2017, 10:28 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11795:54750ac27cf7 > --- > syscall_emul: #ifdef new system calls to allow builds on OSX and BSD > > > Diffs > - > > src/sim/syscall_emul.cc 97eebddaae84b4c0e555255375f283bbf653862a > src/sim/syscall_emul.hh 97eebddaae84b4c0e555255375f283bbf653862a > > Diff: http://reviews.gem5.org/r/3789/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/ --- (Updated Jan. 19, 2017, 6:28 p.m.) Review request for Default. Repository: gem5 Description (updated) --- Changeset 11795:54750ac27cf7 --- syscall_emul: #ifdef new system calls to allow builds on OSX and BSD Diffs (updated) - src/sim/syscall_emul.cc 97eebddaae84b4c0e555255375f283bbf653862a src/sim/syscall_emul.hh 97eebddaae84b4c0e555255375f283bbf653862a Diff: http://reviews.gem5.org/r/3789/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD
> On Jan. 19, 2017, 5:33 p.m., Tony Gutierrez wrote: > > LGTM, but just to clarify, you don't need to guard the inclusion of any > > system headers? There's a preexisting macro in that file for stat64 which uses the same exclusion method. It's verbatim what I copied except that I don't check against Cygwin. - Brandon --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9274 --- On Jan. 19, 2017, 5:30 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3789/ > --- > > (Updated Jan. 19, 2017, 5:30 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11795:559c8086a868 > --- > syscall_emul: #ifdef new system calls to allow builds on OSX and BSD > > > Diffs > - > > src/sim/syscall_emul.hh 97eebddaae84b4c0e555255375f283bbf653862a > src/sim/syscall_emul.cc 97eebddaae84b4c0e555255375f283bbf653862a > > Diff: http://reviews.gem5.org/r/3789/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3789: syscall_emul: #ifdef new system calls to allow builds on OSX and BSD
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3789/#review9274 --- Ship it! LGTM, but just to clarify, you don't need to guard the inclusion of any system headers? - Tony Gutierrez On Jan. 19, 2017, 9:30 a.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3789/ > --- > > (Updated Jan. 19, 2017, 9:30 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11795:559c8086a868 > --- > syscall_emul: #ifdef new system calls to allow builds on OSX and BSD > > > Diffs > - > > src/sim/syscall_emul.hh 97eebddaae84b4c0e555255375f283bbf653862a > src/sim/syscall_emul.cc 97eebddaae84b4c0e555255375f283bbf653862a > > Diff: http://reviews.gem5.org/r/3789/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
