[m5-dev] Review Request: X86: Convert operand types to the new style.

2011-04-25 Thread Gabe Black

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/657/
---

Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan 
Binkert.


Summary
---

X86: Convert operand types to the new style.


Diffs
-

  src/arch/x86/isa/operands.isa de679a068dd8 

Diff: http://reviews.m5sim.org/r/657/diff


Testing
---


Thanks,

Gabe

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev


Re: [m5-dev] Trace not working

2011-04-25 Thread Beckmann, Brad
Maybe I'm doing something stupid here, but on a  clean checkout, the following 
short patch encounters the subsequent compiler error:

diff --git a/src/mem/SConscript b/src/mem/SConscript
--- a/src/mem/SConscript
+++ b/src/mem/SConscript
@@ -57,6 +57,7 @@
 TraceFlag('BusAddrRanges')
 TraceFlag('BusBridge')
 TraceFlag('LLSC')
+TraceFlag('FlagCheck')
 TraceFlag('MMU')
 TraceFlag('MemoryAccess')
 
diff --git a/src/mem/port.cc b/src/mem/port.cc
--- a/src/mem/port.cc
+++ b/src/mem/port.cc
@@ -106,6 +106,7 @@
 Port::setPeer(Port *port)
 {
 DPRINTF(Config, setting peer to %s\n, port-name());
+DPRINTF(FlagCheck, check setting peer to %s\n, port-name());
 
 peer = port;
 }


Error:

scons: Building targets ...
 [ CXX] X86_SE_MOESI_hammer/mem/port.cc - .do
build/X86_SE_MOESI_hammer/mem/port.cc: In member function 'virtual void 
Port::setPeer(Port*)':
build/X86_SE_MOESI_hammer/mem/port.cc:109: error: 'FlagCheck' is not a member 
of 'Debug'
 [SWIG] X86_SE_MOESI_hammer/python/m5/internal/vptype_IntLink.i - 
_wrap.cc, .py
 [SWIG] X86_SE_MOESI_hammer/python/m5/internal/vptype_AddrRange.i - 
_wrap.cc, .py
scons: *** [build/X86_SE_MOESI_hammer/mem/port.do] Error 1
 [SWIG] X86_SE_MOESI_hammer/python/m5/internal/vptype_Process.i - 
_wrap.cc, .py
scons: building terminated because of errors.

Brad


 -Original Message-
 From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On
 Behalf Of nathan binkert
 Sent: Monday, April 25, 2011 5:29 PM
 To: M5 Developer List
 Subject: Re: [m5-dev] Trace not working
 
  However, I am confused as well on how to add a new
 TraceFlag/DebugFlag.  It seems that all the previous flags are still
 specified using the TraceFlag() function, but I can't seem to be able
 to specify a new one.    Also to be consistent, should we change the
 name of the TraceFlag function to DebugFlag?
 
 You should still use the TraceFlag function in SCons.  Are you sure
 this doesn't work?  And yes, I should probably rename TraceFlag to
 DebugFlag.
 
   Nate
 ___
 m5-dev mailing list
 m5-dev@m5sim.org
 http://m5sim.org/mailman/listinfo/m5-dev


___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev