Re: [m5-dev] [PATCH 1 of 4] X86: Make x86 use PREFETCH instead of PF_EXCLUSIVE

[nathan binkert]

Gabe, can you send out your patches inline, not as attachments?  Did
you switch intentionally?  It makes it harder to comment on your
changes.

  Nate
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] [PATCH 1 of 4] X86: Make x86 use PREFETCH instead of PF_EXCLUSIVE

[Gabe Black]

nathan binkert wrote:
 Gabe, can you send out your patches inline, not as attachments?  Did
 you switch intentionally?  It makes it harder to comment on your
 changes.

   Nate
 ___
 m5-dev mailing list
 m5-dev@m5sim.org
 http://m5sim.org/mailman/listinfo/m5-dev
   
I thought I had... My command line is below, and I thought that's what
-i did.

hg email -r 6731:6734 -g -i -t 'm5-dev@m5sim.org'

Gabe
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] [PATCH 1 of 4] X86: Make x86 use PREFETCH instead of PF_EXCLUSIVE

[nathan binkert]

 I thought I had... My command line is below, and I thought that's what
 -i did.

 hg email -r 6731:6734 -g -i -t 'm5-dev@m5sim.org'
That's odd.  Anything strange with your .hgrc?  (by the way, you can
put all of -g -i and -t into your .hgrc as defaults)

[defaults]
email = --git

[email]
method = smtp
from = Nathan Binkert n...@binkert.org
to = m5-dev@m5sim.org
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

[m5-dev] [PATCH 1 of 4] X86: Make x86 use PREFETCH instead of PF_EXCLUSIVE

[Gabe Black]

# HG changeset patch
# User Gabe Black gbl...@eecs.umich.edu
# Date 1257749397 28800
# Node ID 530e457c88c7850e84c8df2cb478d566094ad39e
# Parent  eea52bdaf4acce7788ceea2406dc33a24bdda0b2
X86: Make x86 use PREFETCH instead of PF_EXCLUSIVE.

diff --git a/src/arch/x86/isa/microops/ldstop.isa b/src/arch/x86/isa/microops/ldstop.isa
--- a/src/arch/x86/isa/microops/ldstop.isa
+++ b/src/arch/x86/isa/microops/ldstop.isa
@@ -157,7 +157,7 @@
 
 if (fault == NoFault) {
 %(code)s;
-} else if (memFlags  Request::PF_EXCLUSIVE) {
+} else if (memFlags  Request::PREFETCH) {
 // For prefetches, ignore any faults/exceptions.
 return NoFault;
 }
@@ -374,7 +374,7 @@
 if atCPL0:
 self.memFlags +=  | (CPL0FlagBit  FlagShift)
 if prefetch:
-self.memFlags +=  | Request::PF_EXCLUSIVE
+self.memFlags +=  | Request::PREFETCH
 self.memFlags +=  | (machInst.legacy.addr ?  + \
  (AddrSizeFlagBit  FlagShift) : 0)
 
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev