[m5-dev] Review Request: Core: Add some documentation about the sim clocks.

2011-04-10 Thread Ali Saidi

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/636/
---

Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan 
Binkert.


Summary
---

Core: Add some documentation about the sim clocks.


Diffs
-

  src/sim/core.hh 02cb69e5cfeb 

Diff: http://reviews.m5sim.org/r/636/diff


Testing
---


Thanks,

Ali

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev


Re: [m5-dev] Review Request: Core: Add some documentation about the sim clocks.

2011-04-10 Thread Gabe Black

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/636/#review1105
---



src/sim/core.hh
http://reviews.m5sim.org/r/636/#comment1478

The way this is worded makes it hard to understand. How about:

These variables equal the number of ticks in the unit of time they're named 
after.


- Gabe


On 2011-04-10 16:53:18, Ali Saidi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviews.m5sim.org/r/636/
 ---
 
 (Updated 2011-04-10 16:53:18)
 
 
 Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
 Nathan Binkert.
 
 
 Summary
 ---
 
 Core: Add some documentation about the sim clocks.
 
 
 Diffs
 -
 
   src/sim/core.hh 02cb69e5cfeb 
 
 Diff: http://reviews.m5sim.org/r/636/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ali
 


___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev


Re: [m5-dev] Review Request: Core: Add some documentation about the sim clocks.

2011-04-10 Thread Ali Saidi

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/636/#review1106
---



src/sim/core.hh
http://reviews.m5sim.org/r/636/#comment1479

sounds better to me


- Ali


On 2011-04-10 16:53:18, Ali Saidi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviews.m5sim.org/r/636/
 ---
 
 (Updated 2011-04-10 16:53:18)
 
 
 Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
 Nathan Binkert.
 
 
 Summary
 ---
 
 Core: Add some documentation about the sim clocks.
 
 
 Diffs
 -
 
   src/sim/core.hh 02cb69e5cfeb 
 
 Diff: http://reviews.m5sim.org/r/636/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ali
 


___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev