Re: [m5-dev] Review Request: X86: fsincos: Another patch from Vince Weaver

[Gabe Black]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/593/#review1095
---


We never really did decide how we wanted to structure the microops for x87, but 
this seems reasonable at least to start with. The structure of the microop 
definitions need to be cleaned up a little.


src/arch/x86/isa/microops/fpop.isa


Cosfp, Sinfp and the existing Movfp could all inherit from a base class 
(FpUniOp for unary for instance) that has this other form of __init__. Then 
they wouldn't each define an essentially identical copy.


- Gabe


On 2011-03-17 16:07:17, Lisa Hsu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/593/
> ---
> 
> (Updated 2011-03-17 16:07:17)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> X86:  fsincos: Another patch from Vince Weaver
> 
> 
> Diffs
> -
> 
>   src/arch/x86/isa/decoder/x87.isa 2e269d6fb3e6 
>   
> src/arch/x86/isa/insts/x87/transcendental_functions/trigonometric_functions.py
>  2e269d6fb3e6 
>   src/arch/x86/isa/microops/fpop.isa 2e269d6fb3e6 
> 
> Diff: http://reviews.m5sim.org/r/593/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lisa
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: X86: fsincos: Another patch from Vince Weaver

[Lisa Hsu]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/593/#review1057
---


Since there have been no objections, I'm going to commit this.

- Lisa


On 2011-03-17 16:07:17, Lisa Hsu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/593/
> ---
> 
> (Updated 2011-03-17 16:07:17)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> X86:  fsincos: Another patch from Vince Weaver
> 
> 
> Diffs
> -
> 
>   src/arch/x86/isa/decoder/x87.isa 2e269d6fb3e6 
>   
> src/arch/x86/isa/insts/x87/transcendental_functions/trigonometric_functions.py
>  2e269d6fb3e6 
>   src/arch/x86/isa/microops/fpop.isa 2e269d6fb3e6 
> 
> Diff: http://reviews.m5sim.org/r/593/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lisa
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

[m5-dev] Review Request: X86: fsincos: Another patch from Vince Weaver

[Lisa Hsu]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/593/
---

Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan 
Binkert.


Summary
---

X86:  fsincos: Another patch from Vince Weaver


Diffs
-

  src/arch/x86/isa/decoder/x87.isa 2e269d6fb3e6 
  
src/arch/x86/isa/insts/x87/transcendental_functions/trigonometric_functions.py 
2e269d6fb3e6 
  src/arch/x86/isa/microops/fpop.isa 2e269d6fb3e6 

Diff: http://reviews.m5sim.org/r/593/diff


Testing
---


Thanks,

Lisa

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev