Re: [m5-dev] Review Request: ARM: Cache the misc regs at the TLB to limit readMiscReg() calls.

2010-11-09 Thread Gabe Black

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/291/#review444
---


This seems reasonable. Have you measured the actual performance impact?

- Gabe


On 2010-11-08 15:34:31, Ali Saidi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviews.m5sim.org/r/291/
 ---
 
 (Updated 2010-11-08 15:34:31)
 
 
 Review request for Default.
 
 
 Summary
 ---
 
 ARM: Cache the misc regs at the TLB to limit readMiscReg() calls.
 
 
 Diffs
 -
 
   src/arch/arm/isa.cc f61e079ad05e 
   src/arch/arm/tlb.hh f61e079ad05e 
   src/arch/arm/tlb.cc f61e079ad05e 
   src/arch/arm/utility.cc f61e079ad05e 
 
 Diff: http://reviews.m5sim.org/r/291/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ali
 


___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev


Re: [m5-dev] Review Request: ARM: Cache the misc regs at the TLB to limit readMiscReg() calls.

2010-11-09 Thread Ali Saidi


 On 2010-11-09 11:41:36, Gabe Black wrote:
  This seems reasonable. Have you measured the actual performance impact?

~5%


- Ali


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/291/#review444
---


On 2010-11-08 15:34:31, Ali Saidi wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviews.m5sim.org/r/291/
 ---
 
 (Updated 2010-11-08 15:34:31)
 
 
 Review request for Default.
 
 
 Summary
 ---
 
 ARM: Cache the misc regs at the TLB to limit readMiscReg() calls.
 
 
 Diffs
 -
 
   src/arch/arm/isa.cc f61e079ad05e 
   src/arch/arm/tlb.hh f61e079ad05e 
   src/arch/arm/tlb.cc f61e079ad05e 
   src/arch/arm/utility.cc f61e079ad05e 
 
 Diff: http://reviews.m5sim.org/r/291/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Ali
 


___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev