Re: [m5-dev] changeset in m5: ARM: Add support for a dumb IDE controller

2010-11-15 Thread Gabe Black
 On 11/15/10 12:09, Ali Saidi wrote:
 diffs (119 lines):

 diff -r 859e8bc1cdc2 -r 0731d632db76 configs/common/FSConfig.py
 --- a/configs/common/FSConfig.py  Mon Nov 15 14:04:03 2010 -0600
 +++ b/configs/common/FSConfig.py  Mon Nov 15 14:04:03 2010 -0600
 @@ -209,6 +209,16 @@
  
  self.mem_mode = mem_mode
  
 +#self.cf0 = CowIdeDisk(driveID='master')
 +#self.cf0.childImage(mdesc.disk())
 +#self.cf_ctrl = IdeController(disks=[self.cf0],
 +# pci_func = 0, pci_dev = 0, pci_bus = 0,
 +# io_shift = 1, ctrl_offset = 2, Command = 
 0x1,
 +# BAR0 = 0x1800, BAR0Size = '16B',
 +# BAR1 = 0x18000100, BAR1Size = '1B',
 +# BAR0LegacyIO = True, BAR1LegacyIO = True,)
 +#self.cf_ctrl.pio = self.iobus.port
 +
  if machine_type == RealView_PBX:
  self.realview = RealViewPBX()
  elif machine_type == RealView_EB:

Should these lines have been deleted or uncommented? I assume one or the
other.

Gabe
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev


Re: [m5-dev] changeset in m5: ARM: Add support for a dumb IDE controller

2010-11-15 Thread Ali Saidi

On Nov 15, 2010, at 9:52 PM, Gabe Black wrote:

 On 11/15/10 12:09, Ali Saidi wrote:
 diffs (119 lines):
 
 diff -r 859e8bc1cdc2 -r 0731d632db76 configs/common/FSConfig.py
 --- a/configs/common/FSConfig.py Mon Nov 15 14:04:03 2010 -0600
 +++ b/configs/common/FSConfig.py Mon Nov 15 14:04:03 2010 -0600
 @@ -209,6 +209,16 @@
 
 self.mem_mode = mem_mode
 
 +#self.cf0 = CowIdeDisk(driveID='master')
 +#self.cf0.childImage(mdesc.disk())
 +#self.cf_ctrl = IdeController(disks=[self.cf0],
 +# pci_func = 0, pci_dev = 0, pci_bus = 0,
 +# io_shift = 1, ctrl_offset = 2, Command = 
 0x1,
 +# BAR0 = 0x1800, BAR0Size = '16B',
 +# BAR1 = 0x18000100, BAR1Size = '1B',
 +# BAR0LegacyIO = True, BAR1LegacyIO = True,)
 +#self.cf_ctrl.pio = self.iobus.port
 +
 if machine_type == RealView_PBX:
 self.realview = RealViewPBX()
 elif machine_type == RealView_EB:
 
 Should these lines have been deleted or uncommented? I assume one or the
 other.

It was intentional. I didn't want to enable it yet and adding it effects the 
stats, however I also didn't want to have to figure out the addresses and such 
again. It will get uncommented soon.

Ali




___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev