Re: svn commit: r923057 - /gump/metadata/project/commons-proper.xml

2010-03-15 Thread sebb
On 15/03/2010, bode...@apache.org bode...@apache.org wrote:
 Author: bodewig
  Date: Mon Mar 15 05:23:18 2010
  New Revision: 923057

  URL: http://svn.apache.org/viewvc?rev=923057view=rev
  Log:
  canonical property to skip tests in mvn

  Modified:
 gump/metadata/project/commons-proper.xml

  Modified: gump/metadata/project/commons-proper.xml
  URL: 
 http://svn.apache.org/viewvc/gump/metadata/project/commons-proper.xml?rev=923057r1=923056r2=923057view=diff
  
 ==
  --- gump/metadata/project/commons-proper.xml (original)
  +++ gump/metadata/project/commons-proper.xml Mon Mar 15 05:23:18 2010
  @@ -449,7 +449,7 @@
  descriptionCommons I/O Utility Package/description

  mvn basedir=io goal=package
  -  property name=skipTests value=true/
  +  property name=maven.test.skip.exec value=true/

maven.test.skip.exec is deprecated:

http://maven.apache.org/plugins/maven-surefire-plugin/test-mojo.html#skipExec

which is why I used skipTests.

  /mvn

  option project=commons-lang-2.x /




-
To unsubscribe, e-mail: general-unsubscr...@gump.apache.org
For additional commands, e-mail: general-h...@gump.apache.org



Re: svn commit: r923057 - /gump/metadata/project/commons-proper.xml

2010-03-15 Thread Stefan Bodewig
On 2010-03-15, sebb seb...@gmail.com wrote:

 On 15/03/2010, bode...@apache.org bode...@apache.org wrote:

  URL: http://svn.apache.org/viewvc?rev=923057view=rev
  Log:
  canonical property to skip tests in mvn

  -  property name=skipTests value=true/
  + property name=maven.test.skip.exec value=true/

 maven.test.skip.exec is deprecated:

 http://maven.apache.org/plugins/maven-surefire-plugin/test-mojo.html#skipExec

 which is why I used skipTests.

I didn't know that and wanted things to be consistent - we use the now
deprecated version all over the place.

What is plugin version determined by?  The installed mvn version (2.2 by
now) or the project's POM?  skipTests would require Surefire 2.4 to work
and I don't know whether this is actually used by all projects.

Stefan

-
To unsubscribe, e-mail: general-unsubscr...@gump.apache.org
For additional commands, e-mail: general-h...@gump.apache.org



Re: svn commit: r923057 - /gump/metadata/project/commons-proper.xml

2010-03-15 Thread sebb
On 15/03/2010, Stefan Bodewig bode...@apache.org wrote:
 On 2010-03-15, sebb seb...@gmail.com wrote:

   On 15/03/2010, bode...@apache.org bode...@apache.org wrote:


   URL: http://svn.apache.org/viewvc?rev=923057view=rev
Log:
canonical property to skip tests in mvn


   -  property name=skipTests value=true/
+ property name=maven.test.skip.exec value=true/

   maven.test.skip.exec is deprecated:

   
 http://maven.apache.org/plugins/maven-surefire-plugin/test-mojo.html#skipExec

   which is why I used skipTests.


 I didn't know that and wanted things to be consistent - we use the now
  deprecated version all over the place.

  What is plugin version determined by?  The installed mvn version (2.2 by
  now) or the project's POM?

The project POM determines the version, assuming that the POM defines
the version.

  skipTests would require Surefire 2.4 to work
  and I don't know whether this is actually used by all projects.

Good point, but Commons-parent 13 uses 2.5

Note that skipExec itself requires 2.3, so could cause problems if a
project uses an earlier version of surefire.

Only skip is valid for all versions of Surefire, but that is not ideal.

  Stefan

  -
  To unsubscribe, e-mail: general-unsubscr...@gump.apache.org
  For additional commands, e-mail: general-h...@gump.apache.org



-
To unsubscribe, e-mail: general-unsubscr...@gump.apache.org
For additional commands, e-mail: general-h...@gump.apache.org



Re: svn commit: r923057 - /gump/metadata/project/commons-proper.xml

2010-03-15 Thread Stefan Bodewig
On 2010-03-15, sebb seb...@gmail.com wrote:

 On 15/03/2010, Stefan Bodewig bode...@apache.org wrote:
 On 2010-03-15, sebb seb...@gmail.com wrote:

 On 15/03/2010, bode...@apache.org bode...@apache.org wrote:


  URL: http://svn.apache.org/viewvc?rev=923057view=rev
  Log:
  canonical property to skip tests in mvn


  -  property name=skipTests value=true/
 property name=maven.test.skip.exec value=true/

 maven.test.skip.exec is deprecated:

 http://maven.apache.org/plugins/maven-surefire-plugin/test-mojo.html#skipExec

 which is why I used skipTests.


 I didn't know that and wanted things to be consistent - we use the now
 deprecated version all over the place.

  What is plugin version determined by?  The installed mvn version (2.2 by
  now) or the project's POM?

 The project POM determines the version, assuming that the POM defines
 the version.

  skipTests would require Surefire 2.4 to work
  and I don't know whether this is actually used by all projects.

 Good point, but Commons-parent 13 uses 2.5

I've reverted the commons-io project, if it works we can start moving
over other occurances of maven.test.skip.exec.  It wouldn't be the first
mvn property that failed to work as advertised in the Gump context
(project.build.finalName is one such example) - it may be that we just
don't understand Maven well enough, though.

Stefan

-
To unsubscribe, e-mail: general-unsubscr...@gump.apache.org
For additional commands, e-mail: general-h...@gump.apache.org



Re: svn commit: r920715 - /gump/metadata/project/excalibur.xml

2010-03-15 Thread Stefan Bodewig
On 2010-03-15, Bill Barker billwbar...@verizon.net wrote:

 --
 From: Stefan Bodewig bode...@apache.org
 Sent: Sunday, March 14, 2010 10:20 PM
 To: general@gump.apache.org
 Subject: Re: svn commit: r920715 - /gump/metadata/project/excalibur.xml

 On 2010-03-13, Bill Barker billwbar...@verizon.net wrote:

 Yeah, downloaded the src distro for maven 2.2.1, and it is that it is
 that the 'central' repo is disabled for SNAPSHOTs (and it is looking
 for a SNAPSHOT POM).  So Maven never asks to get it (even though it is
 there).

 Do I understand this correctly that with Maven 2.2 Gump will not be able
 to inject its own jars if the POM specifies a dependency on a SNAPSHOT
 version?

 I think that this is a setting for 'central', that it disables
 SNAPSHOT versions (understandable from the Maven prospective).  It's
 just that Maven won't download a SNAPSHOT version from 'central'.
 Reactor builds with SNAPSHOT should still work.

I see.  SNAPSHOTs then will likely be pulled from different repositories
and we'd need to make the Maven proxy intercept those as well.

 Briefly thought of overriding this in either the local or global
 settings, but then realized that I don't know enough about Maven to
 get it right in the first 10 tries ;).  That is why I was hoping that
 there is still a Maven guru lurking here.

Same here.

Stefan

-
To unsubscribe, e-mail: general-unsubscr...@gump.apache.org
For additional commands, e-mail: general-h...@gump.apache.org



Re: svn commit: r920715 - /gump/metadata/project/excalibur.xml

2010-03-15 Thread Bill Barker



--
From: Stefan Bodewig bode...@apache.org
Sent: Monday, March 15, 2010 8:01 AM
To: general@gump.apache.org
Subject: Re: svn commit: r920715 - /gump/metadata/project/excalibur.xml


On 2010-03-15, Bill Barker billwbar...@verizon.net wrote:


--
From: Stefan Bodewig bode...@apache.org
Sent: Sunday, March 14, 2010 10:20 PM
To: general@gump.apache.org
Subject: Re: svn commit: r920715 - /gump/metadata/project/excalibur.xml



On 2010-03-13, Bill Barker billwbar...@verizon.net wrote:



Yeah, downloaded the src distro for maven 2.2.1, and it is that it is
that the 'central' repo is disabled for SNAPSHOTs (and it is looking
for a SNAPSHOT POM).  So Maven never asks to get it (even though it is
there).



Do I understand this correctly that with Maven 2.2 Gump will not be able
to inject its own jars if the POM specifies a dependency on a SNAPSHOT
version?



I think that this is a setting for 'central', that it disables
SNAPSHOT versions (understandable from the Maven prospective).  It's
just that Maven won't download a SNAPSHOT version from 'central'.
Reactor builds with SNAPSHOT should still work.


I see.  SNAPSHOTs then will likely be pulled from different repositories
and we'd need to make the Maven proxy intercept those as well.



Or, like for hudson, they just won't be found.  I was thinking of adding a 
localRepository=name to the mvn / builder that allows projects to share 
a local repo when they can't be trusted to use the central repo.  These 
would be cleaned when Gump finishes (or maybe on startup).


Then the projects could use a goal of 'install', and it looks like Maven 
will accept it for another project that wants to depend on that SNAPSHOT 
version.



Briefly thought of overriding this in either the local or global
settings, but then realized that I don't know enough about Maven to
get it right in the first 10 tries ;).  That is why I was hoping that
there is still a Maven guru lurking here.


Same here.

Stefan

-
To unsubscribe, e-mail: general-unsubscr...@gump.apache.org
For additional commands, e-mail: general-h...@gump.apache.org



-
To unsubscribe, e-mail: general-unsubscr...@gump.apache.org
For additional commands, e-mail: general-h...@gump.apache.org