Re: Patch review process
Let's move this over to common-dev@, general@ is normally used for project announcements rather than discussion topics. I'd like to summarize a few things mentioned on the private@ thread, related to streamlining the code submission process. - Gerrit was brought up again, as it has in the past, as something that could make the actual process of reviewing and committing a lot easier. This would be especially helpful for small patches, where the mechanics of committing can take longer than reviewing the patch. - There were also concerns about forking discussions between JIRA and Gerrit. This has been an issue in Spark, and we'd like to keep discussions and issue tracking centralized. - Some talk about how to improve precommit. Right now it takes hours to run the unit tests, which slows down patch iterations. One solution is running tests in parallel (and even distributed). Previous distributed experiments have done a full unit test run in a couple minutes, but it'd be a fair amount of work to actually make this production ready. - Also mention of putting in place more linting and static analysis. Automating this will save reviewer time. Best, Andrew On Mon, Jan 26, 2015 at 9:16 AM, Ted Yu yuzhih...@gmail.com wrote: In some cases, contributor responded to review comments and attached patches addressing the comments. Later on, there was simply no response to the latest patch - even with follow-on ping. I wish this aspect can be improved. Cheers On Sun, Jan 25, 2015 at 6:03 PM, Tsz Wo (Nicholas), Sze s29752-hadoopgene...@yahoo.com.invalid wrote: Hi contributors, I would like to (re)start a discussion regrading to our patch review process. A similar discussion has been happened in a the hadoop private mailing list, which is inappropriate. Here is the problem:The patch available queues become longer and longer. It seems that we never can catch up. There are patches sitting in the queues for years. How could we speed up? Regrads,Tsz-Wo
Re: Patch review process
In some cases, contributor responded to review comments and attached patches addressing the comments. Later on, there was simply no response to the latest patch - even with follow-on ping. I wish this aspect can be improved. Cheers On Sun, Jan 25, 2015 at 6:03 PM, Tsz Wo (Nicholas), Sze s29752-hadoopgene...@yahoo.com.invalid wrote: Hi contributors, I would like to (re)start a discussion regrading to our patch review process. A similar discussion has been happened in a the hadoop private mailing list, which is inappropriate. Here is the problem:The patch available queues become longer and longer. It seems that we never can catch up. There are patches sitting in the queues for years. How could we speed up? Regrads,Tsz-Wo
Re: Patch review process
On 26 January 2015 at 02:03, Tsz Wo (Nicholas), Sze s29752-hadoopgene...@yahoo.com.invalid wrote: I would like to (re)start a discussion regrading to our patch review process. A similar discussion has been happened in a the hadoop private mailing list, which is inappropriate. owning up to me starting that discussion, but it was originally a meta-discussion I want to start discussing this problem on common-dev ... just get some agreement that we all felt there was a problem. I believe that is the case. Here is the problem:The patch available queues become longer and longer. It seems that we never can catch up. There are patches sitting in the queues for years. How could we speed up? If anyone want's to join in in this discussion, we've moved it to the common-...@hadoop.apache.org list. Please join in. -Steve -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.
Patch review process
Hi contributors, I would like to (re)start a discussion regrading to our patch review process. A similar discussion has been happened in a the hadoop private mailing list, which is inappropriate. Here is the problem:The patch available queues become longer and longer. It seems that we never can catch up. There are patches sitting in the queues for years. How could we speed up? Regrads,Tsz-Wo
