Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Goson zhang
Hi Justin,

Before, we noticed the authorization difference between the versions of
berkeleydb-je component, so we adjusted it from version 6.x.y to 7.3.x.
Next, we will analyze again, if there is a problem, we will adjust the
implementation and replace it.

Luciano Resende  于2020年8月3日周一 下午2:10写道:

> +1 (binding), with similar comments as below from Justin.
> The LICENSE needs some cleanup, and probably a different license file
> for source and binary distribution.
> Built ok for me
>
> On Sun, Aug 2, 2020 at 3:15 AM Justin Mclean 
> wrote:
> >
> > Hi,
> >
> > +1 (binding)
> >
> > However if it wasn’t for the Incubating WIP disclaimer I would be -1.
> >
> > The LICENSE issues where brought up last time [1] It is best if some
> work is done to improve each release so it better than the last. Please ask
> your mentors to help with this.
> >
> > I checked:
> > - incubating in names.
> > - signature and hashes correct.
> > - LICENSE incorrectly list dependancies rather than what is bundled in
> the release.
> > - LICENSE don’t list point to full license text so is unlikely yo comply
> with 3rd party license terms.
> > - NOTICE is very likely missing information from other Apache license
> NOTICE files, but with all dependancies included it’s hard to know for sure.
> > - All files have ASF headers
> > - Failed to compile from source
> >
> > I didn’t check the binary artefacts.
> >
> > It would be interesting to know where these come from [2] and how they
> were licensed.
> >
> > More concerning is why teh build is failing wth this:
> > [ERROR] Failed to execute goal on project tubemq-all: Could not resolve
> dependencies for project org.apache.tubemq:tubemq-all:pom:0.5.0-incubating:
> Could not find artifact
> org.apache.tubemq:tubemq-server:tar.gz:bin:0.5.0-incubating in
> berkeleydb-je (https://download.dcache.org/nexus/repository/berkeleydb-je/)
> -> [Help 1]
> >
> > Why does the source release depend on the binary one?
> >
> > Thanks,
> > Justin
> >
> > 1.
> https://lists.apache.org/thread.html/r875e3e1abe41369611e7c0c6610ac29af35c552cddc3088e4df3f99c%40%3Cgeneral.incubator.apache.org%3E
> > 2. ./resources/assets/public/css/fonts/icon.*
> >
> >
> >
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
>
>
> --
> Luciano Resende
> http://twitter.com/lresende1975
> http://lresende.blogspot.com/
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Luciano Resende
+1 (binding), with similar comments as below from Justin.
The LICENSE needs some cleanup, and probably a different license file
for source and binary distribution.
Built ok for me

On Sun, Aug 2, 2020 at 3:15 AM Justin Mclean  wrote:
>
> Hi,
>
> +1 (binding)
>
> However if it wasn’t for the Incubating WIP disclaimer I would be -1.
>
> The LICENSE issues where brought up last time [1] It is best if some work is 
> done to improve each release so it better than the last. Please ask your 
> mentors to help with this.
>
> I checked:
> - incubating in names.
> - signature and hashes correct.
> - LICENSE incorrectly list dependancies rather than what is bundled in the 
> release.
> - LICENSE don’t list point to full license text so is unlikely yo comply with 
> 3rd party license terms.
> - NOTICE is very likely missing information from other Apache license NOTICE 
> files, but with all dependancies included it’s hard to know for sure.
> - All files have ASF headers
> - Failed to compile from source
>
> I didn’t check the binary artefacts.
>
> It would be interesting to know where these come from [2] and how they were 
> licensed.
>
> More concerning is why teh build is failing wth this:
> [ERROR] Failed to execute goal on project tubemq-all: Could not resolve 
> dependencies for project org.apache.tubemq:tubemq-all:pom:0.5.0-incubating: 
> Could not find artifact 
> org.apache.tubemq:tubemq-server:tar.gz:bin:0.5.0-incubating in berkeleydb-je 
> (https://download.dcache.org/nexus/repository/berkeleydb-je/) -> [Help 1]
>
> Why does the source release depend on the binary one?
>
> Thanks,
> Justin
>
> 1. 
> https://lists.apache.org/thread.html/r875e3e1abe41369611e7c0c6610ac29af35c552cddc3088e4df3f99c%40%3Cgeneral.incubator.apache.org%3E
> 2. ./resources/assets/public/css/fonts/icon.*
>
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>


-- 
Luciano Resende
http://twitter.com/lresende1975
http://lresende.blogspot.com/

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Justin Mclean
Hi,

> We have paid attention to this issue, the berkeleydb-je as of version 7.3, JE 
> is licensed under the Apache 2.0 license:
> https://docs.oracle.com/cd/E17277_02/html/relnotes.html 
> 
Good to know. Sadly with some 3rd party software just because something says 
it's bundled under the Apache license doesn’t means that parts of it are 
compatible with that license. And I not sure if the dual license would still 
apply or not i.e it can only be used for non commercial software. You might 
want to double check those two things.

Thanks,
Justin

Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Goson zhang
Supplement:
[image: image.png]
[image: image.png]



Goson zhang  于2020年8月3日周一 下午1:23写道:

> Hi Justin,
>
> We have paid attention to this issue, the berkeleydb-je as of version 7.3,
> JE is licensed under the Apache 2.0 license:
> https://docs.oracle.com/cd/E17277_02/html/relnotes.html
>
> Justin Mclean  于2020年8月3日周一 下午1:09写道:
>
>> Hi,
>>
>> > berkeleydb-je is a component that TubeMQ relies on to store metadata, it
>> > needs to be downloaded from oracle and requires username and password
>> > access.
>> > For the convenience of everyone, we found this third-party repository (
>> > https://download.dcache .org/nexus/repository/berkeleydb-je/).
>>
>> Well that brings up another issue in that is component is a Category X
>> dependancy. [1][2] (The license is GPL) ASF project can’t depend on other
>> software that have license terms the are incompatible with the Apache
>> license.
>>
>> Thanks,
>> Justin
>>
>> 1.
>> https://www.oracle.com/database/technologies/related/berkeleydb/berkeleydb-licensing.html
>> 2. https://www.oracle.com/downloads/licenses/berkeleydb-oslicense.html
>>
>>
>>


Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Goson zhang
Hi Justin,

We have paid attention to this issue, the berkeleydb-je as of version 7.3,
JE is licensed under the Apache 2.0 license:
https://docs.oracle.com/cd/E17277_02/html/relnotes.html

Justin Mclean  于2020年8月3日周一 下午1:09写道:

> Hi,
>
> > berkeleydb-je is a component that TubeMQ relies on to store metadata, it
> > needs to be downloaded from oracle and requires username and password
> > access.
> > For the convenience of everyone, we found this third-party repository (
> > https://download.dcache .org/nexus/repository/berkeleydb-je/).
>
> Well that brings up another issue in that is component is a Category X
> dependancy. [1][2] (The license is GPL) ASF project can’t depend on other
> software that have license terms the are incompatible with the Apache
> license.
>
> Thanks,
> Justin
>
> 1.
> https://www.oracle.com/database/technologies/related/berkeleydb/berkeleydb-licensing.html
> 2. https://www.oracle.com/downloads/licenses/berkeleydb-oslicense.html
>
>
>


Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Justin Mclean
Hi,

> berkeleydb-je is a component that TubeMQ relies on to store metadata, it
> needs to be downloaded from oracle and requires username and password
> access.
> For the convenience of everyone, we found this third-party repository (
> https://download.dcache .org/nexus/repository/berkeleydb-je/).

Well that brings up another issue in that is component is a Category X 
dependancy. [1][2] (The license is GPL) ASF project can’t depend on other 
software that have license terms the are incompatible with the Apache license.

Thanks,
Justin

1. 
https://www.oracle.com/database/technologies/related/berkeleydb/berkeleydb-licensing.html
2. https://www.oracle.com/downloads/licenses/berkeleydb-oslicense.html



-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Goson zhang
Hi Luciano,

I used the method of clearing the local maven repository cache and
recompiling for verification.

berkeleydb-je is a component that TubeMQ relies on to store metadata, it
needs to be downloaded from oracle and requires username and password
access.
For the convenience of everyone, we found this third-party repository (
https://download.dcache .org/nexus/repository/berkeleydb-je/).

Does the compilation fail because the repository cannot be accessed from
the compiled place, or is it caused by unstable access?


Kevin Ratnasekera  于2020年8月3日周一 下午12:16写道:

> +1 ( binding )
>
> I checked the following. Agree with Justin, Please fix the LICENSE issues
> mentioned above.
>
> 1. Incubating in name.
>
> 2. PGP Signatures.
>
> 3. SHA512 Checksums.
>
> 4. DISCLAIMER-WIP exists.
>
> 5. LICENSE and NOTICE are fine.
>
> 6. No unexpected binary files.
>
> 7. Maven Build Passes on Mac environment.
>
>
> [*INFO*]
> **
>
> [*INFO*] *Reactor Summary for Apache TubeMQ 0.5.0-incubating:*
>
> [*INFO*]
>
> [*INFO*] Apache TubeMQ .. *SUCCESS* [
> 36.758 s]
>
> [*INFO*] Apache TubeMQ - Core ... *SUCCESS*
> [01:01 min]
>
> [*INFO*] Apache TubeMQ - Client . *SUCCESS* [
> 46.286 s]
>
> [*INFO*] Apache TubeMQ - Example  *SUCCESS* [
> 0.975 s]
>
> [*INFO*] Apache TubeMQ - Server . *SUCCESS* [
> 51.014 s]
>
> [*INFO*] Apache TubeMQ - Connectors . *SUCCESS* [
> 0.176 s]
>
> [*INFO*] Apache TubeMQ - Connectors-flink ... *SUCCESS*
> [01:04 min]
>
> [*INFO*] Apache TubeMQ - Connectors-flume ... *SUCCESS*
> [01:10 min]
>
> [*INFO*] Apache TubeMQ - Connectors-spark ... *SUCCESS*
> [02:57 min]
>
> [*INFO*] Apache TubeMQ - Docker . *SUCCESS* [
> 0.215 s]
>
> [*INFO*] Apache TubeMQ - Docker All . *SUCCESS* [
> 0.254 s]
>
> [*INFO*] Apache TubeMQ - Docker Build ... *SUCCESS* [
> 0.184 s]
>
> [*INFO*]
> **
>
> [*INFO*] *BUILD SUCCESS*
>
> [*INFO*]
> **
>
>
> Regards
>
> Kevin
>
> On Mon, Aug 3, 2020 at 8:17 AM Goson zhang  wrote:
>
>> First of all, thanks to Justin and Ming!
>>
>> - For the issues of LICENSE and NOTICE:
>> We have made a change to LICENSE since the last release, we will continue
>> to modify it according to the Apache specification, and ensure that there
>> is no problem before the next release.
>>
>> - For the failed to compile from source:
>> My partners and I cleaned up the maven repository and recompiled, it is
>> passable.
>>
>> Thanks!
>>
>


Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Kevin Ratnasekera
+1 ( binding )

I checked the following. Agree with Justin, Please fix the LICENSE issues
mentioned above.

1. Incubating in name.

2. PGP Signatures.

3. SHA512 Checksums.

4. DISCLAIMER-WIP exists.

5. LICENSE and NOTICE are fine.

6. No unexpected binary files.

7. Maven Build Passes on Mac environment.


[*INFO*]
**

[*INFO*] *Reactor Summary for Apache TubeMQ 0.5.0-incubating:*

[*INFO*]

[*INFO*] Apache TubeMQ .. *SUCCESS* [
36.758 s]

[*INFO*] Apache TubeMQ - Core ... *SUCCESS*
[01:01 min]

[*INFO*] Apache TubeMQ - Client . *SUCCESS* [
46.286 s]

[*INFO*] Apache TubeMQ - Example 
*SUCCESS* [  0.975
s]

[*INFO*] Apache TubeMQ - Server . *SUCCESS* [
51.014 s]

[*INFO*] Apache TubeMQ - Connectors .
*SUCCESS* [  0.176
s]

[*INFO*] Apache TubeMQ - Connectors-flink ... *SUCCESS*
[01:04 min]

[*INFO*] Apache TubeMQ - Connectors-flume ... *SUCCESS*
[01:10 min]

[*INFO*] Apache TubeMQ - Connectors-spark ... *SUCCESS*
[02:57 min]

[*INFO*] Apache TubeMQ - Docker .
*SUCCESS* [  0.215
s]

[*INFO*] Apache TubeMQ - Docker All .
*SUCCESS* [  0.254
s]

[*INFO*] Apache TubeMQ - Docker Build ...
*SUCCESS* [  0.184
s]

[*INFO*]
**

[*INFO*] *BUILD SUCCESS*

[*INFO*]
**


Regards

Kevin

On Mon, Aug 3, 2020 at 8:17 AM Goson zhang  wrote:

> First of all, thanks to Justin and Ming!
>
> - For the issues of LICENSE and NOTICE:
> We have made a change to LICENSE since the last release, we will continue
> to modify it according to the Apache specification, and ensure that there
> is no problem before the next release.
>
> - For the failed to compile from source:
> My partners and I cleaned up the maven repository and recompiled, it is
> passable.
>
> Thanks!
>


Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Luciano Resende
On Sun, Aug 2, 2020 at 7:47 PM Goson zhang  wrote:
>
>
> - For the failed to compile from source:
> My partners and I cleaned up the maven repository and recompiled, it is
> passable.
>

Could you please give more details on what was done on the above?



-- 
Luciano Resende
http://twitter.com/lresende1975
http://lresende.blogspot.com/

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [IP CLEARANCE] Dubbo Getty project contribution

2020-08-02 Thread Justin Mclean
Hi,

> I don’t agree. If Alex owns the copyright to the whole of the dubbogo 
> contribution then his assurance through his ICLA ought to be enough for the 
> ASF.

IMO (legal hat on) Alex doesn’t own the copyright, each individual contributor 
does to the bits they contributed.

Thanks,
Justin
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [IP CLEARANCE] Dubbo Getty project contribution

2020-08-02 Thread Dave Fisher



Sent from my iPhone

> On Aug 2, 2020, at 7:25 PM, Justin Mclean  wrote:
> 
> Hi,
> 
>> Do we need to add all the committers in the IP clearance list of this page?
> 
> Yes it would be good to list them all.

I don’t agree. If Alex owns the copyright to the whole of the dubbogo 
contribution then his assurance through his ICLA ought to be enough for the ASF.

Justin if you think differently please ask on legal-discuss@

Regards,
Dave

> 
> Thanks,
> Justin
> 
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Goson zhang
First of all, thanks to Justin and Ming!

- For the issues of LICENSE and NOTICE:
We have made a change to LICENSE since the last release, we will continue
to modify it according to the Apache specification, and ensure that there
is no problem before the next release.

- For the failed to compile from source:
My partners and I cleaned up the maven repository and recompiled, it is
passable.

Thanks!


Re: [IP CLEARANCE] Dubbo Getty project contribution

2020-08-02 Thread Justin Mclean
Hi,

> Do we need to add all the committers in the IP clearance list of this page?

Yes it would be good to list them all.

Thanks,
Justin

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [IP CLEARANCE] Dubbo Getty project contribution

2020-08-02 Thread Jun Liu
> Do we have ICLAs for all committers?

Yes, I think the project has had all committers signed ICLAs, Alex has 
confirmed this when voting in the dubbo community  
https://lists.apache.org/thread.html/r46e30a742d5ced2daedbab3d45bd3bf8279c372d4fe1b5599dc8dd0f%40%3Cdev.dubbo.apache.org%3E

Do we need to add all the committers in the IP clearance list of this page?

Jun

> On Jul 28, 2020, at 10:44 AM, Justin Mclean  wrote:
> 
> Hi,
> 
> I see there’s more than one committer, but the IP clearance only list one 
> person. Do we have ICLAs for all committers?
> 
> Thanks,
> Justin
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 



[ANNOUNCE] Apache PageSpeed 1.14.36.1 (incubating) released!

2020-08-02 Thread Otto van der Schaaf
The Apache PageSpeed (incubating) community is pleased to announce its
first release: 1.14.36.1.

PageSpeed represents a series of open source technologies to help make
the web faster by rewriting
web pages to reduce latency and bandwidth.

Artifacts from this release are available for download via:
http://pagespeed.incubator.apache.org/doc/download

Release notes:
- pagespeed_libraries.conf: add jquery 3.4.1 (#1938)
- Upgrade our re2 dependency to release 2019-07-01 (#1915)
- Support data-srcset in img and amp-img (#1899)
- Add support for specifying a TTL for redis keys (#1854)
- Fix mismatch between decompression and headers (#1785)
- Handle Apache >2.4 mod_authz_host (#1703)
- Redis: Use Redis DB-Index when computing the SystemCache lookup key (#1776)
- libwebp: update from v0.5.1 to v0.6.1 (#1759)
- third party gprc library upgraded to version 1.6.0 (#1747)
- upgrade libpng1.2 to 1.6

ASF PageSpeed (incubating) slack channel:
https://the-asf.slack.com/archives/CJTG9RH9U

Otto van der Schaaf, on behalf of the Apache PageSpeed (incubating) community.

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache brpc(incubating) 0.9.8-rc01

2020-08-02 Thread Willem Jiang
+1. (binding)

Here are my checks,
1. Signature and Hashed are good.
2. Release commit and Tag are good.
3. LICENSE and NOTICE files are good for me.
4. I can build the binary from the Source release kit by going through
the build readme.
5. DISCLAIMER-WIP is included.

BTW, We need to remove the file of incubator-brpc-0.9.8-rc01.tar.gz
from the release staging directory.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem


On Wed, Jul 15, 2020 at 7:02 PM tan zhongyi  wrote:
>
> Hi, guys,
>
>
>
> I am pleased to be calling this vote for the release of Apache brpc 
> (incubating) 0.9.8-rc01
>
>  BTW: there is still some license issues to be fixed, so we keep  
> DISCLAIMER-WIP there, we will fix them in later releases.
>
>
>
> Apache brpc community has voted and approved the release.
>
>
>
> Vote thread: 
> https://lists.apache.org/thread.html/r5b76897ad047c326d4b580a6c110e17ec26f7cb1db95425248827df8%40%3Cdev.brpc.apache.org%3E
>
>  Results thread: 
> https://lists.apache.org/thread.html/rd6667c2aad6a94238234e07461831cadf08e7ae7e66170dd4b25a694%40%3Cdev.brpc.apache.org%3E
>
>
>
> The release candidate to be voted over is available at:
>
> https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz
>
>
>
>
>
> The SHA-512 checksum is:
>
> 972744e0915b2bf881ad04bae393761170bf91003b44c82dff8ba5306e8081abb5c4108c469a58ac4e4162838a04191fcf681594d89a7d97bbbfa0943cc2f41d
>
> which can be found via:
>
> https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.sha512
>
> The signature can be found via:
>
> https://dist.apache.org/repos/dist/dev/incubator/brpc/0.9.8-rc01/incubator-brpc-0.9.8-rc01.tar.gz.asc
>
> KEYS file is available here:
>
> https://dist.apache.org/repos/dist/dev/incubator/brpc/KEYS
>
>
>
>
>
> [Release Note]
>
> * Fix bug that time unit is not listed in grpc timeout options.
>
> https://github.com/apache/incubator-brpc/pull/1036
>
> * Fix heap overflow in simple_data_pool
>
> https://github.com/apache/incubator-brpc/pull/1056
>
> * Make args of redis protocol be StringPiece
>
> https://github.com/apache/incubator-brpc/pull/1128
>
> * Support the length of redis args could be zero
>
> https://github.com/apache/incubator-brpc/pull/1128
>
> * Optimize code in timer_thread
>
> https://github.com/apache/incubator-brpc/pull/1137/files
>
> * Fix a narrowing warning on aarch64
>
> https://github.com/apache/incubator-brpc/commit/87f149c464ea0322a5b59d040bb80e7847f365be
>
> * Make pthread_atfork not registered in child process
>
> https://github.com/apache/incubator-brpc/commit/2f8fc37d52c2a02ee6f348aaa52c7ded4a4844c3
>
> * Rename LOG_NONE which conflicts with a name in mysql
>
> https://github.com/apache/incubator-brpc/commit/e3840c18cdd9e1ff81f8280b96ac14869007a122
>
> * Fix several warnings under MAC
>
> https://github.com/apache/incubator-brpc/commit/f8c188a7a5186c2d43a20735ad175a32b39788a3
>
> * Ignore ELIMIT for circuit breaker
>
> https://github.com/apache/incubator-brpc/pull/1005
>
> * limit minimum value of max_concurrency for auto_cl
>
> https://github.com/apache/incubator-brpc/pull/1003
>
>
>
>
>
> Please vote on releasing this package as:
>
> Apache brpc(incubating) 0.9.8-rc01
>
>
>
> This vote will be open until “Monday July 20 2020 00:00:00 GMT+0800 (CST)" and
>
> passes if a majority of at least three +1 Apache Incubator IPMC votes are
>
> cast.
>
>
>
> [ ] +1 Release this package
>
> [ ] 0  I don't feel strongly about it, but don't object
>
> [ ] -1 Do not release this package because...
>
>
>
> Anyone can participate in testing and voting, not just committers, please
>
> feel free to try out the release candidate and provide your votes.
>
>
>
> A checklist for reference:
>
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Ming Wen
+1 non-binding

I checked:
- incubating in name.
- DISCLAIMER exists (WIP).
- signature and hashes correct.
- LICENSE is not good which contains a lot of dependencies that shouldn't
be there.
- All files have ASF headers, but some of files's ASF header contains html
 tag [1].

> - LICENSE incorrectly list dependancies rather than what is bundled in
the release.
agreed, you only need to add license to LICENSE if it's code bundled in the
release, Instead of all dependencies.
You can refer to how TLP handles that, for example sykwalking[2].

[1]
https://github.com/apache/incubator-tubemq/blob/0.5.0-incubating-RC0/tubemq-server/src/main/java/org/apache/tubemq/server/Server.java#L8
[2] https://github.com/apache/skywalking/blob/master/LICENSE#L204

Thanks,
Ming Wen, Apache APISIX & Apache SkyWalking
Twitter: _WenMing


Justin Mclean  于2020年8月2日周日 下午6:15写道:

> Hi,
>
> +1 (binding)
>
> However if it wasn’t for the Incubating WIP disclaimer I would be -1.
>
> The LICENSE issues where brought up last time [1] It is best if some work
> is done to improve each release so it better than the last. Please ask your
> mentors to help with this.
>
> I checked:
> - incubating in names.
> - signature and hashes correct.
> - LICENSE incorrectly list dependancies rather than what is bundled in the
> release.
> - LICENSE don’t list point to full license text so is unlikely yo comply
> with 3rd party license terms.
> - NOTICE is very likely missing information from other Apache license
> NOTICE files, but with all dependancies included it’s hard to know for sure.
> - All files have ASF headers
> - Failed to compile from source
>
> I didn’t check the binary artefacts.
>
> It would be interesting to know where these come from [2] and how they
> were licensed.
>
> More concerning is why teh build is failing wth this:
> [ERROR] Failed to execute goal on project tubemq-all: Could not resolve
> dependencies for project org.apache.tubemq:tubemq-all:pom:0.5.0-incubating:
> Could not find artifact
> org.apache.tubemq:tubemq-server:tar.gz:bin:0.5.0-incubating in
> berkeleydb-je (https://download.dcache.org/nexus/repository/berkeleydb-je/)
> -> [Help 1]
>
> Why does the source release depend on the binary one?
>
> Thanks,
> Justin
>
> 1.
> https://lists.apache.org/thread.html/r875e3e1abe41369611e7c0c6610ac29af35c552cddc3088e4df3f99c%40%3Cgeneral.incubator.apache.org%3E
> 2. ./resources/assets/public/css/fonts/icon.*
>
>
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>


Re: [VOTE] Release Apache TubeMQ (Incubating) 0.5.0-incubating RC0

2020-08-02 Thread Justin Mclean
Hi,

+1 (binding)

However if it wasn’t for the Incubating WIP disclaimer I would be -1.

The LICENSE issues where brought up last time [1] It is best if some work is 
done to improve each release so it better than the last. Please ask your 
mentors to help with this.

I checked:
- incubating in names.
- signature and hashes correct.
- LICENSE incorrectly list dependancies rather than what is bundled in the 
release.
- LICENSE don’t list point to full license text so is unlikely yo comply with 
3rd party license terms.
- NOTICE is very likely missing information from other Apache license NOTICE 
files, but with all dependancies included it’s hard to know for sure.
- All files have ASF headers
- Failed to compile from source

I didn’t check the binary artefacts.

It would be interesting to know where these come from [2] and how they were 
licensed.

More concerning is why teh build is failing wth this:
[ERROR] Failed to execute goal on project tubemq-all: Could not resolve 
dependencies for project org.apache.tubemq:tubemq-all:pom:0.5.0-incubating: 
Could not find artifact 
org.apache.tubemq:tubemq-server:tar.gz:bin:0.5.0-incubating in berkeleydb-je 
(https://download.dcache.org/nexus/repository/berkeleydb-je/) -> [Help 1]

Why does the source release depend on the binary one?

Thanks,
Justin

1. 
https://lists.apache.org/thread.html/r875e3e1abe41369611e7c0c6610ac29af35c552cddc3088e4df3f99c%40%3Cgeneral.incubator.apache.org%3E
2. ./resources/assets/public/css/fonts/icon.*



-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org