Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0
Hi, -1 (binding) as there files missing headers and a possible license issue. If the licenses of these files are clarified my vote can change. I checked: - incubating in name - signatures and hashes are fine - DISCLAIMER exists - LICENSE may be OK, except this file? [3] - NOTICE is fine - No unexpected binary files - A couple of files are missing ASF headers A couple of files are missing ASF headers, where did they come from and how are these licensed? [1][2] Is this file actually an ASF file or is it a 3rd party file? [3] If it a 3rd party file how is it licensed? Kind Regards, Justin 1. /core/pkg/scheduler/mock_plugin_test.go 2. /k8shim/test/e2e/predicates/predicates_test.go 3. /web/src/polyfills.ts - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0
HI, Sorry but it -1 binding form me. LICENSE is missing 3rd I checked: - incubating in name - DISCLAIMER exists - LICENSE is missing some licenses - NOTICE is OK - No unexpected binary files - source files have ASF headers This file [1] has an incorrect header and may be from another project. Where sis this code come from? This file [2] may incorrectly have an ASF header and contains 3rd party code not mentioned in LICENSE. Looks like there may be other 3rd party code (from the same project) in other files as well? Kind Regards, Justin 1. ./apache-shenyu-incubating-2.4.0-src/shenyu-admin/src/test/java/org/apache/shenyu/admin/utils/ThreadLocalUtilTest.java 2. ./apache-shenyu-incubating-2.4.0-src/shenyu-admin/src/main/resources/static/index.6e738f45.css - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0
+1 (non-binding) from me, I checked the following items: 1. LICENSE and NOTICE files exist 2. All links abovementioned are valid 3. Signature and checksum are good 4. Successfully built the image on my Fedora32. Best regards Chao Zhang https://github.com/tokers On Thu, Jul 29, 2021 at 4:04 PM Julia Kinga Marton wrote: > > Hello IPMC > > The Apache YuniKorn community has voted and approved the release Apache > YuniKorn (incubating) 0.11.0. We now kindly request the IPMC members review > and vote for this release. > > YuniKorn is a standalone, universal resource scheduler that can support > both long-running and batch workloads. The current release provides some > gang-scheduling improvements, REST API extensions,UI usability enhancements > etc. > > YuniKorn community vote > thread:https://lists.apache.org/thread.html/r0037975be6fa14069f83a724aa3f8e4d3e9654e374228768ba22aceb%40%3Cdev.yunikorn.apache.org%3E > > Vote result > thread:https://lists.apache.org/thread.html/r568f7d7ae4520faec90443b2c7d6b54e05ab7faf2042a30a2858e23d%40%3Cdev.yunikorn.apache.org%3E > > Issues included in this > release:https://issues.apache.org/jira/projects/YUNIKORN/versions/12350025 > > The release > candidate:https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.11/ > > This release has been signed with a PGP available > here:https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS > > Git tag for the release: > - https://github.com/apache/incubator-yunikorn-core/tree/v0.11.0 > - https://github.com/apache/incubator-yunikorn-k8shim/tree/v0.11.0 > > -https://github.com/apache/incubator-yunikorn-scheduler-interface/tree/v0.11.0 > - https://github.com/apache/incubator-yunikorn-web/tree/v0.11.0 > > The vote will be open for at least 72 hours or until the necessary number > of votes is reached. > > Please vote accordingly: > [ ] +1 Approve the release of Apache YuniKorn (Incubating) 0.11.0 > [ ] +0 > [ ] -1 Do not approve (please specify the reason) > > Thanks, > Kinga Marton > Apache YuniKorn (Incubating) - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache YuniKorn (Incubating) 0.11.0
+1 (non-binding) from me, I have checked the following items: - Incubating in name - LICENSE and NOTICE is fine - All links are valid - No unexpected binary files - All ASF files have ASF headers - Build from scratch - Built images from the source - Ran all unit tests Best regards Xun Liu On Thu, Jul 29, 2021 at 4:03 PM Julia Kinga Marton wrote: > Hello IPMC > > The Apache YuniKorn community has voted and approved the release Apache > YuniKorn (incubating) 0.11.0. We now kindly request the IPMC members review > and vote for this release. > > YuniKorn is a standalone, universal resource scheduler that can support > both long-running and batch workloads. The current release provides some > gang-scheduling improvements, REST API extensions,UI usability > enhancements etc. > > YuniKorn community vote > thread: > https://lists.apache.org/thread.html/r0037975be6fa14069f83a724aa3f8e4d3e9654e374228768ba22aceb%40%3Cdev.yunikorn.apache.org%3E > > Vote result thread: > https://lists.apache.org/thread.html/r568f7d7ae4520faec90443b2c7d6b54e05ab7faf2042a30a2858e23d%40%3Cdev.yunikorn.apache.org%3E > > Issues included in this > release:https://issues.apache.org/jira/projects/YUNIKORN/versions/12350025 > > The release candidate: > https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.11/ > > This release has been signed with a PGP available > here:https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS > > Git tag for the release: > - https://github.com/apache/incubator-yunikorn-core/tree/v0.11.0 > - https://github.com/apache/incubator-yunikorn-k8shim/tree/v0.11.0 > - > https://github.com/apache/incubator-yunikorn-scheduler-interface/tree/v0.11.0 > - https://github.com/apache/incubator-yunikorn-web/tree/v0.11.0 > > The vote will be open for at least 72 hours or until the necessary number > of votes is reached. > > Please vote accordingly: > [ ] +1 Approve the release of Apache YuniKorn (Incubating) 0.11.0 > [ ] +0 > [ ] -1 Do not approve (please specify the reason) > > Thanks, > Kinga Marton > Apache YuniKorn (Incubating) >
Re: [VOTE] Release Apache ShenYu (incubating) 2.4.0
+1 (non-binding) from me, I have checked the following items: - Incubating in name - LICENSE and NOTICE is fine - DISCLAIMER exists - All links are valid - No unexpected binary files - All ASF files have ASF headers - Checksums and PGP signatures are valid. - No compiled archives bundled in source archive. Best regards Xun Liu On Thu, Jul 29, 2021 at 11:07 AM Zhang Yonglun wrote: > Hi Sheng, > > Thanks for pointing out this problem. > The escape character in the test class is not compatible with OpenJDK 11. > We plan to support JAVA 11 in the next release. > Please try to build with JAVA 8, and I'll update the release doc to specify > the JAVA version. > > > -- > > Zhang Yonglun > Apache ShenYu (Incubating) > Apache ShardingSphere > > > Sheng Wu 于2021年7月29日周四 上午8:50写道： > > > Hi > > > > I can't find the compiling doc in the mail, but when I run compiling > using > > OpenJDK11, it fails > > ``` > > > > Expected: a string containing "Extension instance(name: > canNotInstantiated, > > class: class org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI) could > > not be instantiated: Class org.apache.shenyu.spi.ExtensionLoader can not > > access a member of class > > org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI with modifiers > > \"private\"" > > > > but: was "Extension instance(name: canNotInstantiated, class: class > > org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI) could not be > > instantiated: class org.apache.shenyu.spi.ExtensionLoader cannot access a > > member of class org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI with > > modifiers "private"" > > > > at > > > > > org.apache.shenyu.spi.ExtensionLoaderTest.testGetExtensionLoaderCanNotInstantiatedSPI(ExtensionLoaderTest.java:186) > > > > > > [INFO] Running org.apache.shenyu.spi.SpiExtensionFactoryTest > > > > [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > > 0.003 s - in org.apache.shenyu.spi.SpiExtensionFactoryTest > > > > [INFO] > > > > [INFO] Results: > > > > [INFO] > > > > [ERROR] Failures: > > > > [ERROR] > > ExtensionLoaderTest.testGetExtensionLoaderCanNotInstantiatedSPI:186 > > > > Expected: a string containing "Extension instance(name: > canNotInstantiated, > > class: class org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI) could > > not be instantiated: Class org.apache.shenyu.spi.ExtensionLoader can not > > access a member of class > > org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI with modifiers > > \"private\"" > > > > but: was "Extension instance(name: canNotInstantiated, class: class > > org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI) could not be > > instantiated: class org.apache.shenyu.spi.ExtensionLoader cannot access a > > member of class org.apache.shenyu.spi.fixture.CanNotInstantiatedSPI with > > modifiers "private"" > > > > [INFO] > > > > [ERROR] Tests run: 15, Failures: 1, Errors: 0, Skipped: 0 > > > > [INFO] > > ``` > > Sheng Wu 吴晟 > > Twitter, wusheng1108 > > > > > > Willem Jiang 于2021年7月29日周四 上午8:02写道： > > > > > +1 (binding) > > > Just forward my vote in the PPMC here. > > > There is incubating in the release kits' name. > > > The maven stage repo looks good. > > > No compiled archives bundled in source archive > > > The LICENSE and NOTICE files are OK for me. > > > There is a DISCLAIMER file in the release kits. > > > I can build the kit from source release with "mvn clean install" > > > > > > > > > > > > Willem Jiang > > > > > > Twitter: willemjiang > > > Weibo: 姜宁willem > > > > > > On Tue, Jul 27, 2021 at 10:57 AM Zhang Yonglun < > zhangyong...@apache.org> > > > wrote: > > > > > > > > Hello Incubator Community, > > > > > > > > This is a call for vote to release Apache ShenYu (incubating) version > > > 2.4.0. > > > > > > > > The Apache ShenYu community has voted on and approved a proposal to > > > release > > > > Apache ShenYu (incubating) version 2.4.0. > > > > > > > > We now kindly request the Incubator PMC members review and vote on > this > > > > incubator release. > > > > > > > > ShenYu community vote thread: > > > > > > > > > > https://lists.apache.org/thread.html/r8164d5840fda82b2d8bce5a7075ea874d247f2c0abf9203821a13cbb%40%3Cdev.shenyu.apache.org%3E > > > > > > > > Vote result thread: > > > > > > > > > > https://lists.apache.org/thread.html/re7b26cf370707cdb54a5404e317167fde643d3669e9783e335bf3b5e%40%3Cdev.shenyu.apache.org%3E > > > > > > > > Release notes: > > > > > > https://github.com/apache/incubator-shenyu/blob/master/RELEASE-NOTES.md > > > > > > > > The release candidates: > > > > https://dist.apache.org/repos/dist/dev/incubator/shenyu/2.4.0/ > > > > > > > > Maven 2 staging repository: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheshenyu-1012/org/apache/shenyu/ > > > > > > > > Git tag for the release: > > > > https://github.com/apache/incubator-shenyu/tree/v2.4.0/ > > > > > > > > Release Commit ID: > > > > > > > > > > https://github.com/apache/incubator-shenyu/commit/c75a273a8a9118411ed367e743b574e7fe0a5a87 >
[VOTE] Release Apache YuniKorn (Incubating) 0.11.0
Hello IPMC The Apache YuniKorn community has voted and approved the release Apache YuniKorn (incubating) 0.11.0. We now kindly request the IPMC members review and vote for this release. YuniKorn is a standalone, universal resource scheduler that can support both long-running and batch workloads. The current release provides some gang-scheduling improvements, REST API extensions,UI usability enhancements etc. YuniKorn community vote thread:https://lists.apache.org/thread.html/r0037975be6fa14069f83a724aa3f8e4d3e9654e374228768ba22aceb%40%3Cdev.yunikorn.apache.org%3E Vote result thread:https://lists.apache.org/thread.html/r568f7d7ae4520faec90443b2c7d6b54e05ab7faf2042a30a2858e23d%40%3Cdev.yunikorn.apache.org%3E Issues included in this release:https://issues.apache.org/jira/projects/YUNIKORN/versions/12350025 The release candidate:https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.11/ This release has been signed with a PGP available here:https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS Git tag for the release: - https://github.com/apache/incubator-yunikorn-core/tree/v0.11.0 - https://github.com/apache/incubator-yunikorn-k8shim/tree/v0.11.0 -https://github.com/apache/incubator-yunikorn-scheduler-interface/tree/v0.11.0 - https://github.com/apache/incubator-yunikorn-web/tree/v0.11.0 The vote will be open for at least 72 hours or until the necessary number of votes is reached. Please vote accordingly: [ ] +1 Approve the release of Apache YuniKorn (Incubating) 0.11.0 [ ] +0 [ ] -1 Do not approve (please specify the reason) Thanks, Kinga Marton Apache YuniKorn (Incubating)
