Re: [VOTE] Release 1.1.0-incubating-RC2
I will retract my -1. I need not speak for the others in this thread. If the other IPMC member found and looked at RC2 then by all means proceed. I had guessed that confirming this fact was equivalent to a replacement vote. If not, great! Kenn On Wed, Aug 21, 2019 at 8:31 PM leerho wrote: > RE: VERIFY VOTE > > Folks, > > My apologies, there was an error in the Vote Letter whereby the top of the > letter clearly requests a vote on RC2, but down below, the link to the > Release Candidate and the GitHub Tag were actually pointing to RC1. > Everything else appears to be correct. > > Please verify that it was RC2 that you examined and voted on. > > Thank you! > > Lee. > > > > On Wed, Aug 21, 2019 at 8:09 PM Justin Mclean > wrote: > > > Hi, > > > > > &^%$%^& You are right. That is a terrible copy/paste error on my > part. > > > However, the top of the vote letter clearly calls out RC2. Are you > > > changing your vote to -1? If so I will correct the vote letter and we > > will > > > have to start over. > > > > I think it’s clear enough that it was RC2 that was being released and > that > > what I looked at. Perhaps just confirm that any other IPMC votes were > also > > on RC2? > > > > Thanks, > > Justin > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
Re: [VOTE] Release 1.1.0-incubating-RC2
RE: VERIFY VOTE Folks, My apologies, there was an error in the Vote Letter whereby the top of the letter clearly requests a vote on RC2, but down below, the link to the Release Candidate and the GitHub Tag were actually pointing to RC1. Everything else appears to be correct. Please verify that it was RC2 that you examined and voted on. Thank you! Lee. On Wed, Aug 21, 2019 at 8:09 PM Justin Mclean wrote: > Hi, > > > &^%$%^& You are right. That is a terrible copy/paste error on my part. > > However, the top of the vote letter clearly calls out RC2. Are you > > changing your vote to -1? If so I will correct the vote letter and we > will > > have to start over. > > I think it’s clear enough that it was RC2 that was being released and that > what I looked at. Perhaps just confirm that any other IPMC votes were also > on RC2? > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release 1.1.0-incubating-RC2
Hi, > &^%$%^& You are right. That is a terrible copy/paste error on my part. > However, the top of the vote letter clearly calls out RC2. Are you > changing your vote to -1? If so I will correct the vote letter and we will > have to start over. I think it’s clear enough that it was RC2 that was being released and that what I looked at. Perhaps just confirm that any other IPMC votes were also on RC2? Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release 1.1.0-incubating-RC2
&^%$%^& You are right. That is a terrible copy/paste error on my part. However, the top of the vote letter clearly calls out RC2. Are you changing your vote to -1? If so I will correct the vote letter and we will have to start over. On Wed, Aug 21, 2019 at 7:08 PM Kenneth Knowles wrote: > -1 because I did in fact download RC1. I had not noticed, but your call for > this vote on general@ links to RC1 artifacts. So the archive of this > thread > will be confusing if some votes were cast after verifying RC1 while others > are corrected. > > Kenn > > On Wed, Aug 21, 2019 at 5:20 PM leerho wrote: > > > Just a guess, did you happen to download RC1 by mistake? > > > > Lee. > > > > On Wed, Aug 21, 2019 at 5:09 PM leerho wrote: > > > > > Kenn, > > > > > > I am puzzled by > > > > > > I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is > looking > > >> for a .git directory. > > > > > > > > > The git-commit-id plugin is in a separate "nexus-jars" profile which > must > > > be called from the command line. > > > it is specifically placed in the separate profile so that it will not > be > > > called from the main Maven build lifecycle. > > > > > > If you are running just "mvn test" or even "mvn install" that plugin > > > should not be called. > > > > > > I don't have that problem. > > > > > > Lee. > > > > > > > > > > > > On Wed, Aug 21, 2019 at 11:57 AM Kenneth Knowles > > wrote: > > > > > >> +1 > > >> > > >> Triple-checked: LICENSE, DISCLAIMER, license headers, mvn test > > >> > > >> I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is > > looking > > >> for a .git directory. > > >> > > >> On Tue, Aug 20, 2019 at 9:04 PM Justin Mclean < > jus...@classsoftware.com > > > > > >> wrote: > > >> > > >> > Hi, > > >> > > > >> > +1 (binding) > > >> > > > >> > I checked: > > >> > - incubating in name > > >> > - signatures and hashes fine > > >> > - DISCLAIMER exists and uses the WIP text. you also might want to > fill > > >> in > > >> > #Podling-Name# > > >> > - LICENSE is OK. Do you know what is missing? > > >> > - NOTICE is fine > > >> > - NO binary files in release > > >> > - All source files have ASF header > > >> > - Can compile from source > > >> > > > >> > There’s some very minor issues: > > >> > - I assume that some of the files may have an incorrect header? > > >> > [1][2][3][4][6][7][8]. 3rd party headers should probably not be > > replaced > > >> > with ASF ones [9] unless they have been extensively modified. This > > shod > > >> be > > >> > mentioned in the DISCLAIMER. > > >> > - In LICENSE there is probably no need to mention the java files > that > > >> use > > >> > the Gettysburg address. > > >> > - "lee...@users.noreply.github.com” is probably not the best email > to > > >> > sign the release with, please use an apache one in future. > > >> > - It’s nicer if the source unzips into a directory > > >> > > > >> > Thanks, > > >> > Justin > > >> > > > >> > 1. > src/main/java/org/apache/datasketches/memory/AccessByteBuffer.java > > >> > 2. src/main/java/org/apache/datasketches/memory/XxHash64.java > > >> > 3. src/test/java/org/apache/datasketches/memory/XxHash64Test.java > > >> > 4. > > src/test/java/org/apache/datasketches/memory/XxHash64LoopingTest.java > > >> > 5. src/main/java/org/apache/datasketches/memory/Utf8.java > > >> > 6. src/test/java/org/apache/datasketches/memory/Utf8Test.java > > >> > 7 > > src/test/java/org/apache/datasketches/memory/IsValidUtf8TestUtil.java > > >> > 8 src/main/java/org/apache/datasketches/memory/XxHash64.java > > >> > 9 https://www.apache.org/legal/src-headers.html#3party > > >> > > - > > >> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > >> > For additional commands, e-mail: general-h...@incubator.apache.org > > >> > > > >> > > > >> > > > > > >
Re: [VOTE] Release 1.1.0-incubating-RC2
-1 because I did in fact download RC1. I had not noticed, but your call for this vote on general@ links to RC1 artifacts. So the archive of this thread will be confusing if some votes were cast after verifying RC1 while others are corrected. Kenn On Wed, Aug 21, 2019 at 5:20 PM leerho wrote: > Just a guess, did you happen to download RC1 by mistake? > > Lee. > > On Wed, Aug 21, 2019 at 5:09 PM leerho wrote: > > > Kenn, > > > > I am puzzled by > > > > I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is looking > >> for a .git directory. > > > > > > The git-commit-id plugin is in a separate "nexus-jars" profile which must > > be called from the command line. > > it is specifically placed in the separate profile so that it will not be > > called from the main Maven build lifecycle. > > > > If you are running just "mvn test" or even "mvn install" that plugin > > should not be called. > > > > I don't have that problem. > > > > Lee. > > > > > > > > On Wed, Aug 21, 2019 at 11:57 AM Kenneth Knowles > wrote: > > > >> +1 > >> > >> Triple-checked: LICENSE, DISCLAIMER, license headers, mvn test > >> > >> I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is > looking > >> for a .git directory. > >> > >> On Tue, Aug 20, 2019 at 9:04 PM Justin Mclean > > >> wrote: > >> > >> > Hi, > >> > > >> > +1 (binding) > >> > > >> > I checked: > >> > - incubating in name > >> > - signatures and hashes fine > >> > - DISCLAIMER exists and uses the WIP text. you also might want to fill > >> in > >> > #Podling-Name# > >> > - LICENSE is OK. Do you know what is missing? > >> > - NOTICE is fine > >> > - NO binary files in release > >> > - All source files have ASF header > >> > - Can compile from source > >> > > >> > There’s some very minor issues: > >> > - I assume that some of the files may have an incorrect header? > >> > [1][2][3][4][6][7][8]. 3rd party headers should probably not be > replaced > >> > with ASF ones [9] unless they have been extensively modified. This > shod > >> be > >> > mentioned in the DISCLAIMER. > >> > - In LICENSE there is probably no need to mention the java files that > >> use > >> > the Gettysburg address. > >> > - "lee...@users.noreply.github.com” is probably not the best email to > >> > sign the release with, please use an apache one in future. > >> > - It’s nicer if the source unzips into a directory > >> > > >> > Thanks, > >> > Justin > >> > > >> > 1. src/main/java/org/apache/datasketches/memory/AccessByteBuffer.java > >> > 2. src/main/java/org/apache/datasketches/memory/XxHash64.java > >> > 3. src/test/java/org/apache/datasketches/memory/XxHash64Test.java > >> > 4. > src/test/java/org/apache/datasketches/memory/XxHash64LoopingTest.java > >> > 5. src/main/java/org/apache/datasketches/memory/Utf8.java > >> > 6. src/test/java/org/apache/datasketches/memory/Utf8Test.java > >> > 7 > src/test/java/org/apache/datasketches/memory/IsValidUtf8TestUtil.java > >> > 8 src/main/java/org/apache/datasketches/memory/XxHash64.java > >> > 9 https://www.apache.org/legal/src-headers.html#3party > >> > - > >> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >> > For additional commands, e-mail: general-h...@incubator.apache.org > >> > > >> > > >> > > >
Re: [VOTE] Release 1.1.0-incubating-RC2
Hi, > Of all of these, perhaps #4, #6, #7 (perhaps #5) could have the source > license header at the top. Even so, that would be incredibly conservative > and generous. IMO Unless changes are significant I’d leave the original header in there. Up to the PPMC what they think the definition of significant is, you might want to discuss that, but typically teh bar is high. For instance changing code form one language to another is usually not considered enough to change the header. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release 1.1.0-incubating-RC2
Just a guess, did you happen to download RC1 by mistake? Lee. On Wed, Aug 21, 2019 at 5:09 PM leerho wrote: > Kenn, > > I am puzzled by > > I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is looking >> for a .git directory. > > > The git-commit-id plugin is in a separate "nexus-jars" profile which must > be called from the command line. > it is specifically placed in the separate profile so that it will not be > called from the main Maven build lifecycle. > > If you are running just "mvn test" or even "mvn install" that plugin > should not be called. > > I don't have that problem. > > Lee. > > > > On Wed, Aug 21, 2019 at 11:57 AM Kenneth Knowles wrote: > >> +1 >> >> Triple-checked: LICENSE, DISCLAIMER, license headers, mvn test >> >> I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is looking >> for a .git directory. >> >> On Tue, Aug 20, 2019 at 9:04 PM Justin Mclean >> wrote: >> >> > Hi, >> > >> > +1 (binding) >> > >> > I checked: >> > - incubating in name >> > - signatures and hashes fine >> > - DISCLAIMER exists and uses the WIP text. you also might want to fill >> in >> > #Podling-Name# >> > - LICENSE is OK. Do you know what is missing? >> > - NOTICE is fine >> > - NO binary files in release >> > - All source files have ASF header >> > - Can compile from source >> > >> > There’s some very minor issues: >> > - I assume that some of the files may have an incorrect header? >> > [1][2][3][4][6][7][8]. 3rd party headers should probably not be replaced >> > with ASF ones [9] unless they have been extensively modified. This shod >> be >> > mentioned in the DISCLAIMER. >> > - In LICENSE there is probably no need to mention the java files that >> use >> > the Gettysburg address. >> > - "lee...@users.noreply.github.com” is probably not the best email to >> > sign the release with, please use an apache one in future. >> > - It’s nicer if the source unzips into a directory >> > >> > Thanks, >> > Justin >> > >> > 1. src/main/java/org/apache/datasketches/memory/AccessByteBuffer.java >> > 2. src/main/java/org/apache/datasketches/memory/XxHash64.java >> > 3. src/test/java/org/apache/datasketches/memory/XxHash64Test.java >> > 4. src/test/java/org/apache/datasketches/memory/XxHash64LoopingTest.java >> > 5. src/main/java/org/apache/datasketches/memory/Utf8.java >> > 6. src/test/java/org/apache/datasketches/memory/Utf8Test.java >> > 7 src/test/java/org/apache/datasketches/memory/IsValidUtf8TestUtil.java >> > 8 src/main/java/org/apache/datasketches/memory/XxHash64.java >> > 9 https://www.apache.org/legal/src-headers.html#3party >> > - >> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> > For additional commands, e-mail: general-h...@incubator.apache.org >> > >> > >> >
Re: [VOTE] Release 1.1.0-incubating-RC2
Kenn, I am puzzled by I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is looking > for a .git directory. The git-commit-id plugin is in a separate "nexus-jars" profile which must be called from the command line. it is specifically placed in the separate profile so that it will not be called from the main Maven build lifecycle. If you are running just "mvn test" or even "mvn install" that plugin should not be called. I don't have that problem. Lee. On Wed, Aug 21, 2019 at 11:57 AM Kenneth Knowles wrote: > +1 > > Triple-checked: LICENSE, DISCLAIMER, license headers, mvn test > > I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is looking > for a .git directory. > > On Tue, Aug 20, 2019 at 9:04 PM Justin Mclean > wrote: > > > Hi, > > > > +1 (binding) > > > > I checked: > > - incubating in name > > - signatures and hashes fine > > - DISCLAIMER exists and uses the WIP text. you also might want to fill in > > #Podling-Name# > > - LICENSE is OK. Do you know what is missing? > > - NOTICE is fine > > - NO binary files in release > > - All source files have ASF header > > - Can compile from source > > > > There’s some very minor issues: > > - I assume that some of the files may have an incorrect header? > > [1][2][3][4][6][7][8]. 3rd party headers should probably not be replaced > > with ASF ones [9] unless they have been extensively modified. This shod > be > > mentioned in the DISCLAIMER. > > - In LICENSE there is probably no need to mention the java files that use > > the Gettysburg address. > > - "lee...@users.noreply.github.com” is probably not the best email to > > sign the release with, please use an apache one in future. > > - It’s nicer if the source unzips into a directory > > > > Thanks, > > Justin > > > > 1. src/main/java/org/apache/datasketches/memory/AccessByteBuffer.java > > 2. src/main/java/org/apache/datasketches/memory/XxHash64.java > > 3. src/test/java/org/apache/datasketches/memory/XxHash64Test.java > > 4. src/test/java/org/apache/datasketches/memory/XxHash64LoopingTest.java > > 5. src/main/java/org/apache/datasketches/memory/Utf8.java > > 6. src/test/java/org/apache/datasketches/memory/Utf8Test.java > > 7 src/test/java/org/apache/datasketches/memory/IsValidUtf8TestUtil.java > > 8 src/main/java/org/apache/datasketches/memory/XxHash64.java > > 9 https://www.apache.org/legal/src-headers.html#3party > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
Re: [VOTE] Release 1.1.0-incubating-RC2
Justin, Thank you for your detailed response! This is very helpful. I will address each one of your license issues: 1. src/main/java/org/apache/datasketches/memory/AccessByteBuffer.java There is only one method (6 lines long) in this entire file that was "adapted" from the the original source file and is properly attributed in the Javadoc for the method and referenced in the LICENSE file. Even this method is modified quite a bit from the original. Putting their license header at the top of the file would be disregarding our original code in the rest of the file. My recommendation is to leave it as it is. But if you have a suggestion as to how this should be handled better, please let me know. 2. src/main/java/org/apache/datasketches/memory/XxHash64.java About half of the original was copied (in form) and extensively modified. Considerable functionality was removed and replaced with completely new functionality. The source is attributed at the top of the file and in the LICENSE file. Because of the extensive modifications, and the presence of our original code, putting their license header at the top of the file would be disregarding our original code in the rest of the file. My recommendation is to leave it as it is. But please advise. 3. src/test/java/org/apache/datasketches/memory/XxHash64Test.java Only one method in this file (~15 lines) is adapted from the original source and every one of the lines had to be modified to suit our environment. The source is attributed at the top of the file and in the LICENSE file. Because of the extensive modifications, and the presence of our original code, putting their license header at the top of the file would be disregarding our original code in the rest of the file. My recommendation is to leave it as it is. But please advise. 4. src/test/java/org/apache/datasketches/memory/XxHash64LoopingTest.java This file contains one method (~7 lines), which is heavily adapted from the original source, and about 1000 static data values that are used in a bit-for-bit compatibility test to make sure our implementation of this hash function produces the exact same hashes bit-for-bit! Even so, this file is not an exact copy of the original. The source is attributed at the top of the file and in the LICENSE file. Perhaps it could be argued that because the majority of this file contains a copy of their test data, Their copyright header should be used. Even that would disregard the modifications we did make. My recommendation is to leave it as it is. But please advise. 5. src/main/java/org/apache/datasketches/memory/Utf8.java This file adapts portions of the original with extensive modifications. Method names are changed, looping methods are different, etc. Some of the same code comments are copied over, but additional code comments were added. Again, bit-for-bit compatibility is critical. The source is attributed at the top of the file and in the LICENSE file. My recommendation is to leave it as it is. But please advise. 6. src/test/java/org/apache/datasketches/memory/Utf8Test.java This file adapts portions of the original with modifications. Some of the same code comments are copied over, but additional code comments were added. It could be argued that the original license header could be placed at the top. The source is attributed at the top of the file and in the LICENSE file. My recommendation is to leave it as it is. But please advise. 7 src/test/java/org/apache/datasketches/memory/IsValidUtf8TestUtil.java This is a vastly stripped down version of the original. It could be argued that the original license header could be placed at the top. The source is attributed at the top of the file and in the LICENSE file. My recommendation is to leave it as it is. But please advise. 8 src/main/java/org/apache/datasketches/memory/XxHash64.java Duplicate of #2. Of all of these, perhaps #4, #6, #7 (perhaps #5) could have the source license header at the top. Even so, that would be incredibly conservative and generous. Lee. On Tue, Aug 20, 2019 at 9:04 PM Justin Mclean wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes fine > - DISCLAIMER exists and uses the WIP text. you also might want to fill in > #Podling-Name# > - LICENSE is OK. Do you know what is missing? > - NOTICE is fine > - NO binary files in release > - All source files have ASF header > - Can compile from source > > There’s some very minor issues: > - I assume that some of the files may have an incorrect header? > [1][2][3][4][6][7][8]. 3rd party headers should probably not be replaced > with ASF ones [9] unless they have been extensively modified. This shod be > mentioned in the DISCLAIMER. > - In LICENSE there is probably no need to mention the java files that use > the Gettysburg address. > - "lee...@users.noreply.github.com” is probably not the best email to > sign the release with, please use an apache one in future. > - It’s
Re: [VOTE] Release 1.1.0-incubating-RC2
+1 Triple-checked: LICENSE, DISCLAIMER, license headers, mvn test I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is looking for a .git directory. On Tue, Aug 20, 2019 at 9:04 PM Justin Mclean wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes fine > - DISCLAIMER exists and uses the WIP text. you also might want to fill in > #Podling-Name# > - LICENSE is OK. Do you know what is missing? > - NOTICE is fine > - NO binary files in release > - All source files have ASF header > - Can compile from source > > There’s some very minor issues: > - I assume that some of the files may have an incorrect header? > [1][2][3][4][6][7][8]. 3rd party headers should probably not be replaced > with ASF ones [9] unless they have been extensively modified. This shod be > mentioned in the DISCLAIMER. > - In LICENSE there is probably no need to mention the java files that use > the Gettysburg address. > - "lee...@users.noreply.github.com” is probably not the best email to > sign the release with, please use an apache one in future. > - It’s nicer if the source unzips into a directory > > Thanks, > Justin > > 1. src/main/java/org/apache/datasketches/memory/AccessByteBuffer.java > 2. src/main/java/org/apache/datasketches/memory/XxHash64.java > 3. src/test/java/org/apache/datasketches/memory/XxHash64Test.java > 4. src/test/java/org/apache/datasketches/memory/XxHash64LoopingTest.java > 5. src/main/java/org/apache/datasketches/memory/Utf8.java > 6. src/test/java/org/apache/datasketches/memory/Utf8Test.java > 7 src/test/java/org/apache/datasketches/memory/IsValidUtf8TestUtil.java > 8 src/main/java/org/apache/datasketches/memory/XxHash64.java > 9 https://www.apache.org/legal/src-headers.html#3party > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release 1.1.0-incubating-RC2
Hi, +1 (binding) I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists and uses the WIP text. you also might want to fill in #Podling-Name# - LICENSE is OK. Do you know what is missing? - NOTICE is fine - NO binary files in release - All source files have ASF header - Can compile from source There’s some very minor issues: - I assume that some of the files may have an incorrect header? [1][2][3][4][6][7][8]. 3rd party headers should probably not be replaced with ASF ones [9] unless they have been extensively modified. This shod be mentioned in the DISCLAIMER. - In LICENSE there is probably no need to mention the java files that use the Gettysburg address. - "lee...@users.noreply.github.com” is probably not the best email to sign the release with, please use an apache one in future. - It’s nicer if the source unzips into a directory Thanks, Justin 1. src/main/java/org/apache/datasketches/memory/AccessByteBuffer.java 2. src/main/java/org/apache/datasketches/memory/XxHash64.java 3. src/test/java/org/apache/datasketches/memory/XxHash64Test.java 4. src/test/java/org/apache/datasketches/memory/XxHash64LoopingTest.java 5. src/main/java/org/apache/datasketches/memory/Utf8.java 6. src/test/java/org/apache/datasketches/memory/Utf8Test.java 7 src/test/java/org/apache/datasketches/memory/IsValidUtf8TestUtil.java 8 src/main/java/org/apache/datasketches/memory/XxHash64.java 9 https://www.apache.org/legal/src-headers.html#3party - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release 1.1.0-incubating-RC2
+1 - code compiles - incubating in name - LICENSE, NOTICE is fine - No unexpected binary files Thanks, William On Tue, Aug 20, 2019 at 10:30 PM Roman Leventov wrote: > +1 > > On Tue, 20 Aug 2019 at 17:05, Furkan KAMACI > wrote: > > > Hi, > > > > +1 from me. > > > > I checked: > > > > - Incubating in name > > - LICENSE is fine > > - NOTICE is fine > > - No unexpected binary files > > - Code compiles and tests successfully run > > > > One objection: DISCLAIMER file should be renamed to DISCLAIMER-WIP and > link > > at content should point to datasketches. > > > > Kind Regards, > > Furkan KAMACI > > > > On Mon, Aug 19, 2019 at 11:46 PM leerho wrote: > > > > > Hello Apache DataSketches IPMC and Community, > > > > > > 1. This is a call for vote to release Apache DataSketches-memory > version: > > > 1.1.0-incubating-RC2 > > > > > > NOTE 1: This is one component of the DataSketches library that provides > > > high-performance access > > > to off-heap memory for Java applications. These are low-level functions > > > that are used by other > > > DataSketches components. It does not provide any command-line interface > > or > > > GUI. > > > > > > NOTE 2: This release contains some critical performance improvements > for > > > Apache Druid. > > > > > > NOTE 3: This particular component has been split out from the rest of > the > > > DataSketches > > > code because there have been a number of requests from platform > projects > > > that are interested in > > > these high-performance functions independently of the remainder of the > > > DataSketches library. > > > > > > NOTE 4: This RC2 fixes some problems in the structure of the POM file > of > > > RC1. There are no other changes. > > > > > > A. Results from the PPMC vote (open for 140 hours (including the > > > weekend)) > > > > > > - 3 votes were cast. All of the votes were (+1). Two of the votes > > were > > > from Mentors. > > > > > > - The vote thread can be found at: > > > > > > https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser > > > > > > > > > B. Testing/actions/votes performed by the voters: > > > > > > - Gian Merlino: (+1) > > > - .asc and .sha512 look good. > > > - git.properties looks good. > > > - Ran "mvn package" without issue. > > > - Source tarball contents match the tag. > > > > > > Gian made several suggestions for improvements for next > release: > > > - have the zip unpack in its own directory not the current > > > directory > > > - DISCLAMER > > > - should be renamed DISCLAMER-WIP > > > - links to > > > http://incubator.apache.org/project/#Podling-Name#.html, but it should > > be > > > https://incubator.apache.org/projects/datasketches.html. > > > (fill in project name, > > > 'projects' instead of 'project', http would work but > https > > > is nicer.) > > > - Vote procedure: > > > - Clarify sentence to require not just 3 (+1) votes, but a > > > majority of (+1s) vs (-1s). > > > - When cancelling a vote use subject [CANCEL][VOTE] ... > > > > > > - Liang Chen (+1 binding) > > > - no comments > > > > > > - Furkan Kamaci (+1 binding) > > > - Incubating in name > > > - LICENSE is fine > > > - NOTICE is fine > > > - No unexpected binary files > > > - Code compiles and tests successfully run > > > - One objection: DISCLAIMER file should be renamed to > > DISCLAIMER-WIP > > > and link > > > at content should point to datasketches. > > > > > > 2. The release candidate: > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.1.0-incubating-RC1/apache-datasketches-memory-1.1.0-incubating-src.zip > > > > > > 3. Source repository: > > > https://github.com/apache/incubator-datasketches-memory > > > > > > Git Tag for this release: > > > > > > > > > https://github.com/apache/incubator-datasketches-memory/tree/1.1.0-incubating-RC1 > > > on branch 1.1.X-incubating > > > > > > Git HashId for this release starts with: 32de195 > > > > > > The artifacts have been signed with --keyid-format SHORT : 8CD4A902 > > > > > > 4. Repository: dist.apache.org repository: > > > > > > The public signing key can be found in the KEYS file: > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS > > > > > > 5. Repository: Maven Central (repository.apache.org): > > > > > > The Jar artifacts can be found at > > > > > > > > > https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-memory/1.1.0-incubating/ > > > > > > 6. Build & Test Guide: > > > > > > The DataSketches-memory component is pure Java and is structured as a > > > Maven project. You must compile using JDK 8. > > > There is one run-time dependency for logging and, of course, a number > of > > > test and Maven plugin dependencies, > > > all of which can be resolved by Maven. > > > > > >
Re: [VOTE] Release 1.1.0-incubating-RC2
+1 On Tue, 20 Aug 2019 at 17:05, Furkan KAMACI wrote: > Hi, > > +1 from me. > > I checked: > > - Incubating in name > - LICENSE is fine > - NOTICE is fine > - No unexpected binary files > - Code compiles and tests successfully run > > One objection: DISCLAIMER file should be renamed to DISCLAIMER-WIP and link > at content should point to datasketches. > > Kind Regards, > Furkan KAMACI > > On Mon, Aug 19, 2019 at 11:46 PM leerho wrote: > > > Hello Apache DataSketches IPMC and Community, > > > > 1. This is a call for vote to release Apache DataSketches-memory version: > > 1.1.0-incubating-RC2 > > > > NOTE 1: This is one component of the DataSketches library that provides > > high-performance access > > to off-heap memory for Java applications. These are low-level functions > > that are used by other > > DataSketches components. It does not provide any command-line interface > or > > GUI. > > > > NOTE 2: This release contains some critical performance improvements for > > Apache Druid. > > > > NOTE 3: This particular component has been split out from the rest of the > > DataSketches > > code because there have been a number of requests from platform projects > > that are interested in > > these high-performance functions independently of the remainder of the > > DataSketches library. > > > > NOTE 4: This RC2 fixes some problems in the structure of the POM file of > > RC1. There are no other changes. > > > > A. Results from the PPMC vote (open for 140 hours (including the > > weekend)) > > > > - 3 votes were cast. All of the votes were (+1). Two of the votes > were > > from Mentors. > > > > - The vote thread can be found at: > > > https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser > > > > > > B. Testing/actions/votes performed by the voters: > > > > - Gian Merlino: (+1) > > - .asc and .sha512 look good. > > - git.properties looks good. > > - Ran "mvn package" without issue. > > - Source tarball contents match the tag. > > > > Gian made several suggestions for improvements for next release: > > - have the zip unpack in its own directory not the current > > directory > > - DISCLAMER > > - should be renamed DISCLAMER-WIP > > - links to > > http://incubator.apache.org/project/#Podling-Name#.html, but it should > be > > https://incubator.apache.org/projects/datasketches.html. > > (fill in project name, > > 'projects' instead of 'project', http would work but https > > is nicer.) > > - Vote procedure: > > - Clarify sentence to require not just 3 (+1) votes, but a > > majority of (+1s) vs (-1s). > > - When cancelling a vote use subject [CANCEL][VOTE] ... > > > > - Liang Chen (+1 binding) > > - no comments > > > > - Furkan Kamaci (+1 binding) > > - Incubating in name > > - LICENSE is fine > > - NOTICE is fine > > - No unexpected binary files > > - Code compiles and tests successfully run > > - One objection: DISCLAIMER file should be renamed to > DISCLAIMER-WIP > > and link > > at content should point to datasketches. > > > > 2. The release candidate: > > > > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.1.0-incubating-RC1/apache-datasketches-memory-1.1.0-incubating-src.zip > > > > 3. Source repository: > > https://github.com/apache/incubator-datasketches-memory > > > > Git Tag for this release: > > > > > https://github.com/apache/incubator-datasketches-memory/tree/1.1.0-incubating-RC1 > > on branch 1.1.X-incubating > > > > Git HashId for this release starts with: 32de195 > > > > The artifacts have been signed with --keyid-format SHORT : 8CD4A902 > > > > 4. Repository: dist.apache.org repository: > > > > The public signing key can be found in the KEYS file: > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS > > > > 5. Repository: Maven Central (repository.apache.org): > > > > The Jar artifacts can be found at > > > > > https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-memory/1.1.0-incubating/ > > > > 6. Build & Test Guide: > > > > The DataSketches-memory component is pure Java and is structured as a > > Maven project. You must compile using JDK 8. > > There is one run-time dependency for logging and, of course, a number of > > test and Maven plugin dependencies, > > all of which can be resolved by Maven. > > > > There are two types of tests: normal unit tests and tests run by the > > strict profile. To run normal unit tests: > > > > $ mvn clean test > > > > To run the strict profile tests: > > > > $ mvn clean test -P strict > > > > To install jars in your local .m2 repository: > > > > $ mvn clean install > > > > 7. Documentation: The documentation for the DataSketches Memory component > > is part of the website. > > > > Overview documentation: > > -
Re: [VOTE] Release 1.1.0-incubating-RC2
Hi, +1 from me. I checked: - Incubating in name - LICENSE is fine - NOTICE is fine - No unexpected binary files - Code compiles and tests successfully run One objection: DISCLAIMER file should be renamed to DISCLAIMER-WIP and link at content should point to datasketches. Kind Regards, Furkan KAMACI On Mon, Aug 19, 2019 at 11:46 PM leerho wrote: > Hello Apache DataSketches IPMC and Community, > > 1. This is a call for vote to release Apache DataSketches-memory version: > 1.1.0-incubating-RC2 > > NOTE 1: This is one component of the DataSketches library that provides > high-performance access > to off-heap memory for Java applications. These are low-level functions > that are used by other > DataSketches components. It does not provide any command-line interface or > GUI. > > NOTE 2: This release contains some critical performance improvements for > Apache Druid. > > NOTE 3: This particular component has been split out from the rest of the > DataSketches > code because there have been a number of requests from platform projects > that are interested in > these high-performance functions independently of the remainder of the > DataSketches library. > > NOTE 4: This RC2 fixes some problems in the structure of the POM file of > RC1. There are no other changes. > > A. Results from the PPMC vote (open for 140 hours (including the > weekend)) > > - 3 votes were cast. All of the votes were (+1). Two of the votes were > from Mentors. > > - The vote thread can be found at: > https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser > > > B. Testing/actions/votes performed by the voters: > > - Gian Merlino: (+1) > - .asc and .sha512 look good. > - git.properties looks good. > - Ran "mvn package" without issue. > - Source tarball contents match the tag. > > Gian made several suggestions for improvements for next release: > - have the zip unpack in its own directory not the current > directory > - DISCLAMER > - should be renamed DISCLAMER-WIP > - links to > http://incubator.apache.org/project/#Podling-Name#.html, but it should be > https://incubator.apache.org/projects/datasketches.html. > (fill in project name, > 'projects' instead of 'project', http would work but https > is nicer.) > - Vote procedure: > - Clarify sentence to require not just 3 (+1) votes, but a > majority of (+1s) vs (-1s). > - When cancelling a vote use subject [CANCEL][VOTE] ... > > - Liang Chen (+1 binding) > - no comments > > - Furkan Kamaci (+1 binding) > - Incubating in name > - LICENSE is fine > - NOTICE is fine > - No unexpected binary files > - Code compiles and tests successfully run > - One objection: DISCLAIMER file should be renamed to DISCLAIMER-WIP > and link > at content should point to datasketches. > > 2. The release candidate: > > https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.1.0-incubating-RC1/apache-datasketches-memory-1.1.0-incubating-src.zip > > 3. Source repository: > https://github.com/apache/incubator-datasketches-memory > > Git Tag for this release: > > https://github.com/apache/incubator-datasketches-memory/tree/1.1.0-incubating-RC1 > on branch 1.1.X-incubating > > Git HashId for this release starts with: 32de195 > > The artifacts have been signed with --keyid-format SHORT : 8CD4A902 > > 4. Repository: dist.apache.org repository: > > The public signing key can be found in the KEYS file: > https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS > > 5. Repository: Maven Central (repository.apache.org): > > The Jar artifacts can be found at > > https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-memory/1.1.0-incubating/ > > 6. Build & Test Guide: > > The DataSketches-memory component is pure Java and is structured as a > Maven project. You must compile using JDK 8. > There is one run-time dependency for logging and, of course, a number of > test and Maven plugin dependencies, > all of which can be resolved by Maven. > > There are two types of tests: normal unit tests and tests run by the > strict profile. To run normal unit tests: > > $ mvn clean test > > To run the strict profile tests: > > $ mvn clean test -P strict > > To install jars in your local .m2 repository: > > $ mvn clean install > > 7. Documentation: The documentation for the DataSketches Memory component > is part of the website. > > Overview documentation: > - https://datasketches.github.io/docs/Memory/MemoryPackage.html > - https://datasketches.github.io/docs/Memory/MemoryPerformance.html > > Javadocs: > - https://datasketches.github.io/api/memory/snapshot/apidocs/index.html > > 8. This vote is the 2nd stage vote: >- This voting process will remain open for at least 72 hours > and until at least 3 (+1) IPMC votes or a
[VOTE] Release 1.1.0-incubating-RC2
Hello Apache DataSketches IPMC and Community, 1. This is a call for vote to release Apache DataSketches-memory version: 1.1.0-incubating-RC2 NOTE 1: This is one component of the DataSketches library that provides high-performance access to off-heap memory for Java applications. These are low-level functions that are used by other DataSketches components. It does not provide any command-line interface or GUI. NOTE 2: This release contains some critical performance improvements for Apache Druid. NOTE 3: This particular component has been split out from the rest of the DataSketches code because there have been a number of requests from platform projects that are interested in these high-performance functions independently of the remainder of the DataSketches library. NOTE 4: This RC2 fixes some problems in the structure of the POM file of RC1. There are no other changes. A. Results from the PPMC vote (open for 140 hours (including the weekend)) - 3 votes were cast. All of the votes were (+1). Two of the votes were from Mentors. - The vote thread can be found at: https://mail-archives.apache.org/mod_mbox/datasketches-dev/201907.mbox/browser B. Testing/actions/votes performed by the voters: - Gian Merlino: (+1) - .asc and .sha512 look good. - git.properties looks good. - Ran "mvn package" without issue. - Source tarball contents match the tag. Gian made several suggestions for improvements for next release: - have the zip unpack in its own directory not the current directory - DISCLAMER - should be renamed DISCLAMER-WIP - links to http://incubator.apache.org/project/#Podling-Name#.html, but it should be https://incubator.apache.org/projects/datasketches.html. (fill in project name, 'projects' instead of 'project', http would work but https is nicer.) - Vote procedure: - Clarify sentence to require not just 3 (+1) votes, but a majority of (+1s) vs (-1s). - When cancelling a vote use subject [CANCEL][VOTE] ... - Liang Chen (+1 binding) - no comments - Furkan Kamaci (+1 binding) - Incubating in name - LICENSE is fine - NOTICE is fine - No unexpected binary files - Code compiles and tests successfully run - One objection: DISCLAIMER file should be renamed to DISCLAIMER-WIP and link at content should point to datasketches. 2. The release candidate: https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.1.0-incubating-RC1/apache-datasketches-memory-1.1.0-incubating-src.zip 3. Source repository: https://github.com/apache/incubator-datasketches-memory Git Tag for this release: https://github.com/apache/incubator-datasketches-memory/tree/1.1.0-incubating-RC1 on branch 1.1.X-incubating Git HashId for this release starts with: 32de195 The artifacts have been signed with --keyid-format SHORT : 8CD4A902 4. Repository: dist.apache.org repository: The public signing key can be found in the KEYS file: https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS 5. Repository: Maven Central (repository.apache.org): The Jar artifacts can be found at https://repository.apache.org/content/groups/staging/org/apache/datasketches/datasketches-memory/1.1.0-incubating/ 6. Build & Test Guide: The DataSketches-memory component is pure Java and is structured as a Maven project. You must compile using JDK 8. There is one run-time dependency for logging and, of course, a number of test and Maven plugin dependencies, all of which can be resolved by Maven. There are two types of tests: normal unit tests and tests run by the strict profile. To run normal unit tests: $ mvn clean test To run the strict profile tests: $ mvn clean test -P strict To install jars in your local .m2 repository: $ mvn clean install 7. Documentation: The documentation for the DataSketches Memory component is part of the website. Overview documentation: - https://datasketches.github.io/docs/Memory/MemoryPackage.html - https://datasketches.github.io/docs/Memory/MemoryPerformance.html Javadocs: - https://datasketches.github.io/api/memory/snapshot/apidocs/index.html 8. This vote is the 2nd stage vote: - This voting process will remain open for at least 72 hours and until at least 3 (+1) IPMC votes or a majority of (+1) are acquired. Please vote accordingly: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the reason Thanks, Lee Rhodes lee...@apache.org
