Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
> Thanks for the explanation. But if the user want to change the theme he > still need to download the theme file himself, even he download the src > distribution. Am I right? Yes. Not only the theme, there are more issues if considering the user convenience, including but not limited to the map file usage, importing echarts in Node.js environment, directly importing prebuilt products, visiting the examples. Some of them are included in the artifacts of the previous release candidate. But I think most of the resource and files generated for convenience issues are probably beyond the scope of the "source release", as the strict definition discussed in the thread of the voting for rc3. So in the formal source release we only provide pure source code, and convenience issues are tried to be covered by the project website and Github repo. -- Su Shuang (100pah) -- 2018-06-02 7:21 GMT+08:00 Willem Jiang : > Thanks for the explanation. But if the user want to change the theme he > still need to download the theme file himself, even he download the src > distribution. Am I right? > I think we need to provide more convenience distribution in next release. > > Here is my +1 vote. > > BTW, if you want to keep using https://www.echartsjs.com/ you can > redirect > the site to https://echarts.incubator.apache.org. > In this way the user can still access the website with old domain name. > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Thu, May 31, 2018 at 12:15 PM, Yi Shen wrote: > > > My vote is +1 binding. > > > > But when I check the source file with github repo[1]. I found there are > > > some directories are missed. > > > I guess we can skip the benchmark, tests, but I'm not sure for the > theme > > > directory. Can you explain it? > > > We need to make sure we can build the full function binary from the > > source > > > release. > > > BTW, it looks there lots of github links in the README.md[2] need to be > > > updated. > > > And echarts need to move the website to echarts.incubator.apache.org > > from > > > baidu. > > > > > > Willem, thanks for pointing out the issues. Wenli Zhang has made a > request > > for the apache website server. We will move the English website to > > echarts.incubator.apache.org after that. Not sure if it's ok but we > prefer > > the Chinese website keep the url https://www.echartsjs.com/ , which is > > used > > currently > > > > The theme folder will not be included when building the distribution. It' > > more like resources which can be used externally, like geojson data in > the > > map folder on the GitHub. > > > > Willem Jiang 于2018年5月31日周四 上午10:19写道： > > > > > Hi > > > > > > I just tried to build the source according to the instruction in the > > mail, > > > it works. > > > But when I check the source file with github repo[1]. I found there are > > > some directories are missed. > > > I guess we can skip the benchmark, tests, but I'm not sure for the > theme > > > directory. Can you explain it? > > > We need to make sure we can build the full function binary from the > > source > > > release. > > > > > > BTW, it looks there lots of github links in the README.md[2] need to be > > > updated. > > > And echarts need to move the website to echarts.incubator.apache.org > > from > > > baidu. > > > > > > > > > [1] https://github.com/apache/incubator-echarts > > > [2]https://github.com/apache/incubator-echarts/blob/master/README.md > > > > > > > > > Willem Jiang > > > > > > Twitter: willemjiang > > > Weibo: 姜宁willem > > > > > > On Tue, May 29, 2018 at 5:09 PM, SHUANG SU > > wrote: > > > > > > > After removing some generated files and bin files from 4.1.0.rc3, > only > > > > source code kept in the artifact. > > > > I am pleased to be calling this vote for the release of Apache > ECharts > > > > 4.1.0.rc4. > > > > > > > > > > > > Apache ECharts community has voted and approved the release. > > > > > > > > Vote thread: > > > > https://lists.apache.org/thread.html/8ebfdd7219cbfed40cd2350e487b99 > > > > be58ec169fb7c5673e21e10dea@%3Cdev.echarts.apache.org%3E > > > > > > > > Results thread: > > > > https://lists.apache.org/thread.html/238ae37a82e2a71698f41a4d878e32 > > > > 5601b88c665f9951d3bf912db4@%3Cdev.echarts.apache.org%3E > > > > > > > > The release candidate to be voted over is available at: > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc4/ > > > > > > > > The release candidate is signed with a GPG key available at: > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > > > > > The Git commit for this release is: > > > > https://gitbox.apache.org/repos/asf?p=incubator-echarts. > > > > git;a=commit;h=02842e2 > > > > > > > > The Release Note is available in: > > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > > > 1.0.rc4/RELEASE_NOTE.txt > > > > > > > > Some shell commands for validating the release: > > > > > > > > ```shell > > > >
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Thanks for the explanation. But if the user want to change the theme he still need to download the theme file himself, even he download the src distribution. Am I right? I think we need to provide more convenience distribution in next release. Here is my +1 vote. BTW, if you want to keep using https://www.echartsjs.com/ you can redirect the site to https://echarts.incubator.apache.org. In this way the user can still access the website with old domain name. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Thu, May 31, 2018 at 12:15 PM, Yi Shen wrote: > My vote is +1 binding. > > But when I check the source file with github repo[1]. I found there are > > some directories are missed. > > I guess we can skip the benchmark, tests, but I'm not sure for the theme > > directory. Can you explain it? > > We need to make sure we can build the full function binary from the > source > > release. > > BTW, it looks there lots of github links in the README.md[2] need to be > > updated. > > And echarts need to move the website to echarts.incubator.apache.org > from > > baidu. > > > Willem, thanks for pointing out the issues. Wenli Zhang has made a request > for the apache website server. We will move the English website to > echarts.incubator.apache.org after that. Not sure if it's ok but we prefer > the Chinese website keep the url https://www.echartsjs.com/ , which is > used > currently > > The theme folder will not be included when building the distribution. It' > more like resources which can be used externally, like geojson data in the > map folder on the GitHub. > > Willem Jiang 于2018年5月31日周四 上午10:19写道： > > > Hi > > > > I just tried to build the source according to the instruction in the > mail, > > it works. > > But when I check the source file with github repo[1]. I found there are > > some directories are missed. > > I guess we can skip the benchmark, tests, but I'm not sure for the theme > > directory. Can you explain it? > > We need to make sure we can build the full function binary from the > source > > release. > > > > BTW, it looks there lots of github links in the README.md[2] need to be > > updated. > > And echarts need to move the website to echarts.incubator.apache.org > from > > baidu. > > > > > > [1] https://github.com/apache/incubator-echarts > > [2]https://github.com/apache/incubator-echarts/blob/master/README.md > > > > > > Willem Jiang > > > > Twitter: willemjiang > > Weibo: 姜宁willem > > > > On Tue, May 29, 2018 at 5:09 PM, SHUANG SU > wrote: > > > > > After removing some generated files and bin files from 4.1.0.rc3, only > > > source code kept in the artifact. > > > I am pleased to be calling this vote for the release of Apache ECharts > > > 4.1.0.rc4. > > > > > > > > > Apache ECharts community has voted and approved the release. > > > > > > Vote thread: > > > https://lists.apache.org/thread.html/8ebfdd7219cbfed40cd2350e487b99 > > > be58ec169fb7c5673e21e10dea@%3Cdev.echarts.apache.org%3E > > > > > > Results thread: > > > https://lists.apache.org/thread.html/238ae37a82e2a71698f41a4d878e32 > > > 5601b88c665f9951d3bf912db4@%3Cdev.echarts.apache.org%3E > > > > > > The release candidate to be voted over is available at: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc4/ > > > > > > The release candidate is signed with a GPG key available at: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > > > The Git commit for this release is: > > > https://gitbox.apache.org/repos/asf?p=incubator-echarts. > > > git;a=commit;h=02842e2 > > > > > > The Release Note is available in: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > > 1.0.rc4/RELEASE_NOTE.txt > > > > > > Some shell commands for validating the release: > > > > > > ```shell > > > # Download the release: > > > curl > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > > 1.0.rc4/apache-echarts-4.1.0.rc4-incubating-src.zip > > > -o apache-echarts-4.1.0.rc4-incubating-src.zip > > > unzip apache-echarts-4.1.0.rc4-incubating-src.zip -d > > > apache-echarts-4.1.0.rc4-incubating-src > /dev/null > > > > > > # Rebuild the project (Node.js environment is required): > > > cd "apache-echarts-4.1.0.rc4-incubating-src" && npm install && cd .. > > > node "apache-echarts-4.1.0.rc4-incubating-src/build/build.js" > --release > > > # (See help: `node "apache-echarts-4.1.0.rc4- > > > incubating-src/build/build.js" > > > --help`) > > > ``` > > > > > > > > > Please vote on releasing this package as: > > > Apache ECharts 4.1.0.rc4 > > > > > > This vote will be open until "2018-06-01T10:02:35.437Z". > > > > > > [ ] +1 Release this package > > > [ ] 0 I don't feel strongly about it, but don't object > > > [ ] -1 Do not release this package because... > > > > > > Anyone can participate in testing and voting, not just committers, > please > > > feel free to try out the release candidate and provide your votes. > > > > > > -- > > > Su Shuang (100pah) > > >
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Hi - For this first release I am switching to VOTE +1 since as Justin writes this is a documentation issue Cn permissive licenses. However, it needs to be clearly explained so that users of ECharts can clearly understand all of the implications of using it. The ECharts podling and mentors (Justin, Dave and Kevin) will need to research the best way to document how to license these derivative versions of D3. We should do so on the dev@echarts mailing list and the legal affairs committee’s JIRA. [1] Regards, Dave [1] https://issues.apache.org/jira/projects/LEGAL/summary > On Jun 1, 2018, at 1:50 AM, SHUANG SU wrote: > > -- > Su Shuang (100pah) > -- > > > 2018-06-01 1:07 GMT+08:00 Dave Fisher : > >> Hi - >> >> I’m VOTING +0. >> >> (1) I am rather confused by this D3 license. For example: >> >> src/chart/tree/layoutHelper.js >> /* >> * Licensed to the Apache Software Foundation (ASF) under one >> * or more contributor license agreements. See the NOTICE file >> * distributed with this work for additional information >> * regarding copyright ownership. The ASF licenses this file >> * to you under the Apache License, Version 2.0 (the >> * "License"); you may not use this file except in compliance >> * with the License. You may obtain a copy of the License at >> * >> * http://www.apache.org/licenses/LICENSE-2.0 >> * >> * Unless required by applicable law or agreed to in writing, >> * software distributed under the License is distributed on an >> * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> * KIND, either express or implied. See the License for the >> * specific language governing permissions and limitations >> * under the License. >> */ >> >> /* >> * The tree layout implementation references to d3.js >> * (https://github.com/d3/d3-hierarchy). The use of the source >> * code of this file is also subject to the terms and consitions >> * of its license (BSD-3Clause, see ). >> */ >> >> /** >> * @file The layout algorithm of node-link tree diagrams. Here we using >> Reingold-Tilford algorithm to drawing >> * the tree. >> * @see https://github.com/d3/d3-hierarchy >> */ >> >> import * as layout from '../../util/layout'; >> ... >> >> Without deep analysis I have no idea what parts are D3. If this whole file >> is based on D3 then in my opinion this whole source file needs to be BSD-3 >> clause licensed. >> >> I would change my VOTE to +1 if there is a good explanation. >> >> > > Hi Dave, > > Most of the logic in `src/chart/tree/layoutHelper.js` is based on > https://github.com/d3/d3-hierarchy/blob/44ba491e8c6d5b8af21280f6507d4d > 372bc4272d/src/tree.js > > But, basically the file is a collection of layout utils for the tree > component, in which some other logic > not relative to d3 also exists, and may be added more in futher. So I think > it is still a file that under the > Apache license as other files of this project, and including some code with > d3 BSD license embeded. > > > Thanks. signature.asc Description: Message signed with OpenPGP
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
-- Su Shuang (100pah) -- 2018-06-01 1:07 GMT+08:00 Dave Fisher : > Hi - > > I’m VOTING +0. > > (1) I am rather confused by this D3 license. For example: > > src/chart/tree/layoutHelper.js > /* > * Licensed to the Apache Software Foundation (ASF) under one > * or more contributor license agreements. See the NOTICE file > * distributed with this work for additional information > * regarding copyright ownership. The ASF licenses this file > * to you under the Apache License, Version 2.0 (the > * "License"); you may not use this file except in compliance > * with the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, > * software distributed under the License is distributed on an > * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > * KIND, either express or implied. See the License for the > * specific language governing permissions and limitations > * under the License. > */ > > /* > * The tree layout implementation references to d3.js > * (https://github.com/d3/d3-hierarchy). The use of the source > * code of this file is also subject to the terms and consitions > * of its license (BSD-3Clause, see ). > */ > > /** > * @file The layout algorithm of node-link tree diagrams. Here we using > Reingold-Tilford algorithm to drawing > * the tree. > * @see https://github.com/d3/d3-hierarchy > */ > > import * as layout from '../../util/layout'; > ... > > Without deep analysis I have no idea what parts are D3. If this whole file > is based on D3 then in my opinion this whole source file needs to be BSD-3 > clause licensed. > > I would change my VOTE to +1 if there is a good explanation. > > Hi Dave, Most of the logic in `src/chart/tree/layoutHelper.js` is based on https://github.com/d3/d3-hierarchy/blob/44ba491e8c6d5b8af21280f6507d4d 372bc4272d/src/tree.js But, basically the file is a collection of layout utils for the tree component, in which some other logic not relative to d3 also exists, and may be added more in futher. So I think it is still a file that under the Apache license as other files of this project, and including some code with d3 BSD license embeded. Thanks.
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
> > The whole file is based on the tree layout of D3 Sorry about missing the reference. https://github.com/d3/d3-hierarchy/blob/44ba491e8c6d5b8af21280f6507d4d372bc4272d/src/tree.js Yi Shen 于2018年6月1日周五 下午3:40写道： > Hi Dave: > > Without deep analysis I have no idea what parts are D3. If this whole file >> is based on D3 then in my opinion this whole source file needs to be BSD-3 >> clause licensed. >> >> I would change my VOTE to +1 if there is a good explanation. >> > > The whole file is based on the tree layout of D3. But we modified the code > a lot so the layout algorithm can be integrated into our architecture. > > Dave Fisher 于2018年6月1日周五 上午1:07写道： > >> Hi - >> >> I’m VOTING +0. >> >> (1) I am rather confused by this D3 license. For example: >> >> src/chart/tree/layoutHelper.js >> /* >> * Licensed to the Apache Software Foundation (ASF) under one >> * or more contributor license agreements. See the NOTICE file >> * distributed with this work for additional information >> * regarding copyright ownership. The ASF licenses this file >> * to you under the Apache License, Version 2.0 (the >> * "License"); you may not use this file except in compliance >> * with the License. You may obtain a copy of the License at >> * >> * http://www.apache.org/licenses/LICENSE-2.0 >> * >> * Unless required by applicable law or agreed to in writing, >> * software distributed under the License is distributed on an >> * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> * KIND, either express or implied. See the License for the >> * specific language governing permissions and limitations >> * under the License. >> */ >> >> /* >> * The tree layout implementation references to d3.js >> * (https://github.com/d3/d3-hierarchy). The use of the source >> * code of this file is also subject to the terms and consitions >> * of its license (BSD-3Clause, see ). >> */ >> >> /** >> * @file The layout algorithm of node-link tree diagrams. Here we using >> Reingold-Tilford algorithm to drawing >> * the tree. >> * @see https://github.com/d3/d3-hierarchy >> */ >> >> import * as layout from '../../util/layout'; >> ... >> >> Without deep analysis I have no idea what parts are D3. If this whole >> file is based on D3 then in my opinion this whole source file needs to be >> BSD-3 clause licensed. >> >> I would change my VOTE to +1 if there is a good explanation. >> >> (2) I think that licenses/LICENSE-zrender is covered by the SGA. If this >> is correct then this file needs to be removed. >> >> (3) KEYS should not be included in the release package. >> >> (4) RELEASE-NOTE.txt should be part of the release package. >> >> Regards, >> Dave >> >> On May 30, 2018, at 11:28 PM, Justin Mclean >> wrote: >> >> Hi, >> >> sankeyLayout.js is mainly an improved implementation of the original d3 >> sankey layout algorithm. We will add sankeyLayout.js to the list of files >> embed [d3.js](https://github.com/d3/d3) BSD 3-Clause in the LICENSE if >> needed. >> >> >> Seems like it should be to me. Any modification of code are in general >> under the license of the original unless they are extensive. All licenses >> of any bundled software need to be mentioned in LICENSE. >> >> And in the HeatmapLayer.js, we were inspired by the idea of simpleheat. >> But >> the implementation and code are different. In this case, should we still >> add the LICENSE of simpleheat? >> >> >> IMO (but IANAL) “inspired by” means to me that they have copied at least >> some of it. If at some future time the license isn’t actually needed in >> LICENSE that’s OK as it just a documentation issue, but if it was required >> and not included that would be a licensing error. If that doesn’t convince >> you may be best to ask on legal discuss for an answer. >> >> (But either way it still only a minor issue as all the licenses are >> permissive and my +1 still stands.) >> >> Thanks, >> Justin >> - >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> >> > > -- > Yi Shen > Senior Developer > Baidu, Inc. > -- Yi Shen Senior Developer Baidu, Inc.
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Hi Dave: Without deep analysis I have no idea what parts are D3. If this whole file > is based on D3 then in my opinion this whole source file needs to be BSD-3 > clause licensed. > > I would change my VOTE to +1 if there is a good explanation. > The whole file is based on the tree layout of D3. But we modified the code a lot so the layout algorithm can be integrated into our architecture. Dave Fisher 于2018年6月1日周五 上午1:07写道： > Hi - > > I’m VOTING +0. > > (1) I am rather confused by this D3 license. For example: > > src/chart/tree/layoutHelper.js > /* > * Licensed to the Apache Software Foundation (ASF) under one > * or more contributor license agreements. See the NOTICE file > * distributed with this work for additional information > * regarding copyright ownership. The ASF licenses this file > * to you under the Apache License, Version 2.0 (the > * "License"); you may not use this file except in compliance > * with the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, > * software distributed under the License is distributed on an > * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > * KIND, either express or implied. See the License for the > * specific language governing permissions and limitations > * under the License. > */ > > /* > * The tree layout implementation references to d3.js > * (https://github.com/d3/d3-hierarchy). The use of the source > * code of this file is also subject to the terms and consitions > * of its license (BSD-3Clause, see ). > */ > > /** > * @file The layout algorithm of node-link tree diagrams. Here we using > Reingold-Tilford algorithm to drawing > * the tree. > * @see https://github.com/d3/d3-hierarchy > */ > > import * as layout from '../../util/layout'; > ... > > Without deep analysis I have no idea what parts are D3. If this whole file > is based on D3 then in my opinion this whole source file needs to be BSD-3 > clause licensed. > > I would change my VOTE to +1 if there is a good explanation. > > (2) I think that licenses/LICENSE-zrender is covered by the SGA. If this > is correct then this file needs to be removed. > > (3) KEYS should not be included in the release package. > > (4) RELEASE-NOTE.txt should be part of the release package. > > Regards, > Dave > > On May 30, 2018, at 11:28 PM, Justin Mclean > wrote: > > Hi, > > sankeyLayout.js is mainly an improved implementation of the original d3 > sankey layout algorithm. We will add sankeyLayout.js to the list of files > embed [d3.js](https://github.com/d3/d3) BSD 3-Clause in the LICENSE if > needed. > > > Seems like it should be to me. Any modification of code are in general > under the license of the original unless they are extensive. All licenses > of any bundled software need to be mentioned in LICENSE. > > And in the HeatmapLayer.js, we were inspired by the idea of simpleheat. But > the implementation and code are different. In this case, should we still > add the LICENSE of simpleheat? > > > IMO (but IANAL) “inspired by” means to me that they have copied at least > some of it. If at some future time the license isn’t actually needed in > LICENSE that’s OK as it just a documentation issue, but if it was required > and not included that would be a licensing error. If that doesn’t convince > you may be best to ask on legal discuss for an answer. > > (But either way it still only a minor issue as all the licenses are > permissive and my +1 still stands.) > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > > -- Yi Shen Senior Developer Baidu, Inc.
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Hi - I’m VOTING +0. (1) I am rather confused by this D3 license. For example: src/chart/tree/layoutHelper.js /* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. */ /* * The tree layout implementation references to d3.js * (https://github.com/d3/d3-hierarchy). The use of the source * code of this file is also subject to the terms and consitions * of its license (BSD-3Clause, see ). */ /** * @file The layout algorithm of node-link tree diagrams. Here we using Reingold-Tilford algorithm to drawing * the tree. * @see https://github.com/d3/d3-hierarchy */ import * as layout from '../../util/layout'; ... Without deep analysis I have no idea what parts are D3. If this whole file is based on D3 then in my opinion this whole source file needs to be BSD-3 clause licensed. I would change my VOTE to +1 if there is a good explanation. (2) I think that licenses/LICENSE-zrender is covered by the SGA. If this is correct then this file needs to be removed. (3) KEYS should not be included in the release package. (4) RELEASE-NOTE.txt should be part of the release package. Regards, Dave > On May 30, 2018, at 11:28 PM, Justin Mclean wrote: > > Hi, > >> sankeyLayout.js is mainly an improved implementation of the original d3 >> sankey layout algorithm. We will add sankeyLayout.js to the list of files >> embed [d3.js](https://github.com/d3/d3) BSD 3-Clause in the LICENSE if >> needed. > > Seems like it should be to me. Any modification of code are in general under > the license of the original unless they are extensive. All licenses of any > bundled software need to be mentioned in LICENSE. > >> And in the HeatmapLayer.js, we were inspired by the idea of simpleheat. But >> the implementation and code are different. In this case, should we still >> add the LICENSE of simpleheat? > > IMO (but IANAL) “inspired by” means to me that they have copied at least some > of it. If at some future time the license isn’t actually needed in LICENSE > that’s OK as it just a documentation issue, but if it was required and not > included that would be a licensing error. If that doesn’t convince you may > be best to ask on legal discuss for an answer. > > (But either way it still only a minor issue as all the licenses are > permissive and my +1 still stands.) > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > signature.asc Description: Message signed with OpenPGP
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Hi, > sankeyLayout.js is mainly an improved implementation of the original d3 > sankey layout algorithm. We will add sankeyLayout.js to the list of files > embed [d3.js](https://github.com/d3/d3) BSD 3-Clause in the LICENSE if > needed. Seems like it should be to me. Any modification of code are in general under the license of the original unless they are extensive. All licenses of any bundled software need to be mentioned in LICENSE. > And in the HeatmapLayer.js, we were inspired by the idea of simpleheat. But > the implementation and code are different. In this case, should we still > add the LICENSE of simpleheat? IMO (but IANAL) “inspired by” means to me that they have copied at least some of it. If at some future time the license isn’t actually needed in LICENSE that’s OK as it just a documentation issue, but if it was required and not included that would be a licensing error. If that doesn’t convince you may be best to ask on legal discuss for an answer. (But either way it still only a minor issue as all the licenses are permissive and my +1 still stands.) Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Thanks Justin! > LICENSE is probably missing: > - MIT licensed sankey layout [1] in [2][3] > - 2 clause BSD Heatmap layer [4] in [5] I will try to explain these two concerns about LICENSE. sankeyLayout.js is mainly an improved implementation of the original d3 sankey layout algorithm. We will add sankeyLayout.js to the list of files embed [d3.js](https://github.com/d3/d3) BSD 3-Clause in the LICENSE if needed. And in the HeatmapLayer.js, we were inspired by the idea of simpleheat. But the implementation and code are different. In this case, should we still add the LICENSE of simpleheat? Justin Mclean 于2018年5月31日周四 上午9:04写道： > Hi, > > +1 binding > > I checked: > - incubating in name > - signatures and hashes good > - DISCLAIMER exists > - LICENSE is probably missing a few things (see below) > - NOTICE is good > - No binary files in release > - All source files have ASF headers > > LICENSE is probably missing: > - MIT licensed sankey layout [1] in [2][3] > - 2 clause BSD Heatmap layer [4] in [5] > > Some other very minor things: > - no need for KEYS file in the release > - looks like package.json could do with an update re URL and authors > - missing README or like on how to “compile” / use > > Thanks, > Justin > > 1. https://github.com/ricklupton/sankey-layout > 2. src/chart/sankey/sankeyLayout.js > 3. src/chart/themeRiver/themeRiverLayout.js > 4. https://github.com/mourner/simpleheat > 5. src/chart/heatmap/HeatmapLayer.js > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Yi Shen Senior Developer Baidu, Inc.
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
My vote is +1 binding. But when I check the source file with github repo[1]. I found there are > some directories are missed. > I guess we can skip the benchmark, tests, but I'm not sure for the theme > directory. Can you explain it? > We need to make sure we can build the full function binary from the source > release. > BTW, it looks there lots of github links in the README.md[2] need to be > updated. > And echarts need to move the website to echarts.incubator.apache.org from > baidu. Willem, thanks for pointing out the issues. Wenli Zhang has made a request for the apache website server. We will move the English website to echarts.incubator.apache.org after that. Not sure if it's ok but we prefer the Chinese website keep the url https://www.echartsjs.com/ , which is used currently The theme folder will not be included when building the distribution. It' more like resources which can be used externally, like geojson data in the map folder on the GitHub. Willem Jiang 于2018年5月31日周四 上午10:19写道： > Hi > > I just tried to build the source according to the instruction in the mail, > it works. > But when I check the source file with github repo[1]. I found there are > some directories are missed. > I guess we can skip the benchmark, tests, but I'm not sure for the theme > directory. Can you explain it? > We need to make sure we can build the full function binary from the source > release. > > BTW, it looks there lots of github links in the README.md[2] need to be > updated. > And echarts need to move the website to echarts.incubator.apache.org from > baidu. > > > [1] https://github.com/apache/incubator-echarts > [2]https://github.com/apache/incubator-echarts/blob/master/README.md > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Tue, May 29, 2018 at 5:09 PM, SHUANG SU wrote: > > > After removing some generated files and bin files from 4.1.0.rc3, only > > source code kept in the artifact. > > I am pleased to be calling this vote for the release of Apache ECharts > > 4.1.0.rc4. > > > > > > Apache ECharts community has voted and approved the release. > > > > Vote thread: > > https://lists.apache.org/thread.html/8ebfdd7219cbfed40cd2350e487b99 > > be58ec169fb7c5673e21e10dea@%3Cdev.echarts.apache.org%3E > > > > Results thread: > > https://lists.apache.org/thread.html/238ae37a82e2a71698f41a4d878e32 > > 5601b88c665f9951d3bf912db4@%3Cdev.echarts.apache.org%3E > > > > The release candidate to be voted over is available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc4/ > > > > The release candidate is signed with a GPG key available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > The Git commit for this release is: > > https://gitbox.apache.org/repos/asf?p=incubator-echarts. > > git;a=commit;h=02842e2 > > > > The Release Note is available in: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > 1.0.rc4/RELEASE_NOTE.txt > > > > Some shell commands for validating the release: > > > > ```shell > > # Download the release: > > curl > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > 1.0.rc4/apache-echarts-4.1.0.rc4-incubating-src.zip > > -o apache-echarts-4.1.0.rc4-incubating-src.zip > > unzip apache-echarts-4.1.0.rc4-incubating-src.zip -d > > apache-echarts-4.1.0.rc4-incubating-src > /dev/null > > > > # Rebuild the project (Node.js environment is required): > > cd "apache-echarts-4.1.0.rc4-incubating-src" && npm install && cd .. > > node "apache-echarts-4.1.0.rc4-incubating-src/build/build.js" --release > > # (See help: `node "apache-echarts-4.1.0.rc4- > > incubating-src/build/build.js" > > --help`) > > ``` > > > > > > Please vote on releasing this package as: > > Apache ECharts 4.1.0.rc4 > > > > This vote will be open until "2018-06-01T10:02:35.437Z". > > > > [ ] +1 Release this package > > [ ] 0 I don't feel strongly about it, but don't object > > [ ] -1 Do not release this package because... > > > > Anyone can participate in testing and voting, not just committers, please > > feel free to try out the release candidate and provide your votes. > > > > -- > > Su Shuang (100pah) > > -- > > > -- Yi Shen Senior Developer Baidu, Inc.
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Hi I just tried to build the source according to the instruction in the mail, it works. But when I check the source file with github repo[1]. I found there are some directories are missed. I guess we can skip the benchmark, tests, but I'm not sure for the theme directory. Can you explain it? We need to make sure we can build the full function binary from the source release. BTW, it looks there lots of github links in the README.md[2] need to be updated. And echarts need to move the website to echarts.incubator.apache.org from baidu. [1] https://github.com/apache/incubator-echarts [2]https://github.com/apache/incubator-echarts/blob/master/README.md Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, May 29, 2018 at 5:09 PM, SHUANG SU wrote: > After removing some generated files and bin files from 4.1.0.rc3, only > source code kept in the artifact. > I am pleased to be calling this vote for the release of Apache ECharts > 4.1.0.rc4. > > > Apache ECharts community has voted and approved the release. > > Vote thread: > https://lists.apache.org/thread.html/8ebfdd7219cbfed40cd2350e487b99 > be58ec169fb7c5673e21e10dea@%3Cdev.echarts.apache.org%3E > > Results thread: > https://lists.apache.org/thread.html/238ae37a82e2a71698f41a4d878e32 > 5601b88c665f9951d3bf912db4@%3Cdev.echarts.apache.org%3E > > The release candidate to be voted over is available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc4/ > > The release candidate is signed with a GPG key available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > The Git commit for this release is: > https://gitbox.apache.org/repos/asf?p=incubator-echarts. > git;a=commit;h=02842e2 > > The Release Note is available in: > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > 1.0.rc4/RELEASE_NOTE.txt > > Some shell commands for validating the release: > > ```shell > # Download the release: > curl > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > 1.0.rc4/apache-echarts-4.1.0.rc4-incubating-src.zip > -o apache-echarts-4.1.0.rc4-incubating-src.zip > unzip apache-echarts-4.1.0.rc4-incubating-src.zip -d > apache-echarts-4.1.0.rc4-incubating-src > /dev/null > > # Rebuild the project (Node.js environment is required): > cd "apache-echarts-4.1.0.rc4-incubating-src" && npm install && cd .. > node "apache-echarts-4.1.0.rc4-incubating-src/build/build.js" --release > # (See help: `node "apache-echarts-4.1.0.rc4- > incubating-src/build/build.js" > --help`) > ``` > > > Please vote on releasing this package as: > Apache ECharts 4.1.0.rc4 > > This vote will be open until "2018-06-01T10:02:35.437Z". > > [ ] +1 Release this package > [ ] 0 I don't feel strongly about it, but don't object > [ ] -1 Do not release this package because... > > Anyone can participate in testing and voting, not just committers, please > feel free to try out the release candidate and provide your votes. > > -- > Su Shuang (100pah) > -- >
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Hi, +1 binding I checked: - incubating in name - signatures and hashes good - DISCLAIMER exists - LICENSE is probably missing a few things (see below) - NOTICE is good - No binary files in release - All source files have ASF headers LICENSE is probably missing: - MIT licensed sankey layout [1] in [2][3] - 2 clause BSD Heatmap layer [4] in [5] Some other very minor things: - no need for KEYS file in the release - looks like package.json could do with an update re URL and authors - missing README or like on how to “compile” / use Thanks, Justin 1. https://github.com/ricklupton/sankey-layout 2. src/chart/sankey/sankeyLayout.js 3. src/chart/themeRiver/themeRiverLayout.js 4. https://github.com/mourner/simpleheat 5. src/chart/heatmap/HeatmapLayer.js - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Ty. I am +1 binding on rc4 On Wed, May 30, 2018, 13:11 SHUANG SU wrote: > > When it is released, my point is that the rc4 is removed so some of ypur > > text says you are releasing 4.1.0rc4. I would have it say release 4.1.0 > > and here is release candidate 4. > > Yes, it is the vote for the release of 4.1.0, release candidate 4. I should > have made it clearly > in text. > > > That is the right process but you also need to cancel the previous vote. > > Thanks, I have canceled the previous vote just now. > > > > > -- > Su Shuang (100pah) > -- > > > 2018-05-30 19:47 GMT+08:00 Justin Mclean : > > > Hi, > > > > > Firstly, I called a vote for 4.1.0.rc3 on " > general@incubator.apache.org" > > , > > > and then received some comments. > > > Then, I fixed the artifact according to those comments, and called a > vote > > > for 4.1.0.rc4 on "d...@echarts.apache.org", > > > and then the vote passed. > > > Then, I am calling a vote for 4.1.0.rc4 on " > general@incubator.apache.org > > " > > > now. > > > > > > That is the right process but you also need to cancel the previous vote. > > > > Thanks, > > Justin > > > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
> When it is released, my point is that the rc4 is removed so some of ypur > text says you are releasing 4.1.0rc4. I would have it say release 4.1.0 > and here is release candidate 4. Yes, it is the vote for the release of 4.1.0, release candidate 4. I should have made it clearly in text. > That is the right process but you also need to cancel the previous vote. Thanks, I have canceled the previous vote just now. -- Su Shuang (100pah) -- 2018-05-30 19:47 GMT+08:00 Justin Mclean : > Hi, > > > Firstly, I called a vote for 4.1.0.rc3 on "general@incubator.apache.org" > , > > and then received some comments. > > Then, I fixed the artifact according to those comments, and called a vote > > for 4.1.0.rc4 on "d...@echarts.apache.org", > > and then the vote passed. > > Then, I am calling a vote for 4.1.0.rc4 on "general@incubator.apache.org > " > > now. > > > That is the right process but you also need to cancel the previous vote. > > Thanks, > Justin > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Hi, > Firstly, I called a vote for 4.1.0.rc3 on "general@incubator.apache.org", > and then received some comments. > Then, I fixed the artifact according to those comments, and called a vote > for 4.1.0.rc4 on "d...@echarts.apache.org", > and then the vote passed. > Then, I am calling a vote for 4.1.0.rc4 on "general@incubator.apache.org" > now. That is the right process but you also need to cancel the previous vote. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
You are likely correct. Just a lot of rcs and I thought you would have canceled some of the votes. You don't have to finish the votes if you know you aren't going to release it. And by an rc4 with a minor change like removing files, you could ask your group how they feel about the voting process. I certainly would say it makes sense as long as you have consensus. When it is released, my point is that the rc4 is removed so some of ypur text says you are releasing 4.1.0rc4. I would have it say release 4.1.0 and here is release candidate 4. In fact I like to write the release notice as the voting notice so the notice is effectively viewed at the same time as the vote for the release. Then when the vote passes it's a cut and paste to announce. KAM On Wed, May 30, 2018, 05:31 SHUANG SU wrote: > Kevin, > > Sorry, I am being confused with the voting progress: > > Firstly, I called a vote for 4.1.0.rc3 on "general@incubator.apache.org", > and then received some comments. > Then, I fixed the artifact according to those comments, and called a vote > for 4.1.0.rc4 on "d...@echarts.apache.org", > and then the vote passed. > Then, I am calling a vote for 4.1.0.rc4 on "general@incubator.apache.org" > now. > > Did I do it correctly? > Or, maybe, I should have skipped the vote for 4.1.0.rc4 on " > d...@echarts.apache.org", > but call a vote for 4.1.0.rc4 on "general@incubator.apache.org" directly > after I fixed the 4.1.0.rc3? > > > > > -- > Su Shuang (100pah) > -- > > > 2018-05-29 22:41 GMT+08:00 Kevin A. McGrail : > > > Su, I would think you would remove the rc4 (release candidate) and it > would > > be released as 4.1.0. Also, I think your vote already passed so I'm not > > sure why you need another round of votes. Am I confused? > > > > -- > > Kevin A. McGrail > > VP Fundraising, Apache Software Foundation > > Chair Emeritus Apache SpamAssassin Project > > https://www.linkedin.com/in/kmcgrail - 703.798.0171 > > > > On Tue, May 29, 2018 at 5:09 AM, SHUANG SU > wrote: > > > > > After removing some generated files and bin files from 4.1.0.rc3, only > > > source code kept in the artifact. > > > I am pleased to be calling this vote for the release of Apache ECharts > > > 4.1.0.rc4. > > > > > > > > > Apache ECharts community has voted and approved the release. > > > > > > Vote thread: > > > https://lists.apache.org/thread.html/8ebfdd7219cbfed40cd2350e487b99 > > > be58ec169fb7c5673e21e10dea@%3Cdev.echarts.apache.org%3E > > > > > > Results thread: > > > https://lists.apache.org/thread.html/238ae37a82e2a71698f41a4d878e32 > > > 5601b88c665f9951d3bf912db4@%3Cdev.echarts.apache.org%3E > > > > > > The release candidate to be voted over is available at: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc4/ > > > > > > The release candidate is signed with a GPG key available at: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > > > The Git commit for this release is: > > > https://gitbox.apache.org/repos/asf?p=incubator-echarts. > > > git;a=commit;h=02842e2 > > > > > > The Release Note is available in: > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > > 1.0.rc4/RELEASE_NOTE.txt > > > > > > Some shell commands for validating the release: > > > > > > ```shell > > > # Download the release: > > > curl > > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > > 1.0.rc4/apache-echarts-4.1.0.rc4-incubating-src.zip > > > -o apache-echarts-4.1.0.rc4-incubating-src.zip > > > unzip apache-echarts-4.1.0.rc4-incubating-src.zip -d > > > apache-echarts-4.1.0.rc4-incubating-src > /dev/null > > > > > > # Rebuild the project (Node.js environment is required): > > > cd "apache-echarts-4.1.0.rc4-incubating-src" && npm install && cd .. > > > node "apache-echarts-4.1.0.rc4-incubating-src/build/build.js" --release > > > # (See help: `node "apache-echarts-4.1.0.rc4- > > > incubating-src/build/build.js" > > > --help`) > > > ``` > > > > > > > > > Please vote on releasing this package as: > > > Apache ECharts 4.1.0.rc4 > > > > > > This vote will be open until "2018-06-01T10:02:35.437Z". > > > > > > [ ] +1 Release this package > > > [ ] 0 I don't feel strongly about it, but don't object > > > [ ] -1 Do not release this package because... > > > > > > Anyone can participate in testing and voting, not just committers, > please > > > feel free to try out the release candidate and provide your votes. > > > > > > -- > > > Su Shuang (100pah) > > > -- > > > > > >
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Kevin, Sorry, I am being confused with the voting progress: Firstly, I called a vote for 4.1.0.rc3 on "general@incubator.apache.org", and then received some comments. Then, I fixed the artifact according to those comments, and called a vote for 4.1.0.rc4 on "d...@echarts.apache.org", and then the vote passed. Then, I am calling a vote for 4.1.0.rc4 on "general@incubator.apache.org" now. Did I do it correctly? Or, maybe, I should have skipped the vote for 4.1.0.rc4 on " d...@echarts.apache.org", but call a vote for 4.1.0.rc4 on "general@incubator.apache.org" directly after I fixed the 4.1.0.rc3? -- Su Shuang (100pah) -- 2018-05-29 22:41 GMT+08:00 Kevin A. McGrail : > Su, I would think you would remove the rc4 (release candidate) and it would > be released as 4.1.0. Also, I think your vote already passed so I'm not > sure why you need another round of votes. Am I confused? > > -- > Kevin A. McGrail > VP Fundraising, Apache Software Foundation > Chair Emeritus Apache SpamAssassin Project > https://www.linkedin.com/in/kmcgrail - 703.798.0171 > > On Tue, May 29, 2018 at 5:09 AM, SHUANG SU wrote: > > > After removing some generated files and bin files from 4.1.0.rc3, only > > source code kept in the artifact. > > I am pleased to be calling this vote for the release of Apache ECharts > > 4.1.0.rc4. > > > > > > Apache ECharts community has voted and approved the release. > > > > Vote thread: > > https://lists.apache.org/thread.html/8ebfdd7219cbfed40cd2350e487b99 > > be58ec169fb7c5673e21e10dea@%3Cdev.echarts.apache.org%3E > > > > Results thread: > > https://lists.apache.org/thread.html/238ae37a82e2a71698f41a4d878e32 > > 5601b88c665f9951d3bf912db4@%3Cdev.echarts.apache.org%3E > > > > The release candidate to be voted over is available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc4/ > > > > The release candidate is signed with a GPG key available at: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > > > The Git commit for this release is: > > https://gitbox.apache.org/repos/asf?p=incubator-echarts. > > git;a=commit;h=02842e2 > > > > The Release Note is available in: > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > 1.0.rc4/RELEASE_NOTE.txt > > > > Some shell commands for validating the release: > > > > ```shell > > # Download the release: > > curl > > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > > 1.0.rc4/apache-echarts-4.1.0.rc4-incubating-src.zip > > -o apache-echarts-4.1.0.rc4-incubating-src.zip > > unzip apache-echarts-4.1.0.rc4-incubating-src.zip -d > > apache-echarts-4.1.0.rc4-incubating-src > /dev/null > > > > # Rebuild the project (Node.js environment is required): > > cd "apache-echarts-4.1.0.rc4-incubating-src" && npm install && cd .. > > node "apache-echarts-4.1.0.rc4-incubating-src/build/build.js" --release > > # (See help: `node "apache-echarts-4.1.0.rc4- > > incubating-src/build/build.js" > > --help`) > > ``` > > > > > > Please vote on releasing this package as: > > Apache ECharts 4.1.0.rc4 > > > > This vote will be open until "2018-06-01T10:02:35.437Z". > > > > [ ] +1 Release this package > > [ ] 0 I don't feel strongly about it, but don't object > > [ ] -1 Do not release this package because... > > > > Anyone can participate in testing and voting, not just committers, please > > feel free to try out the release candidate and provide your votes. > > > > -- > > Su Shuang (100pah) > > -- > > >
Re: [VOTE] Release Apache ECharts (incubating) 4.1.0.rc4
Su, I would think you would remove the rc4 (release candidate) and it would be released as 4.1.0. Also, I think your vote already passed so I'm not sure why you need another round of votes. Am I confused? -- Kevin A. McGrail VP Fundraising, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171 On Tue, May 29, 2018 at 5:09 AM, SHUANG SU wrote: > After removing some generated files and bin files from 4.1.0.rc3, only > source code kept in the artifact. > I am pleased to be calling this vote for the release of Apache ECharts > 4.1.0.rc4. > > > Apache ECharts community has voted and approved the release. > > Vote thread: > https://lists.apache.org/thread.html/8ebfdd7219cbfed40cd2350e487b99 > be58ec169fb7c5673e21e10dea@%3Cdev.echarts.apache.org%3E > > Results thread: > https://lists.apache.org/thread.html/238ae37a82e2a71698f41a4d878e32 > 5601b88c665f9951d3bf912db4@%3Cdev.echarts.apache.org%3E > > The release candidate to be voted over is available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/4.1.0.rc4/ > > The release candidate is signed with a GPG key available at: > https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS > > The Git commit for this release is: > https://gitbox.apache.org/repos/asf?p=incubator-echarts. > git;a=commit;h=02842e2 > > The Release Note is available in: > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > 1.0.rc4/RELEASE_NOTE.txt > > Some shell commands for validating the release: > > ```shell > # Download the release: > curl > https://dist.apache.org/repos/dist/dev/incubator/echarts/4. > 1.0.rc4/apache-echarts-4.1.0.rc4-incubating-src.zip > -o apache-echarts-4.1.0.rc4-incubating-src.zip > unzip apache-echarts-4.1.0.rc4-incubating-src.zip -d > apache-echarts-4.1.0.rc4-incubating-src > /dev/null > > # Rebuild the project (Node.js environment is required): > cd "apache-echarts-4.1.0.rc4-incubating-src" && npm install && cd .. > node "apache-echarts-4.1.0.rc4-incubating-src/build/build.js" --release > # (See help: `node "apache-echarts-4.1.0.rc4- > incubating-src/build/build.js" > --help`) > ``` > > > Please vote on releasing this package as: > Apache ECharts 4.1.0.rc4 > > This vote will be open until "2018-06-01T10:02:35.437Z". > > [ ] +1 Release this package > [ ] 0 I don't feel strongly about it, but don't object > [ ] -1 Do not release this package because... > > Anyone can participate in testing and voting, not just committers, please > feel free to try out the release candidate and provide your votes. > > -- > Su Shuang (100pah) > -- >
