Re: [ofa-general] [PATCH] opensm/osm_port.c: Remove error number from debug level log message
On 06:46 Sun 10 May , Hal Rosenstock wrote: Sasha has been adamant that any device supplied data errors use something other than ERROR log level. But I think that VERBOSE is more appropriate than for such cases than just DEBUG. Another way is to add another level for subnet warnings. Sasha ___ general mailing list general@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [ofa-general] [PATCH] opensm/osm_port.c: Remove error number from debug level log message
On Tue, May 12, 2009 at 1:55 PM, Sasha Khapyorsky sas...@voltaire.com wrote: On 06:46 Sun 10 May , Hal Rosenstock wrote: Sasha has been adamant that any device supplied data errors use something other than ERROR log level. But I think that VERBOSE is more appropriate than for such cases than just DEBUG. Yes, VERBOSE level is more consistent than DEBUG level with what is done elsewhere in OpenSM. -- Hal Another way is to add another level for subnet warnings. Sasha ___ general mailing list general@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [ofa-general] [PATCH] opensm/osm_port.c: Remove error number from debug level log message
On 14:06 Tue 12 May , Hal Rosenstock wrote: Yes, VERBOSE level is more consistent than DEBUG level with what is done elsewhere in OpenSM. Ok, I'm changing to VERBOSE. Sasha ___ general mailing list general@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [ofa-general] [PATCH] opensm/osm_port.c: Remove error number from debug level log message
Hal Rosenstock wrote:
Signed-off-by: Hal Rosenstock hal.rosenst...@gmail.com
---
diff --git a/opensm/opensm/osm_port.c b/opensm/opensm/osm_port.c
index 2e6c642..17bac73 100644
--- a/opensm/opensm/osm_port.c
+++ b/opensm/opensm/osm_port.c
@@ -381,7 +381,7 @@ uint8_t osm_physp_calc_link_op_vls(IN osm_log_t * p_log,
op_vls = p_subn-opt.max_op_vls;
if (op_vls == 0) {
- OSM_LOG(p_log, OSM_LOG_DEBUG, ERR 4102:
+ OSM_LOG(p_log, OSM_LOG_DEBUG,
Invalid OP_VLS = 0. Forcing correction to 1 (VL0)\n);
In this case I think that level should be changed to ERROR since this is not
the normal behavior.
op_vls = 1;
}
___
general mailing list
general@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [ofa-general] [PATCH] opensm/osm_port.c: Remove error number from debug level log message
On Sun, May 10, 2009 at 2:42 AM, Eli Dorfman (Voltaire)
dorfman@gmail.com wrote:
Hal Rosenstock wrote:
Signed-off-by: Hal Rosenstock hal.rosenst...@gmail.com
---
diff --git a/opensm/opensm/osm_port.c b/opensm/opensm/osm_port.c
index 2e6c642..17bac73 100644
--- a/opensm/opensm/osm_port.c
+++ b/opensm/opensm/osm_port.c
@@ -381,7 +381,7 @@ uint8_t osm_physp_calc_link_op_vls(IN osm_log_t * p_log,
op_vls = p_subn-opt.max_op_vls;
if (op_vls == 0) {
- OSM_LOG(p_log, OSM_LOG_DEBUG, ERR 4102:
+ OSM_LOG(p_log, OSM_LOG_DEBUG,
Invalid OP_VLS = 0. Forcing correction to 1 (VL0)\n);
In this case I think that level should be changed to ERROR since this is not
the normal behavior.
Sasha has been adamant that any device supplied data errors use
something other than ERROR log level.
-- Hal
op_vls = 1;
}
___
general mailing list
general@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
___
general mailing list
general@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
