robbat2 14/06/14 05:14:55 Modified: flag-o-matic.eclass ChangeLog Log: If you an empty argument to append-libs, you end up with a dangling -l without a library. Catch this in QA. Caught infra with a broken ncurses in net-dialup/xc with append-libs "$($(tc-getPKG_CONFIG) --libs ncurses)"
Revision Changes Path 1.198 eclass/flag-o-matic.eclass file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/flag-o-matic.eclass?rev=1.198&view=markup plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/flag-o-matic.eclass?rev=1.198&content-type=text/plain diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/flag-o-matic.eclass?r1=1.197&r2=1.198 Index: flag-o-matic.eclass =================================================================== RCS file: /var/cvsroot/gentoo-x86/eclass/flag-o-matic.eclass,v retrieving revision 1.197 retrieving revision 1.198 diff -p -w -b -B -u -u -r1.197 -r1.198 --- flag-o-matic.eclass 2 Feb 2014 22:26:13 -0000 1.197 +++ flag-o-matic.eclass 14 Jun 2014 05:14:55 -0000 1.198 @@ -1,6 +1,6 @@ # Copyright 1999-2014 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 -# $Header: /var/cvsroot/gentoo-x86/eclass/flag-o-matic.eclass,v 1.197 2014/02/02 22:26:13 tommy Exp $ +# $Header: /var/cvsroot/gentoo-x86/eclass/flag-o-matic.eclass,v 1.198 2014/06/14 05:14:55 robbat2 Exp $ # @ECLASS: flag-o-matic.eclass # @MAINTAINER: @@ -611,6 +611,10 @@ append-libs() { [[ $# -eq 0 ]] && return 0 local flag for flag in "$@"; do + if [[ -z "${flag// }" ]]; then + eqawarn "Appending an empty argument to LIBS is invalid! Skipping." + continue + fi case $flag in -[lL]*) export LIBS="${LIBS} ${flag}" 1.1287 eclass/ChangeLog file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ChangeLog?rev=1.1287&view=markup plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ChangeLog?rev=1.1287&content-type=text/plain diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/ChangeLog?r1=1.1286&r2=1.1287 Index: ChangeLog =================================================================== RCS file: /var/cvsroot/gentoo-x86/eclass/ChangeLog,v retrieving revision 1.1286 retrieving revision 1.1287 diff -p -w -b -B -u -u -r1.1286 -r1.1287 --- ChangeLog 12 Jun 2014 07:14:25 -0000 1.1286 +++ ChangeLog 14 Jun 2014 05:14:55 -0000 1.1287 @@ -1,6 +1,11 @@ # ChangeLog for eclass directory # Copyright 1999-2014 Gentoo Foundation; Distributed under the GPL v2 -# $Header: /var/cvsroot/gentoo-x86/eclass/ChangeLog,v 1.1286 2014/06/12 07:14:25 haubi Exp $ +# $Header: /var/cvsroot/gentoo-x86/eclass/ChangeLog,v 1.1287 2014/06/14 05:14:55 robbat2 Exp $ + + 14 Jun 2014; Robin H. Johnson <robb...@gentoo.org> flag-o-matic.eclass: + If you an empty argument to append-libs, you end up with a dangling -l + without a library. Catch this in QA. Caught infra with a broken ncurses in + net-dialup/xc with append-libs "$($(tc-getPKG_CONFIG) --libs ncurses)" 12 Jun 2014; Michael Haubenwallner <ha...@gentoo.org> -ELT-patches/aix-noundef/1.4d, libtool.eclass:
