Re: [gentoo-dev] stupid ebuild question
On Tue, Apr 21, 2009 at 06:47:40PM +0100, Ciaran McCreesh wrote:
> On Tue, 21 Apr 2009 10:39:38 -0700
> Greg KH wrote:
> > cp -R "${S}/*" "${D}lib/firmware/" || die "Install
> > failed!" }
>
> That should be "${S}"/* . If you quote the *, bash won't glob it.
>
> > `/var/tmp/portage/sys-kernel/linux-firmware-20090421/work/linux-firmware-20090421/*':
> > No such file or directory
> >
> > Yet the files are really in that directory.
>
> It's looking for a file literally named '*'.
Doh!
thanks so much, that did the trick.
linux-firmware package coming up now...
thanks,
greg k-h
Re: [gentoo-dev] stupid ebuild question
On Tuesday 21 April 2009 18:51:55 Ciaran McCreesh wrote:
> On Tue, 21 Apr 2009 20:48:48 +0100
>
> Markos Chandras wrote:
> > insinto /lib/firmware/
> > doins -r "${S}"/* || die "doins failed"
>
> Careful with that. For current EAPIs, doins -r's behaviour is only
> defined if it encounters regular files or directories. If there're any
> symlinks under there, behaviour is undefined.
Yes of course. I assumed that there is not symlink in there :)
--
Markos Chandras (hwoarang)
Gentoo Linux Developer
Qt/KDE/Sunrise/Sound
Web: http://hwoarang.silverarrow.gr
signature.asc
Description: This is a digitally signed message part.
Re: [gentoo-dev] stupid ebuild question
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Greg KH wrote:
> Ok, I know I'm doing something stupid here, but I can't figure it out.
>
> I have a new ebuild (linux-firmware) that is really just a tarball that
> needs to be placed somewhere in the filesystem.
>
> So, I do the following:
> src_install() {
> dodir /lib/firmware
> cp -R "${S}/*" "${D}lib/firmware/" || die "Install failed!"
> }
The * shouldn't be quoted. :P
- --
Thanks,
Zac
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.11 (GNU/Linux)
iEYEARECAAYFAknuCAYACgkQ/ejvha5XGaNkNgCdFa96u6CNBYVW1Ixgyv31NWOw
570AnR8gwtlbdMEnusNRA2nSN73Ut8z2
=fSlR
-END PGP SIGNATURE-
Re: [gentoo-dev] stupid ebuild question
On Tue, 21 Apr 2009 20:48:48 +0100
Markos Chandras wrote:
> insinto /lib/firmware/
> doins -r "${S}"/* || die "doins failed"
Careful with that. For current EAPIs, doins -r's behaviour is only
defined if it encounters regular files or directories. If there're any
symlinks under there, behaviour is undefined.
--
Ciaran McCreesh
signature.asc
Description: PGP signature
Re: [gentoo-dev] stupid ebuild question
On Tuesday 21 April 2009 18:39:38 Greg KH wrote:
> Ok, I know I'm doing something stupid here, but I can't figure it out.
>
> I have a new ebuild (linux-firmware) that is really just a tarball that
> needs to be placed somewhere in the filesystem.
>
> So, I do the following:
> src_install() {
> dodir /lib/firmware
> cp -R "${S}/*" "${D}lib/firmware/" || die "Install failed!"
> }
>
What I would do is the following
src_install() {
insinto /lib/firmware/
doins -r "${S}"/* || die "doins failed"
}
> but that fails badly:
> >>> Install linux-firmware-20090421 into
> >>> /var/tmp/portage/sys-kernel/linux-firmware-20090421/image/ category
> >>> sys-kernel
>
> cp: cannot stat
> `/var/tmp/portage/sys-kernel/linux-firmware-20090421/work/linux-firmware-20
>090421/*': No such file or directory
>
> Yet the files are really in that directory.
>
> I can't drop the trailing "*" on the cp command, otherwise we get the
> directory name that the firmware was expanded into during unpack into
> lib/firmware/.
>
> So, anyone want to apply the cluestick?
>
> thanks,
>
> greg k-h
--
Markos Chandras (hwoarang)
Gentoo Linux Developer
Qt/KDE/Sunrise/Sound
Web: http://hwoarang.silverarrow.gr
signature.asc
Description: This is a digitally signed message part.
Re: [gentoo-dev] stupid ebuild question
On Tue, 21 Apr 2009 10:39:38 -0700
Greg KH wrote:
> cp -R "${S}/*" "${D}lib/firmware/" || die "Install
> failed!" }
That should be "${S}"/* . If you quote the *, bash won't glob it.
> `/var/tmp/portage/sys-kernel/linux-firmware-20090421/work/linux-firmware-20090421/*':
> No such file or directory
>
> Yet the files are really in that directory.
It's looking for a file literally named '*'.
--
Ciaran McCreesh
signature.asc
Description: PGP signature
Re: [gentoo-dev] stupid ebuild question
Hi!
On Tue, 21 Apr 2009, Greg KH wrote:
> So, I do the following:
> src_install() {
> dodir /lib/firmware
> cp -R "${S}/*" "${D}lib/firmware/" || die "Install failed!"
> }
>
> but that fails badly:
> >>> Install linux-firmware-20090421 into
> /var/tmp/portage/sys-kernel/linux-firmware-20090421/image/ category sys-kernel
> cp: cannot stat
> `/var/tmp/portage/sys-kernel/linux-firmware-20090421/work/linux-firmware-20090421/*':
> No such file or directory
>
> Yet the files are really in that directory.
>
> I can't drop the trailing "*" on the cp command, otherwise we get the
> directory name that the firmware was expanded into during unpack into
> lib/firmware/.
>
> So, anyone want to apply the cluestick?
I don't see an error off the top of my head. What about writing
"echo" or "einfo" in front of the cp line so you see what the
expanded commandline is? An ls -l{,d } "${D}lib/firmware/" in the
same spot might be insightful, too.
Regards,
Tobias
--
printk(KERN_ERR "i82092aa: Oops, you did something we didn't think of.\n");
linux-2.6.19/drivers/pcmcia/i82092.c
[gentoo-dev] stupid ebuild question
Ok, I know I'm doing something stupid here, but I can't figure it out.
I have a new ebuild (linux-firmware) that is really just a tarball that
needs to be placed somewhere in the filesystem.
So, I do the following:
src_install() {
dodir /lib/firmware
cp -R "${S}/*" "${D}lib/firmware/" || die "Install failed!"
}
but that fails badly:
>>> Install linux-firmware-20090421 into
/var/tmp/portage/sys-kernel/linux-firmware-20090421/image/ category sys-kernel
cp: cannot stat
`/var/tmp/portage/sys-kernel/linux-firmware-20090421/work/linux-firmware-20090421/*':
No such file or directory
Yet the files are really in that directory.
I can't drop the trailing "*" on the cp command, otherwise we get the
directory name that the firmware was expanded into during unpack into
lib/firmware/.
So, anyone want to apply the cluestick?
thanks,
greg k-h
Re: [gentoo-dev] ECONF-OPTIONS (Was: PMS EAPI 3 more or less ready)
On Tue, 21 Apr 2009 05:11:15 +0300 Mart Raudsepp wrote: > > * ECONF-OPTIONS > > query > --disable-dependency-tracking has other implications than it being > allowed to be passed to ./configure or not - such as dependency > tracking being, well, disabled and the affects of that in face of any > outside influences to headers used by it from the system, when > compared to the case when dependency tracking is enabled. Such as > when a separate (possibly parallel) install step kicks in. If a parallel install is overwriting things on / whilst a package is compiling, things are already horribly broken regardless of this switch. PMS explicitly forbids that from happening. > Olivier Crête also has an outstanding comment about a maintainer > possibly not wanting that disabled in case of patches applied. Could > use some elaboration on that thought, or comments in replies. It's always possible to override it if necessary. > --enable-fast-install is completely new to me for consideration under > EAPI-3. Maybe I just missed it when reading PMS draft before, and it > wasn't listed in the other summaries. No, it's been there all along. -- Ciaran McCreesh signature.asc Description: PGP signature
Re: [gentoo-dev] PMS EAPI 3 more or less ready
This reply's just for minor wording things. If anyone's wanting to turn any of these into something more substantial, please change the subject and cut it back to one topic per subthread. On Tue, 21 Apr 2009 05:11:15 +0300 Mart Raudsepp wrote: > query/yes; but the default src_install maybe shouldn't be doing the > file exists and is greater than zero check, because dodoc in portage > already does that. Maybe formalize that and leave that check for dodoc > responsibility and don't bother checking twice? I'd rather leave it the way it is; otherwise things get confusing as dodoc's error handling behaviour gradually gets tightened up over newer EAPIs. > query. Lacks specification of what "correct" is in "must correctly > handle symlinks when installing recursively", so can't judge. I've tightened up the wording in PMS for that. > Also, would be interesting to know what sanity checks one would want > to apply in the future for absolute path symlinks in case they do not > start with $EPREFIX (don't honor --prefix)? Just curious for the > future on this one. There's already special behaviour mandated for merging absolute symlinks that point to things under $D. > Additionally the PMS draft has a typo: > > newinclude > As above, for doexample. Only in EAPIs listed in table 12.7 Fixed, thanks. > but also what if we want to display information based on saved > environment? Any suggestion into the spec which way to use for > checking if the package in question is already installed or not? has_version works there. > > * UNPACK-IF-COMPRESSED > > query > I think the spec draft reads that it will be an error to pass regular > files to unpack --if-compressed. That seems backwards. Uh, yeah, there's a missing 'not' or 'unless' there. Fixed. -- Ciaran McCreesh signature.asc Description: PGP signature
Re: [gentoo-dev] SLOT-OPERATOR-DEPS (Was: PMS EAPI 3 more or less ready)
On Tue, 21 Apr 2009 05:11:15 +0300 Mart Raudsepp wrote: > > * SLOT-OPERATOR-DEPS > > An outstanding problem to me as a package maintainer is the lack of > means to know which slot the PM actually picked for the package, as > some of my co-maintained packages have no use of := if it can't know > which version was picked to act accordingly in src_configure. The best installed version that matches the spec is always picked for :=. We originally considered making this more complicated, or possibly making ways of saying "all installed slots", but neither appears to have a legitimate use case. The latter in particular would only encourage abuse (people might mistakenly think it's a solution to the Python / Ruby ABIs thing). -- Ciaran McCreesh signature.asc Description: PGP signature
Re: [gentoo-dev] PKG-INFO (Was: PMS EAPI 3 more or less ready)
Still trying to stick to one subthread per item here. On Tue, 21 Apr 2009 04:27:41 +0300 Petteri Räty wrote: > > * PKG-INFO > > query. I have probably missed what's the use case for non installed > packages? For some packages, when a bug report for a failed build is submitted, there are a load of standard questions (versions of libraries that aren't in the usual info_pkgs list, configuration questions, ...) that need to be asked. This is a way of automating it. -- Ciaran McCreesh signature.asc Description: PGP signature
