Re: [gentoo-dev] Is there any way I can help with pull requests?
On 13.10.2018 15:59, James Le Cuirot wrote: [snip] > Such contributions also frequently have issues as the authors have not done > the developer quizzes. We try to guide contributors through the > necessary changes but this can lead to fatigue on both sides. Quizzes are irrelevant, a person does the quizzes when he/she is ready to be the dev, doing quizzes for quizzes or quizzes to become a developer is the best way to get rejected by the recruiters team. signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] Is there any way I can help with pull requests?
On Sat, Oct 13, 2018 at 8:59 AM James Le Cuirot wrote: > > On Sat, 13 Oct 2018 13:28:02 +0200 > Ralph Seichter wrote: > > > Is there any way I could help the Gentoo team? Any vacancies that need > > to be filled, or work that needs to be done? > > Following what I said above, we need more actual bona fide developers > who have done the quizzes, understand the issues, can most important > can take responsibility for their own contributions. > > There is the proxy maintainers project, where we can accept > contributions with a little less scrutiny, but I personally feel that > these contributors really should just become developers. It doesn't > matter if you're only interested in one or two packages, any help is > very welcome. > I have to imagine that while waiting to become a dev (or not), it would still be useful if contributors would like to skim pull requests and find ways to contribute to them. If a dev has pointed out an issue with a pull request, consider offering a patch to fix the issue. If a pull request hasn't been looked at, consider looking at it and offering patches to resolve any issues you see. Sure, ultimately a dev still has to review/commit, but I imagine any help with triage will just make their life easier, which means they'll be able to get more commits into the actual tree. And of course all the skills you would use to clean up pull requests are for the most part the same ones you'll need to become a dev. Also, reading a bunch of dev comments about quality issues with pull requests will make you aware of the kinds of QA issues people routinely run into, and you'll be less likely to create the same problems. In my experience the best way to get accepted as a committer in just about any kind of FOSS project is to basically do just this. Sooner or later you'll be noticed and short-listed. You'll also rub shoulders with people who are likely to become mentors, and since recruiter availability is limited they're going to be bound to focus on applicants who are active already. -- Rich
Re: [gentoo-dev] Is there any way I can help with pull requests?
On 13.10.18 20:00, Michał Górny wrote: > For example, in the recent period proxy-maint's backlog didn't really > go beyond 7 days, and we're rather capable of getting through it all. Glancing at my own open pull requests, it looks different (opened 15 and 25 days ago, respectively). That is not meant as criticism; it just seems to me that the team members who process PRs have a lot on their plates. > ~200 open pull requests is a really small number given the size of > Gentoo. You can easily find many projects having 1000-1 open pull > requests. 200 as an absolute number does not sound like too much, but it all depends on how many people process those PRs, and how much time they need to spend doing it. -Ralph
Re: [gentoo-dev] Is there any way I can help with pull requests?
On Sat, 2018-10-13 at 13:28 +0200, Ralph Seichter wrote: > Looking at the number of open pull requests (some of them my own), I > wonder if Gentoo has become a bit of a victim of its own success as far > as contributions are concerned. It's not really as much problem as it seems. For example, in the recent period proxy-maint's backlog didn't really go beyond 7 days, and we're rather capable of getting through it all. The large number of open PRs is mostly due to: a. PRs waiting for the submitter to update them (sadly, including some 'throwaway' submissions), b. PRs waiting for package maintainer to respond (sadly, we have many developers who ignore submissions on GitHub). Even then, ~200 open pull requests is a really small number given the size of Gentoo. You can easily find many projects having 1000-1 open pull requests. -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part
Re: [gentoo-dev] Is there any way I can help with pull requests?
On 13.10.2018 14:57, Thomas Deutschmann wrote: > Looking forward to see your Gentoo developer bug in near future! :-) I've sent an application to the recruiters' email address. We shall see what they think. ;-) -Ralph
Re: [gentoo-dev] Is there any way I can help with pull requests?
On 13.10.18 14:57, Thomas Deutschmann wrote: > Please read https://www.gentoo.org/get-involved/become-developer/ I already did that months ago. ;-) At that time, I was not certain if I had enough spare time to become involved enough to make going through the process of becoming a Gentoo developer worthwhile. I have contributed some PRs, and brought in www-servers/nginx-unit as a new package, for which I am designated proxy maintainer [1]. If there was an experienced team member willing to be my mentor, I'd be willing to take the next steps towards developer status. [1] https://bugs.gentoo.org/661450 -Ralph
Re: [gentoo-dev] Is there any way I can help with pull requests?
You can review the PRs and try to remove common errors before the devs check it. Then they don't have to correct the same mistakes again. I don't mean you do the corrections, you just suggest them to the PR authors so they probably won't repeat them again. Common stuff like: - using latest eapi (at least for new pkgs)? - correct distfile name? - proxy maint project in metadata? - correct, sorted deps? - slot operators for rebuilds? - working tests if possible? - patches from reliable sources? - using || die after commands? - reusing eclasseses instead of custom solutions? - openrc/systemd done right? - is it secure? - you name it... :) Maybe we could script some of these to help too.
Re: [gentoo-dev] Is there any way I can help with pull requests?
October 13, 2018 3:00 PM, "James Le Cuirot" wrote: > On Sat, 13 Oct 2018 13:28:02 +0200 > Ralph Seichter wrote: > >> Looking at the number of open pull requests (some of them my own), I >> wonder if Gentoo has become a bit of a victim of its own success as far >> as contributions are concerned. > > I've said as much, at least with regards to the addition of GitHub. The > problem is that maintainers are not supposed to just blindly merge > contributions but they often lack the time to test them. Such > contributions also frequently have issues as the authors have not done > the developer quizzes. We try to guide contributors through the > necessary changes but this can lead to fatigue on both sides. > >> Is there any way I could help the Gentoo team? Any vacancies that need >> to be filled, or work that needs to be done? > > Following what I said above, we need more actual bona fide developers > who have done the quizzes, understand the issues, can most important > can take responsibility for their own contributions. > > There is the proxy maintainers project, where we can accept > contributions with a little less scrutiny, but I personally feel that > these contributors really should just become developers. It doesn't > matter if you're only interested in one or two packages, any help is > very welcome. I've always considered the entry barrier to become a dev too much work for keeping a small involvement. I might just be lazy or not interested enough I agree. Still I must not be the only one. I might also just have a wrong impression of what's needed. Couldnt it be possible to create more granulars levels of involvement? Corentin “Nado” Pazdera
Re: [gentoo-dev] Is there any way I can help with pull requests?
On Sat, 13 Oct 2018 13:28:02 +0200 Ralph Seichter wrote: > Looking at the number of open pull requests (some of them my own), I > wonder if Gentoo has become a bit of a victim of its own success as far > as contributions are concerned. I've said as much, at least with regards to the addition of GitHub. The problem is that maintainers are not supposed to just blindly merge contributions but they often lack the time to test them. Such contributions also frequently have issues as the authors have not done the developer quizzes. We try to guide contributors through the necessary changes but this can lead to fatigue on both sides. > Is there any way I could help the Gentoo team? Any vacancies that need > to be filled, or work that needs to be done? Following what I said above, we need more actual bona fide developers who have done the quizzes, understand the issues, can most important can take responsibility for their own contributions. There is the proxy maintainers project, where we can accept contributions with a little less scrutiny, but I personally feel that these contributors really should just become developers. It doesn't matter if you're only interested in one or two packages, any help is very welcome. -- James Le Cuirot (chewi) Gentoo Linux Developer pgpWazCL7rBqk.pgp Description: OpenPGP digital signature
Re: [gentoo-dev] Is there any way I can help with pull requests?
Hi, in the end, only Gentoo developer can help because they have to do the final review and are the only one who can merge. But you can become a Gentoo developer! Please read https://www.gentoo.org/get-involved/become-developer/ As Gentoo developer you could join Gentoo's Proxy Maintainers project and deal with all those pull requests. Looking forward to see your Gentoo developer bug in near future! :-) -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5 signature.asc Description: OpenPGP digital signature
[gentoo-dev] Is there any way I can help with pull requests?
Looking at the number of open pull requests (some of them my own), I wonder if Gentoo has become a bit of a victim of its own success as far as contributions are concerned. Is there any way I could help the Gentoo team? Any vacancies that need to be filled, or work that needs to be done? -Ralph
[gentoo-dev] [RFC] Global use 'jemalloc'
Apparently this thing is getting common: jemalloc - Use dev-libs/jemalloc for memory management 28 uses: app-admin/rsyslog: Use dev-libs/jemalloc for allocations. app-editors/neovim: Use dev-libs/jemalloc for allocations app-office/libreoffice: Use dev-libs/jemalloc for allocations app-text/groonga: Enable dev-libs/jemalloc for memory management dev-db/mariadb: Use dev-libs/jemalloc for allocations. dev-db/mariadb-galera: Use dev-libs/jemalloc for allocations. dev-db/mysql: Use dev-libs/jemalloc for allocations. dev-db/mysql-cluster: Use dev-libs/jemalloc for allocations. dev-db/percona-server: Use dev-libs/jemalloc for allocations. dev-db/redis: Use dev-libs/jemalloc for allocations. dev-db/rethinkdb: Use dev-libs/jemalloc for allocations (default). dev-lang/ruby: Use dev-libs/jemalloc for memory allocation. dev-lang/rust: Use dev-libs/jemalloc as the standard memory allocator dev-libs/bitset: Use dev-libs/jemalloc for allocations mail-client/thunderbird: Enable or disable jemalloc mail-filter/rspamd: Use dev-libs/jemalloc for allocations media-gfx/blender: Use dev-libs/jemalloc for memory allocation. net-analyzer/bro: Support for the Jemalloc allocator net-libs/nghttp2: Use dev-libs/jemalloc for memory allocation net-misc/aria2: Use dev-libs/jemalloc to replace the malloc() implementation with a possibly faster one sci-libs/tensorflow: Enable support for dev-libs/jemalloc sci-physics/root: Enable support for dev-libs/jemalloc sys-cluster/ceph: Use dev-libs/jemalloc for allocations sys-cluster/hpx: Use dev-libs/jemalloc for memory allocation www-client/firefox: Enable or disable jemalloc www-client/seamonkey: Enable or disable jemalloc www-servers/uwsgi: Use dev-libs/jemalloc instead of libc's malloc www-servers/varnish: Use dev-libs/jemalloc for allocations -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part
[gentoo-dev] [RFC] Global use flag: opus
Hi, This time really verified it: opus - Enable Opus audio codec support 28 consistent uses: app-emulation/virtualbox: Adds support for the Opus codec via media- libs/opus games-fps/urbanterror: Use opus as sound codec kde-apps/kwave: Enable Opus audio codec support media-libs/allegro: Enable Opus codec support media-libs/avidemux-plugins: Adds support for the Opus codec via media-libs/opus. media-libs/mediastreamer: Enable opus codec support media-plugins/gst-plugins-meta: Enable Opus audio codec support media-sound/abcde: Support opus encoding using opusenc media-sound/asunder: Support for creation of Opus files media-sound/cmus: enable support for media-libs/opusfile media-sound/darkice: Enable Opus audio codec support media-sound/easytag: Enable support for media-libs/opus and media- libs/opusfile (opus audio codec) media-sound/gogglesmm: Enable support for opus codec media-sound/jack2: Support media-libs/opus media-sound/mangler: Codec specialized for speech over the internet media-sound/mixxx: Enable support for opus codec via media- libs/opusfile. media-sound/mpd: Enable Opus codec support media-sound/mumble: Enable Opus codec support via media-libs/opus. media-sound/potamus: Adds support for the Opus codec. media-sound/qmmp: Enable the opus plugin media-sound/soundconverter: Enable Opus audio codec support media-sound/sox: Enables reading Ogg Opus files. media-sound/xmms2: Enable Opus audio codec support media-tv/tvheadend: Enable transcoding with the Opus audio codec media-video/ffmpeg: Adds (decoding) support for the Opus codec via media-libs/opus. media-video/vlc: Support opus decoding via libopus net-libs/pjproject: Include OPUS support in the build net-libs/qxmpp: Enable Opus codec support via media-libs/opus Two cases are unclear: media-video/libav: Use the external opus library for encoding and decoding. virtual/ffmpeg: Use the external opus library for encoding and decoding. -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part
Re: [gentoo-dev] [RFC] Global use flag: webp
On Sat, 2018-10-13 at 11:19 +0200, Michał Górny wrote: > Hi, > > Next suggestion: > > webp - Enable support for webp image format (usually via > media-libs/libwebp) > Nevermind, it is global already; it seems my script didn't detect that correctly. -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part
[gentoo-dev] [RFC] Global use flag: webp
Hi, Next suggestion: webp - Enable support for webp image format (usually via media-libs/libwebp) It's used consistently in 24 packages: app-text/tesseract: Enable support for webp image format. dev-games/aseprite: Enable webp image format support dev-lang/php: Enable webp support for GD in php-7.x dev-libs/efl: Enable WebP image loader dev-libs/weston: Add support for the WebP image format dev-qt/qtwebkit: Add support for WebP image format media-gfx/darktable: Enable WebP export support media-gfx/fbida: Enable support for the WebP image format media-gfx/graphicsmagick: Enable support for webp image format media-gfx/gthumb: Enable support for webp image format media-gfx/imagemagick: Enable webp image format support using media- libs/libwebp media-gfx/imageworsener: enable webp image format support media-libs/gd: Enable support for the webp format media-libs/gegl: Enable support for media-libs/libwebp media-libs/jbig2enc: Add support for WEBP image format media-libs/leptonica: Adds support for the WebP image format media-libs/opencv: Enable support for webp image format media-libs/sdl-image: support loading WEBP images media-libs/sdl2-image: support loading WEBP images media-video/ffmpeg: Enables WebP encoding with media-libs/libwebp. media-video/libav: Enable WebP encoding with media-libs/libwebp. www-client/netsurf: WebP image support (media-libs/libwebp) x11-wm/windowmaker: Enables WebP image format support using media- libs/libwebp x11-wm/xpra: Enable webp image format support -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part
Re: [gentoo-dev] [RFC] Global use flag 'zip'
On Fri, 12 Oct 2018 22:09:52 +0200 Michał Górny wrote: > Hi, > > I'd like to propose adding the following global USE flag: > > zip - Enable support for .zip archives The file format is called ZIP. Kind regards, jer
