Re: [gentoo-dev] Packages up for grabs: x11-libs/gdk-pixbuf-loader-webp
Ühel kenal päeval, R, 11.09.2020 kell 00:08, kirjutas Jonas Stein: > Dear all > > the following packages are up for grabs after retirement > of the proxied maintainer: > > https://packages.gentoo.org/packages/x11-libs/gdk-pixbuf-loader-webp > > The package has open bugs > https://bugs.gentoo.org/693062 > https://bugs.gentoo.org/703864 gnome@ can take this as gdk-pixbuf maintainer and WebP being an important image format, but I can't action the bugs and reassignment personally before 8+ days. Mart signature.asc Description: This is a digitally signed message part
[gentoo-dev] Packages up for grabs: x11-libs/gdk-pixbuf-loader-webp
Dear all the following packages are up for grabs after retirement of the proxied maintainer: https://packages.gentoo.org/packages/x11-libs/gdk-pixbuf-loader-webp The package has open bugs https://bugs.gentoo.org/693062 https://bugs.gentoo.org/703864 -- Best, Jonas signature.asc Description: OpenPGP digital signature
[gentoo-dev] Last rites: dev-python/pysendfile
# Louis Sautier (2020-09-10) # Masked for removal in 30 days, no revdeps. # All former consumers now use os.sendfile available in Python >= 3.3. dev-python/pysendfile signature.asc Description: OpenPGP digital signature
[gentoo-dev] Last rites: dev-tex/dvi2tty
# Mikle Kolyada (2020-09-10) # Merged into the app-text/texlive-core package. # Removal in 30 days dev-tex/dvi2tty signature.asc Description: OpenPGP digital signature
[gentoo-dev] [PATCH 7/8] eutils.eclass: Deprecate emktemp().
Signed-off-by: Ulrich Müller
---
eclass/eutils.eclass | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
index cd59d3f9ccc4..0a99d00ee01a 100644
--- a/eclass/eutils.eclass
+++ b/eclass/eutils.eclass
@@ -31,9 +31,11 @@ esac
# @FUNCTION: emktemp
# @USAGE: [temp dir]
# @DESCRIPTION:
-# Cheap replacement for when debianutils (and thus mktemp)
-# does not exist on the users system.
+# Cheap replacement for when coreutils (and thus mktemp) does not exist
+# on the user's system.
emktemp() {
+ eqawarn "emktemp is deprecated. Create a temporary file in \${T}
instead."
+
local exe="touch"
[[ $1 == -d ]] && exe="mkdir" && shift
local topdir=$1
--
2.28.0
[gentoo-dev] [PATCH 8/8] eutils.eclass: Deprecate use_if_iuse().
The function is not called from any ebuilds in the gentoo repository.
Inline it as "in_iuse foo && use foo" in other eclasses, or define it
as a local function when it is called multiple times.
Signed-off-by: Ulrich Müller
---
eclass/chromium-2.eclass | 4 +--
eclass/eutils.eclass | 3 ++
eclass/gnome2.eclass | 2 +-
eclass/mate.eclass | 4 +--
eclass/toolchain.eclass | 77 ++--
5 files changed, 51 insertions(+), 39 deletions(-)
diff --git a/eclass/chromium-2.eclass b/eclass/chromium-2.eclass
index c9cfe5acebee..b3d63f302d05 100644
--- a/eclass/chromium-2.eclass
+++ b/eclass/chromium-2.eclass
@@ -1,4 +1,4 @@
-# Copyright 1999-2016 Gentoo Foundation
+# Copyright 1999-2020 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
# @ECLASS: chromium-2.eclass
@@ -126,7 +126,7 @@ chromium_pkg_die() {
fi
# No ricer bugs.
- if use_if_iuse custom-cflags; then
+ if in_iuse custom-cflags && use custom-cflags; then
ewarn
ewarn "You have enabled the custom-cflags USE flag."
ewarn "Please disable it before reporting a bug."
diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
index 0a99d00ee01a..ba6bf8178673 100644
--- a/eclass/eutils.eclass
+++ b/eclass/eutils.eclass
@@ -79,6 +79,9 @@ path_exists() {
#
# Note that this function should not be used in the global scope.
use_if_iuse() {
+ eqawarn "use_if_iuse is deprecated."
+ eqawarn "Define it as a local function, or inline it:"
+ eqawarn "in_iuse foo && use foo"
in_iuse $1 || return 1
use $1
}
diff --git a/eclass/gnome2.eclass b/eclass/gnome2.eclass
index a16fc916c6d2..1a4ff451df32 100644
--- a/eclass/gnome2.eclass
+++ b/eclass/gnome2.eclass
@@ -296,7 +296,7 @@ gnome2_src_install() {
if has ${EAPI:-0} 4; then
if [[ "${GNOME2_LA_PUNT}" != "no" ]]; then
ebegin "Removing .la files"
- if ! use_if_iuse static-libs ; then
+ if ! in_iuse static-libs || ! use static-libs ; then
find "${D}" -name '*.la' -exec rm -f {} + ||
die "la file removal failed"
fi
eend
diff --git a/eclass/mate.eclass b/eclass/mate.eclass
index d7dd2dbceec0..34d5e47acc22 100644
--- a/eclass/mate.eclass
+++ b/eclass/mate.eclass
@@ -1,4 +1,4 @@
-# Copyright 1999-2016 Gentoo Foundation
+# Copyright 1999-2020 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
# @ECLASS: mate.eclass
@@ -120,7 +120,7 @@ mate_src_configure() {
local mateconf=()
# Pass --disable-static whenever possible
- if ! use_if_iuse static-libs; then
+ if ! in_iuse static-libs || ! use static-libs; then
if grep -q "enable-static" "${ECONF_SOURCE:-.}"/configure; then
mateconf+=( --disable-static )
fi
diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
index 6fb3eb941a2c..32996a2f8f71 100644
--- a/eclass/toolchain.eclass
+++ b/eclass/toolchain.eclass
@@ -398,10 +398,13 @@ SRC_URI=$(get_gcc_src_uri)
#>> pkg_pretend <<
toolchain_pkg_pretend() {
- if ! use_if_iuse cxx ; then
- use_if_iuse go && ewarn 'Go requires a C++ compiler, disabled
due to USE="-cxx"'
- use_if_iuse objc++ && ewarn 'Obj-C++ requires a C++ compiler,
disabled due to USE="-cxx"'
- use_if_iuse gcj && ewarn 'GCJ requires a C++ compiler, disabled
due to USE="-cxx"'
+ if ! _tc_use_if_iuse cxx ; then
+ _tc_use_if_iuse go && \
+ ewarn 'Go requires a C++ compiler, disabled due to
USE="-cxx"'
+ _tc_use_if_iuse objc++ && \
+ ewarn 'Obj-C++ requires a C++ compiler, disabled due to
USE="-cxx"'
+ _tc_use_if_iuse gcj && \
+ ewarn 'GCJ requires a C++ compiler, disabled due to
USE="-cxx"'
fi
want_minispecs
@@ -461,7 +464,8 @@ toolchain_src_prepare() {
*) die "Update toolchain_src_prepare() for ${EAPI}." ;;
esac
- if ( tc_version_is_at_least 4.8.2 || use_if_iuse hardened ) && ! use
vanilla ; then
+ if ( tc_version_is_at_least 4.8.2 || _tc_use_if_iuse hardened ) \
+ && ! use vanilla ; then
make_gcc_hard
fi
@@ -481,7 +485,7 @@ toolchain_src_prepare() {
fi
# >= gcc-4.3 doesn't bundle ecj.jar, so copy it
- if tc_version_is_at_least 4.3 && use_if_iuse gcj ; then
+ if tc_version_is_at_least 4.3 && _tc_use_if_iuse gcj ; then
if tc_version_is_at_least 4.5 ; then
einfo "Copying ecj-4.5.jar"
cp -pPR "${DISTDIR}/ecj-4.5.jar" "${S}/ecj.jar" || die
@@ -578,13 +582,13 @@ make_gcc_hard() {
# Gcc >= 6.X we can use
[gentoo-dev] [PATCH 4/8] wrapper.eclass: Do not use emktemp.
Signed-off-by: Ulrich Müller
---
eclass/wrapper.eclass | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/eclass/wrapper.eclass b/eclass/wrapper.eclass
index 8cde94979d1a..399c7cc269d4 100644
--- a/eclass/wrapper.eclass
+++ b/eclass/wrapper.eclass
@@ -9,8 +9,6 @@
if [[ -z ${_WRAPPER_ECLASS} ]]; then
_WRAPPER_ECLASS=1
-inherit eutils # for emktemp
-
# @FUNCTION: make_wrapper
# @USAGE: [chdir] [libpaths] [installpath]
# @DESCRIPTION:
@@ -20,7 +18,7 @@ inherit eutils # for emktemp
# libpaths followed by optionally changing directory to chdir.
make_wrapper() {
local wrapper=$1 bin=$2 chdir=$3 libdir=$4 path=$5
- local tmpwrapper=$(emktemp)
+ local tmpwrapper="${T}/tmp.wrapper.${wrapper##*/}"
has "${EAPI:-0}" 0 1 2 && local EPREFIX=""
(
--
2.28.0
[gentoo-dev] [PATCH 6/8] l10n.eclass: strip-linguas() moved from eutils to here.
Signed-off-by: Ulrich Müller
---
eclass/eutils.eclass | 53 ++--
eclass/l10n.eclass | 47 +++
2 files changed, 49 insertions(+), 51 deletions(-)
diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
index 0072f4ccf3e7..cd59d3f9ccc4 100644
--- a/eclass/eutils.eclass
+++ b/eclass/eutils.eclass
@@ -21,10 +21,10 @@ _EUTILS_ECLASS=1
# implicitly inherited (now split) eclasses
case ${EAPI:-0} in
0|1|2|3|4|5|6)
- inherit desktop edos2unix epatch estack ltprune multilib \
+ inherit desktop edos2unix epatch estack l10n ltprune multilib \
preserve-libs toolchain-funcs vcs-clean wrapper
;;
- 7) inherit edos2unix wrapper ;;
+ 7) inherit edos2unix l10n wrapper ;;
*) die "${ECLASS} is banned in EAPI ${EAPI}" ;;
esac
@@ -63,55 +63,6 @@ emktemp() {
fi
}
-# @FUNCTION: strip-linguas
-# @USAGE: [|<-i|-u> ]
-# @DESCRIPTION:
-# Make sure that LINGUAS only contains languages that
-# a package can support. The first form allows you to
-# specify a list of LINGUAS. The -i builds a list of po
-# files found in all the directories and uses the
-# intersection of the lists. The -u builds a list of po
-# files found in all the directories and uses the union
-# of the lists.
-strip-linguas() {
- local ls newls nols
- if [[ $1 == "-i" ]] || [[ $1 == "-u" ]] ; then
- local op=$1; shift
- ls=$(find "$1" -name '*.po' -exec basename {} .po ';'); shift
- local d f
- for d in "$@" ; do
- if [[ ${op} == "-u" ]] ; then
- newls=${ls}
- else
- newls=""
- fi
- for f in $(find "$d" -name '*.po' -exec basename {} .po
';') ; do
- if [[ ${op} == "-i" ]] ; then
- has ${f} ${ls} && newls="${newls} ${f}"
- else
- has ${f} ${ls} || newls="${newls} ${f}"
- fi
- done
- ls=${newls}
- done
- else
- ls="$@"
- fi
-
- nols=""
- newls=""
- for f in ${LINGUAS} ; do
- if has ${f} ${ls} ; then
- newls="${newls} ${f}"
- else
- nols="${nols} ${f}"
- fi
- done
- [[ -n ${nols} ]] \
- && einfo "Sorry, but ${PN} does not support the LINGUAS:"
${nols}
- export LINGUAS=${newls:1}
-}
-
path_exists() {
eerror "path_exists has been removed. Please see the following post"
eerror "for a replacement snippet:"
diff --git a/eclass/l10n.eclass b/eclass/l10n.eclass
index 73d54ec22334..7bd8f382fbe3 100644
--- a/eclass/l10n.eclass
+++ b/eclass/l10n.eclass
@@ -124,4 +124,51 @@ l10n_get_locales() {
printf "%s" "${locs}"
}
+# @FUNCTION: strip-linguas
+# @USAGE: [|<-i|-u> ]
+# @DESCRIPTION:
+# Make sure that LINGUAS only contains languages that a package can
+# support. The first form allows you to specify a list of LINGUAS.
+# The -i builds a list of po files found in all the directories and uses
+# the intersection of the lists. The -u builds a list of po files found
+# in all the directories and uses the union of the lists.
+strip-linguas() {
+ local ls newls nols
+ if [[ $1 == "-i" ]] || [[ $1 == "-u" ]] ; then
+ local op=$1; shift
+ ls=$(find "$1" -name '*.po' -exec basename {} .po ';'); shift
+ local d f
+ for d in "$@" ; do
+ if [[ ${op} == "-u" ]] ; then
+ newls=${ls}
+ else
+ newls=""
+ fi
+ for f in $(find "$d" -name '*.po' -exec basename {} .po
';') ; do
+ if [[ ${op} == "-i" ]] ; then
+ has ${f} ${ls} && newls="${newls} ${f}"
+ else
+ has ${f} ${ls} || newls="${newls} ${f}"
+ fi
+ done
+ ls=${newls}
+ done
+ else
+ ls="$@"
+ fi
+
+ nols=""
+ newls=""
+ for f in ${LINGUAS} ; do
+ if has ${f} ${ls} ; then
+ newls="${newls} ${f}"
+ else
+ nols="${nols} ${f}"
+ fi
+ done
+ [[ -n ${nols} ]] \
+ && einfo "Sorry, but ${PN} does not support the LINGUAS:"
${nols}
+ export LINGUAS=${newls:1}
+}
+
fi
--
2.28.0
[gentoo-dev] [PATCH 5/8] l10n.eclass: Add conditional to prevent multiple inclusion.
Signed-off-by: Ulrich Müller
---
eclass/l10n.eclass | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/eclass/l10n.eclass b/eclass/l10n.eclass
index 0b2d287afa7f..73d54ec22334 100644
--- a/eclass/l10n.eclass
+++ b/eclass/l10n.eclass
@@ -1,4 +1,4 @@
-# Copyright 1999-2018 Gentoo Foundation
+# Copyright 1999-2020 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
# @ECLASS: l10n.eclass
@@ -14,6 +14,9 @@
# determining the cross-section between the user's set LINGUAS and what
# is offered by the package.
+if [[ -z ${_L10N_ECLASS} ]]; then
+_L10N_ECLASS=1
+
# @ECLASS-VARIABLE: PLOCALES
# @DEFAULT_UNSET
# @DESCRIPTION:
@@ -120,3 +123,5 @@ l10n_get_locales() {
fi
printf "%s" "${locs}"
}
+
+fi
--
2.28.0
[gentoo-dev] [PATCH 1/8] eutils.eclass: Specify supported EAPIs.
Proactively deprecate in future EAPIs, as requested by soap.
Signed-off-by: Ulrich Müller
---
eclass/eutils.eclass | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
index c2fc05c9dbed..f74074fb4f16 100644
--- a/eclass/eutils.eclass
+++ b/eclass/eutils.eclass
@@ -4,6 +4,7 @@
# @ECLASS: eutils.eclass
# @MAINTAINER:
# base-sys...@gentoo.org
+# @SUPPORTED_EAPIS: 0 1 2 3 4 5 6 7
# @BLURB: many extra (but common) functions that are used in ebuilds
# @DESCRIPTION:
# The eutils eclass contains a suite of functions that complement
@@ -19,10 +20,12 @@ _EUTILS_ECLASS=1
# implicitly inherited (now split) eclasses
case ${EAPI:-0} in
-0|1|2|3|4|5|6)
- inherit desktop epatch estack ltprune multilib preserve-libs \
- toolchain-funcs vcs-clean
- ;;
+ 0|1|2|3|4|5|6)
+ inherit desktop epatch estack ltprune multilib preserve-libs \
+ toolchain-funcs vcs-clean
+ ;;
+ 7) ;;
+ *) die "${ECLASS} is banned in EAPI ${EAPI}" ;;
esac
# @FUNCTION: emktemp
--
2.28.0
[gentoo-dev] [PATCH 3/8] wrapper.eclass: New eclass, split off from eutils.
Signed-off-by: Ulrich Müller
---
eclass/eutils.eclass | 51 ++--
eclass/wrapper.eclass | 61 +++
2 files changed, 63 insertions(+), 49 deletions(-)
create mode 100644 eclass/wrapper.eclass
diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
index 3b3e328ba30d..0072f4ccf3e7 100644
--- a/eclass/eutils.eclass
+++ b/eclass/eutils.eclass
@@ -22,9 +22,9 @@ _EUTILS_ECLASS=1
case ${EAPI:-0} in
0|1|2|3|4|5|6)
inherit desktop edos2unix epatch estack ltprune multilib \
- preserve-libs toolchain-funcs vcs-clean
+ preserve-libs toolchain-funcs vcs-clean wrapper
;;
- 7) inherit edos2unix ;;
+ 7) inherit edos2unix wrapper ;;
*) die "${ECLASS} is banned in EAPI ${EAPI}" ;;
esac
@@ -112,53 +112,6 @@ strip-linguas() {
export LINGUAS=${newls:1}
}
-# @FUNCTION: make_wrapper
-# @USAGE: [chdir] [libpaths] [installpath]
-# @DESCRIPTION:
-# Create a shell wrapper script named wrapper in installpath
-# (defaults to the bindir) to execute target (default of wrapper) by
-# first optionally setting LD_LIBRARY_PATH to the colon-delimited
-# libpaths followed by optionally changing directory to chdir.
-make_wrapper() {
- local wrapper=$1 bin=$2 chdir=$3 libdir=$4 path=$5
- local tmpwrapper=$(emktemp)
- has "${EAPI:-0}" 0 1 2 && local EPREFIX=""
-
- (
- echo '#!/bin/sh'
- if [[ -n ${libdir} ]] ; then
- local var
- if [[ ${CHOST} == *-darwin* ]] ; then
- var=DYLD_LIBRARY_PATH
- else
- var=LD_LIBRARY_PATH
- fi
- cat <<-EOF
- if [ "\${${var}+set}" = "set" ] ; then
- export ${var}="\${${var}}:${EPREFIX}${libdir}"
- else
- export ${var}="${EPREFIX}${libdir}"
- fi
- EOF
- fi
- [[ -n ${chdir} ]] && printf 'cd "%s" &&\n' "${EPREFIX}${chdir}"
- # We don't want to quote ${bin} so that people can pass complex
- # things as ${bin} ... "./someprog --args"
- printf 'exec %s "$@"\n' "${bin/#\//${EPREFIX}/}"
- ) > "${tmpwrapper}"
- chmod go+rx "${tmpwrapper}"
-
- if [[ -n ${path} ]] ; then
- (
- exeopts -m 0755
- exeinto "${path}"
- newexe "${tmpwrapper}" "${wrapper}"
- ) || die
- else
- newbin "${tmpwrapper}" "${wrapper}" || die
- fi
-}
-
path_exists() {
eerror "path_exists has been removed. Please see the following post"
eerror "for a replacement snippet:"
diff --git a/eclass/wrapper.eclass b/eclass/wrapper.eclass
new file mode 100644
index ..8cde94979d1a
--- /dev/null
+++ b/eclass/wrapper.eclass
@@ -0,0 +1,61 @@
+# Copyright 1999-2020 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+# @ECLASS: wrapper.eclass
+# @MAINTAINER:
+# base-sys...@gentoo.org
+# @BLURB: create a shell wrapper script
+
+if [[ -z ${_WRAPPER_ECLASS} ]]; then
+_WRAPPER_ECLASS=1
+
+inherit eutils # for emktemp
+
+# @FUNCTION: make_wrapper
+# @USAGE: [chdir] [libpaths] [installpath]
+# @DESCRIPTION:
+# Create a shell wrapper script named wrapper in installpath
+# (defaults to the bindir) to execute target (default of wrapper)
+# by first optionally setting LD_LIBRARY_PATH to the colon-delimited
+# libpaths followed by optionally changing directory to chdir.
+make_wrapper() {
+ local wrapper=$1 bin=$2 chdir=$3 libdir=$4 path=$5
+ local tmpwrapper=$(emktemp)
+ has "${EAPI:-0}" 0 1 2 && local EPREFIX=""
+
+ (
+ echo '#!/bin/sh'
+ if [[ -n ${libdir} ]] ; then
+ local var
+ if [[ ${CHOST} == *-darwin* ]] ; then
+ var=DYLD_LIBRARY_PATH
+ else
+ var=LD_LIBRARY_PATH
+ fi
+ cat <<-EOF
+ if [ "\${${var}+set}" = "set" ] ; then
+ export ${var}="\${${var}}:${EPREFIX}${libdir}"
+ else
+ export ${var}="${EPREFIX}${libdir}"
+ fi
+ EOF
+ fi
+ [[ -n ${chdir} ]] && printf 'cd "%s" &&\n' "${EPREFIX}${chdir}"
+ # We don't want to quote ${bin} so that people can pass complex
+ # things as ${bin} ... "./someprog --args"
+ printf 'exec %s "$@"\n' "${bin/#\//${EPREFIX}/}"
+ ) > "${tmpwrapper}"
+ chmod go+rx "${tmpwrapper}"
+
+ if [[ -n ${path} ]] ; then
+ (
+ exeopts -m 0755
+ exeinto "${path}"
+ newexe "${tmpwrapper}" "${wrapper}"
+ ) || die
+ else
+ newbin "${tmpwrapper}" "${wrapper}"
[gentoo-dev] [PATCH 2/8] edos2unix.eclass: New eclass, split off from eutils.
Signed-off-by: Ulrich Müller
---
eclass/edos2unix.eclass | 21 +
eclass/eutils.eclass| 18 +++---
2 files changed, 24 insertions(+), 15 deletions(-)
create mode 100644 eclass/edos2unix.eclass
diff --git a/eclass/edos2unix.eclass b/eclass/edos2unix.eclass
new file mode 100644
index ..8b774844cb8a
--- /dev/null
+++ b/eclass/edos2unix.eclass
@@ -0,0 +1,21 @@
+# Copyright 1999-2020 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+# @ECLASS: edos2unix.eclass
+# @MAINTAINER:
+# base-sys...@gentoo.org
+# @BLURB: convert files from DOS CRLF to UNIX LF line endings
+
+# @FUNCTION: edos2unix
+# @USAGE: [more files ...]
+# @DESCRIPTION:
+# A handy replacement for dos2unix, recode, fixdos, etc... This allows
+# you to remove all of these text utilities from DEPEND variables
+# because this is a script based solution. Just give it a list of files
+# to convert and they will all be changed from the DOS CRLF format to
+# the UNIX LF format.
+
+edos2unix() {
+ [[ $# -eq 0 ]] && return 0
+ sed -i 's/\r$//' -- "$@" || die
+}
diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
index f74074fb4f16..3b3e328ba30d 100644
--- a/eclass/eutils.eclass
+++ b/eclass/eutils.eclass
@@ -21,10 +21,10 @@ _EUTILS_ECLASS=1
# implicitly inherited (now split) eclasses
case ${EAPI:-0} in
0|1|2|3|4|5|6)
- inherit desktop epatch estack ltprune multilib preserve-libs \
- toolchain-funcs vcs-clean
+ inherit desktop edos2unix epatch estack ltprune multilib \
+ preserve-libs toolchain-funcs vcs-clean
;;
- 7) ;;
+ 7) inherit edos2unix ;;
*) die "${ECLASS} is banned in EAPI ${EAPI}" ;;
esac
@@ -63,18 +63,6 @@ emktemp() {
fi
}
-# @FUNCTION: edos2unix
-# @USAGE: [more files ...]
-# @DESCRIPTION:
-# A handy replacement for dos2unix, recode, fixdos, etc... This allows you
-# to remove all of these text utilities from DEPEND variables because this
-# is a script based solution. Just give it a list of files to convert and
-# they will all be changed from the DOS CRLF format to the UNIX LF format.
-edos2unix() {
- [[ $# -eq 0 ]] && return 0
- sed -i 's/\r$//' -- "$@" || die
-}
-
# @FUNCTION: strip-linguas
# @USAGE: [|<-i|-u> ]
# @DESCRIPTION:
--
2.28.0
[gentoo-dev] [PATCH 0/8] Split off remaining functions from eutils.eclass
In the old times, eutils.eclass used to be inherited by almost all
ebuilds, mainly for the epatch function. Today, this is often no
longer needed since the package manager provides eapply() in EAPI 6
and later.
So, with introduction of EAPI 7, we had already moved most of the
functions in eutils.eclass to more specific eclasses. The hope back
then was that usage of eutils would further dwindle, and that the
eclass might be kept as a collection of small tools that don't fit
anywhere else.
Looking at the numbers today, I find these numbers of ebuilds
inheriting eutils.eclass:
37.6 % (3765 of 10013) in EAPI 6
38.3 % (6334 of 16546) in EAPI 7
Which means that there is no visible reduction. Even worse, of the
6334 ebuilds inheriting eutils in EAPI 7, only 140 actually call any
of its remaining functions.
Presumably many of the above inherits are caused by eutils being
indirectly inherited from other eclasses. Which means that ebuild
maintainers don't have any incentive to act (after all, their ebuilds
_don't_ inherit eutils). OTOH, eclass maintainers don't dare to remove
the eutils inherit, because it could potentially break ebuilds that
rely on indirect inheritance.
I think the only way to get out of this is to phase out eutils.eclass
entirely, by moving its remaining functions to other eclasses, or
deprecate them, as follows:
edos2unix: split out to new edos2unix.eclass
make_wrapper: split out to new wrapper.eclass
strip-linguas: move to l10n.eclass
emktemp: deprecate (create file in ${T} instead)
use_in_iuse: deprecate (only used in eclasses, where it can be inlined)
Please review the following series of patches.
(Note that this is to be applied on top of soap's optfeature patch:
https://github.com/gentoo/gentoo/pull/17452)
Ulrich Müller (8):
eutils.eclass: Specify supported EAPIs.
edos2unix.eclass: New eclass, split off from eutils.
wrapper.eclass: New eclass, split off from eutils.
wrapper.eclass: Do not use emktemp.
l10n.eclass: Add conditional to prevent multiple inclusion.
l10n.eclass: strip-linguas() moved from eutils to here.
eutils.eclass: Deprecate emktemp().
eutils.eclass: Deprecate use_if_iuse().
eclass/chromium-2.eclass | 4 +-
eclass/edos2unix.eclass | 21 +++
eclass/eutils.eclass | 128 +--
eclass/gnome2.eclass | 2 +-
eclass/l10n.eclass | 54 -
eclass/mate.eclass | 4 +-
eclass/toolchain.eclass | 77 ---
eclass/wrapper.eclass| 59 ++
8 files changed, 195 insertions(+), 154 deletions(-)
create mode 100644 eclass/edos2unix.eclass
create mode 100644 eclass/wrapper.eclass
--
2.28.0
Re: [gentoo-dev] [PATCH] profiles/targets/desktop: Do not enable ldap USE flag by default
On Thu, Sep 10, 2020 at 8:13 AM Michał Górny wrote: > On Thu, 2020-09-10 at 07:35 +0200, Hans de Graaff wrote: > > On Wed, 2020-09-09 at 13:35 +0300, Mikle Kolyada wrote: > > > Closes: https://bugs.gentoo.org/741380 > > > > Could you provide a rationale for removing this? The bug only has a > > single anecdotal report of a user who can run a desktop without it. I'm > > not sure if that is reason enough to remove this. I guess we won't be > > able to figure out easily how many of our desktop profile users are > > actually using LDAP, but changing this may cause surprises and I'm not > > sure if that's warranted. > > > > 2020. Gentoo discovers that people usually don't run LDAP on their > desktops. Some developers can't believe their eyes! Gentoo forms > a Working Group to establish whether using LDAP on desktops is really > that uncommon. > > This fits nicely with the recently announced fact that Gentoo Foundation > has too much money and is looking for funding requests. After all, what > could be a better use of Gentoo money than funding the work of a Working > Group trying to establish matters of such great importance as default > USE flags on desktop profiles. > I don't appreciate these comments. You can think the Foundation wastes money on taxes and paperwork and operational expenses but i'm not going to sit here and watch you crap all over my attempts to actually *support* the Gentoo community by funding actual work. So please keep your negative comments to yourself. -A > > After a lot of debate the Working Group concludes that there is no > conclusive answer whether LDAP should be enabled by default or not. > > -- > Best regards, > Michał Górny > >
Re: [gentoo-dev] [PATCH] profiles/targets/desktop: Do not enable ldap USE flag by default
On Thu, Sep 10, 2020 at 11:45 AM Alec Warner wrote: > > On Thu, Sep 10, 2020 at 1:59 AM Mikle Kolyada wrote: >> >> >> On 10.09.2020 08:35, Hans de Graaff wrote: >> > On Wed, 2020-09-09 at 13:35 +0300, Mikle Kolyada wrote: >> >> Closes: https://bugs.gentoo.org/741380 >> > Could you provide a rationale for removing this? The bug only has a >> > single anecdotal report of a user who can run a desktop without it. I'm >> > not sure if that is reason enough to remove this. I guess we won't be >> > able to figure out easily how many of our desktop profile users are >> > actually using LDAP, but changing this may cause surprises and I'm not >> > sure if that's warranted. >> > >> > Hans >> >> >> Hi. >> >> It is dictated by common sense. >> >> >> I barely can imagine a case where you need ldap support in each and >> every package you install. > > > I can, but not in a desktop environment. In an enterprise environment you > will need it (but I'd expect folks to add it.) > The challenge is just in changing the default. E.g. we might not do it until > a new profile bump (e.g. do it in a 2020 or 2021 profile?) I think a news item with some time delay would be sufficient to inform any enterprise admins so they can push a local config change.
Re: [gentoo-dev] [PATCH] profiles/targets/desktop: Do not enable ldap USE flag by default
On Thu, Sep 10, 2020 at 1:59 AM Mikle Kolyada wrote: > > On 10.09.2020 08:35, Hans de Graaff wrote: > > On Wed, 2020-09-09 at 13:35 +0300, Mikle Kolyada wrote: > >> Closes: https://bugs.gentoo.org/741380 > > Could you provide a rationale for removing this? The bug only has a > > single anecdotal report of a user who can run a desktop without it. I'm > > not sure if that is reason enough to remove this. I guess we won't be > > able to figure out easily how many of our desktop profile users are > > actually using LDAP, but changing this may cause surprises and I'm not > > sure if that's warranted. > > > > Hans > > > Hi. > > It is dictated by common sense. > > I barely can imagine a case where you need ldap support in each and > every package you install. > I can, but not in a desktop environment. In an enterprise environment you will need it (but I'd expect folks to add it.) The challenge is just in changing the default. E.g. we might not do it until a new profile bump (e.g. do it in a 2020 or 2021 profile?) -A > > This should rather be per-package enabled as something non-trivial. > > >
Re: [gentoo-dev] [PATCH] profiles/targets/desktop: Do not enable ldap USE flag by default
On Thu, 2020-09-10 at 07:35 +0200, Hans de Graaff wrote: > On Wed, 2020-09-09 at 13:35 +0300, Mikle Kolyada wrote: > > Closes: https://bugs.gentoo.org/741380 > > Could you provide a rationale for removing this? The bug only has a > single anecdotal report of a user who can run a desktop without it. I'm > not sure if that is reason enough to remove this. I guess we won't be > able to figure out easily how many of our desktop profile users are > actually using LDAP, but changing this may cause surprises and I'm not > sure if that's warranted. > 2020. Gentoo discovers that people usually don't run LDAP on their desktops. Some developers can't believe their eyes! Gentoo forms a Working Group to establish whether using LDAP on desktops is really that uncommon. This fits nicely with the recently announced fact that Gentoo Foundation has too much money and is looking for funding requests. After all, what could be a better use of Gentoo money than funding the work of a Working Group trying to establish matters of such great importance as default USE flags on desktop profiles. After a lot of debate the Working Group concludes that there is no conclusive answer whether LDAP should be enabled by default or not. -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part
Re: [gentoo-dev] [PATCH] profiles/targets/desktop: Do not enable ldap USE flag by default
On Thu, Sep 10, 2020 at 11:59:31AM +0300, Mikle Kolyada wrote: > > On 10.09.2020 08:35, Hans de Graaff wrote: > > On Wed, 2020-09-09 at 13:35 +0300, Mikle Kolyada wrote: > >> Closes: https://bugs.gentoo.org/741380 > > Could you provide a rationale for removing this? The bug only has a > > single anecdotal report of a user who can run a desktop without it. I'm > > not sure if that is reason enough to remove this. I guess we won't be > > able to figure out easily how many of our desktop profile users are > > actually using LDAP, but changing this may cause surprises and I'm not > > sure if that's warranted. > > > > Hans > > > Hi. > > It is dictated by common sense. > > I barely can imagine a case where you need ldap support in each and > every package you install. > > This should rather be per-package enabled as something non-trivial. Maybe this change should be introduced with a news item just to help limit surprises? signature.asc Description: PGP signature
Re: [gentoo-dev] [PATCH] profiles/targets/desktop: Do not enable ldap USE flag by default
On 10.09.2020 08:35, Hans de Graaff wrote: On Wed, 2020-09-09 at 13:35 +0300, Mikle Kolyada wrote: Closes: https://bugs.gentoo.org/741380 Could you provide a rationale for removing this? The bug only has a single anecdotal report of a user who can run a desktop without it. I'm not sure if that is reason enough to remove this. I guess we won't be able to figure out easily how many of our desktop profile users are actually using LDAP, but changing this may cause surprises and I'm not sure if that's warranted. Hans Hi. It is dictated by common sense. I barely can imagine a case where you need ldap support in each and every package you install. This should rather be per-package enabled as something non-trivial.
