Re: [gentoo-dev] Re: [PATCH 0/2] go-module.eclass cleanups

2021-05-25 Thread William Hubbs
On Tue, May 25, 2021 at 11:31:17AM -0700, Zac Medico wrote:
> On 5/21/21 8:45 AM, William Hubbs wrote:
> > This is an improvement to my previous patch. It is a patch series now
> > because there are two separate changes:
> > 
> > - GOPROXY is exported in go-module_set_globals since it is not needed if
> >   EGO_SUM is not set in the ebuild.
> > 
> > - go-module_setup_proxy is added. This function sets up the go proxy
> >   directory so that dependencies can be read from it.
> > 
> > William Hubbs (2):
> >   go-module.eclass: fix GOPROXY export
> >   go-module.eclass: add go-module_setup_proxy function
> > 
> >  eclass/go-module.eclass | 47 +++--
> >  1 file changed, 45 insertions(+), 2 deletions(-)
> > 
> 
> This series looks great to me! Thank you!

This series is committed.

Thanks,

William


signature.asc
Description: PGP signature


[gentoo-dev] Re: [PATCH 0/2] go-module.eclass cleanups

2021-05-25 Thread Zac Medico
On 5/21/21 8:45 AM, William Hubbs wrote:
> This is an improvement to my previous patch. It is a patch series now
> because there are two separate changes:
> 
> - GOPROXY is exported in go-module_set_globals since it is not needed if
>   EGO_SUM is not set in the ebuild.
> 
> - go-module_setup_proxy is added. This function sets up the go proxy
>   directory so that dependencies can be read from it.
> 
> William Hubbs (2):
>   go-module.eclass: fix GOPROXY export
>   go-module.eclass: add go-module_setup_proxy function
> 
>  eclass/go-module.eclass | 47 +++--
>  1 file changed, 45 insertions(+), 2 deletions(-)
> 

This series looks great to me! Thank you!
-- 
Thanks,
Zac



signature.asc
Description: OpenPGP digital signature