Re: [gentoo-dev] [PATCH 01/12] toolchain.eclass: remove EAPI 5 and 6

2022-02-01 Thread Andreas K. Huettel
> Dilfridge had a proposal to ensure 3/6/12 month old systems could still
> upgrade, and I'm wondering if this could break those systems.
> 
> There are 3 commits in the last year that finally removed the EAPI 5/6
> toolchain consumers:
> 486b77ab8d28c5bfd5a4bdfc5f9a5f432ffde563
> b0a39e54065f7eda2dfc719ec05e270fa7e23e38
> 26f684adecb5b9135f9eba9f1b63c83e3d5e5722
> 
> The latest of those was in September 2021.
> 
> Do we need to wait X months after those removals, to be able to commit
> this change?

Hmm. Portage saves and reuses the ebuild environment, so each installed 
package has its phases and related eclass code stored.

Which means this is probably fine, since
1) after syncing, the ebuilds are gone, so you'll never be able to rebuild
the consumer
2) and unmerging the consumer is done using the saved environment.

More opinions welcome...

-- 
Andreas K. Hüttel
dilfri...@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)

signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] [PATCH 01/12] toolchain.eclass: remove EAPI 5 and 6

2022-02-01 Thread Robin H. Johnson
At a technical level, it looks fine.

But I want to clarify interaction for old systems.

Dilfridge had a proposal to ensure 3/6/12 month old systems could still
upgrade, and I'm wondering if this could break those systems.

There are 3 commits in the last year that finally removed the EAPI 5/6
toolchain consumers:
486b77ab8d28c5bfd5a4bdfc5f9a5f432ffde563
b0a39e54065f7eda2dfc719ec05e270fa7e23e38
26f684adecb5b9135f9eba9f1b63c83e3d5e5722

The latest of those was in September 2021.

Do we need to wait X months after those removals, to be able to commit
this change?

-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
E-Mail   : robb...@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136


signature.asc
Description: PGP signature


Re: [gentoo-dev] [PATCH 5/6] distutils-r1.eclass: Add DISTUTILS_DEPS output var for PEP 517 mode

2022-02-01 Thread Michał Górny
On Mon, 2022-01-31 at 23:06 +, Sam James wrote:
> 
> > On 31 Jan 2022, at 22:59, Michał Górny  wrote:
> > 
> > The PEP 517 build-time deps have gotten more complex, and largely depend
> > on the internal eclass logic used to build and install wheels.
> > Introduce a DISTUTILS_DEPS output variable that contains the correct
> > BDEPEND string for use in DISTUTILS_OPTIONAL=1 ebuilds.
> > 
> > Signed-off-by: Michał Górny 
> > ---
> 
> All LGTM (checked when on GH), but add bug ref to this commit:
> https://bugs.gentoo.org/832337 .
> 

Done.

-- 
Best regards,
Michał Górny