Re: [gentoo-dev] [PATCH v2] verify-sig.eclass: avoid calling unpack on sig files

[Ulrich Mueller]

> On Wed, 22 May 2024, Mike Gilbert wrote:

> Signed-off-by: Mike Gilbert 
> ---
>  eclass/verify-sig.eclass | 10 +++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

> diff --git a/eclass/verify-sig.eclass b/eclass/verify-sig.eclass
> index b74ed78290aa..4d48c9ed8503 100644
> --- a/eclass/verify-sig.eclass
> +++ b/eclass/verify-sig.eclass
> @@ -426,10 +426,14 @@ verify-sig_src_unpack() {
>   verify-sig_verify_detached \
>   "${DISTDIR}/${f%.*}" "${DISTDIR}/${f}"
>   done
> - fi
 
> - # finally, unpack the distfiles
> - default_src_unpack
> + # finally, unpack the distfiles
> + if [[ ${#distfiles[@]} -gt 0 ]]; then
> + unpack "${distfiles[@]}"
> + fi
> + else
> + default_src_unpack
> + fi
>  }
 
>  fi

Please provide an explanation what problem this patch fixes.

Why is calling unpack on sig files bad? It should silently skip files
with unknown extensions.

Ulrich


signature.asc
Description: PGP signature

Re: [gentoo-dev] [PATCH v2] verify-sig.eclass: avoid calling unpack on sig files

[Michał Górny]

On Tue, 2024-05-21 at 22:05 -0400, Mike Gilbert wrote:
> Signed-off-by: Mike Gilbert 
> ---
>  eclass/verify-sig.eclass | 10 +++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/eclass/verify-sig.eclass b/eclass/verify-sig.eclass
> index b74ed78290aa..4d48c9ed8503 100644
> --- a/eclass/verify-sig.eclass
> +++ b/eclass/verify-sig.eclass
> @@ -426,10 +426,14 @@ verify-sig_src_unpack() {
>   verify-sig_verify_detached \
>   "${DISTDIR}/${f%.*}" "${DISTDIR}/${f}"
>   done
> - fi
>  
> - # finally, unpack the distfiles
> - default_src_unpack
> + # finally, unpack the distfiles
> + if [[ ${#distfiles[@]} -gt 0 ]]; then
> + unpack "${distfiles[@]}"
> + fi
> + else
> + default_src_unpack
> + fi
>  }
>  
>  fi

Please make a pull request or send a patch with more context.
As submitted, this patch is completely unreadable.

-- 
Best regards,
Michał Górny



signature.asc
Description: This is a digitally signed message part

[gentoo-dev] [PATCH v2] verify-sig.eclass: avoid calling unpack on sig files

[Mike Gilbert]

Signed-off-by: Mike Gilbert 
---
 eclass/verify-sig.eclass | 10 +++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/eclass/verify-sig.eclass b/eclass/verify-sig.eclass
index b74ed78290aa..4d48c9ed8503 100644
--- a/eclass/verify-sig.eclass
+++ b/eclass/verify-sig.eclass
@@ -426,10 +426,14 @@ verify-sig_src_unpack() {
verify-sig_verify_detached \
"${DISTDIR}/${f%.*}" "${DISTDIR}/${f}"
done
-   fi
 
-   # finally, unpack the distfiles
-   default_src_unpack
+   # finally, unpack the distfiles
+   if [[ ${#distfiles[@]} -gt 0 ]]; then
+   unpack "${distfiles[@]}"
+   fi
+   else
+   default_src_unpack
+   fi
 }
 
 fi
-- 
2.45.1

[gentoo-dev] [PATCH] verify-sig.eclass: avoid calling unpack on sig files

[Mike Gilbert]

Signed-off-by: Mike Gilbert 
---
 eclass/verify-sig.eclass | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/eclass/verify-sig.eclass b/eclass/verify-sig.eclass
index b74ed78290aa..b0f180fdb3ac 100644
--- a/eclass/verify-sig.eclass
+++ b/eclass/verify-sig.eclass
@@ -429,7 +429,9 @@ verify-sig_src_unpack() {
fi
 
# finally, unpack the distfiles
-   default_src_unpack
+   if [[ ${#distfiles[@]} -gt 0 ]]; then
+   unpack "${distfiles[@]}"
+   fi
 }
 
 fi
-- 
2.45.1

Re: [gentoo-dev] Files for doc building

[Eli Schwartz]

On 5/21/24 4:10 PM, Henri Gasc wrote:
> Hello,
> 
> I am in the process of updating dev-python/mkdocs-rss-plugin (in GURU),
> and I find myself in a pinch.
> To build the documentation, there are 74 files needed. It's too much to
> add them to the SRC_URI and copy the files in src_prepare, but at the
> same time, the best compression achieved on a tar archive is 3.3M and I
> worry about putting it in a files directory.
> 
> Does anyone has an idea on how to solve this ? I would prefer not to
> create a git repo and add it from there.
> Regards,
> Henri Gasc


It is even a violation of Gentoo policy to have files larger than IIRC
20kb in files/.

This *must* be handled via SRC_URI, where to host the tarball is up to
the maintainer.

-- 
Eli Schwartz


OpenPGP_0x84818A6819AF4A9B.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature

[gentoo-dev] Files for doc building

[Henri Gasc]

Hello,

I am in the process of updating dev-python/mkdocs-rss-plugin (in GURU), 
and I find myself in a pinch.
To build the documentation, there are 74 files needed. It's too much to 
add them to the SRC_URI and copy the files in src_prepare, but at the 
same time, the best compression achieved on a tar archive is 3.3M and I 
worry about putting it in a files directory.


Does anyone has an idea on how to solve this ? I would prefer not to 
create a git repo and add it from there.

Regards,
Henri Gasc