Re: [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command.

[Michał Górny]

W dniu wto, 06.02.2018 o godzinie 09∶07 -0800, użytkownik Alec Warner
napisał:
> On Tue, Feb 6, 2018 at 6:12 AM, Kristian Fiskerstrand 
> wrote:
> 
> > On 02/06/2018 02:57 PM, Ulrich Müller wrote:
> > > Fixes: https://bugs.gentoo.org/446422
> > 
> > Bug or Closes, Fixes would be referencing a commit-id c.f GLEP 66.
> > 
> > More generally though, should we start requiring more verbose commit
> > messages for eclasses to make it easier to trace changes in our git repo
> > directly without reaching out to bugs? At least including summaries of
> > the respective bugs as a short description?
> > 
> 
> Nope, people can go read the bug.
> 

That's very nice of you. I do really enjoy when I have a log of like 30
different commits that might be relevant and whose descriptions boil
down to 'go see 30 bugs, and hope you won't have to read all comments'.

-- 
Best regards,
Michał Górny

Re: [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command.

[Alec Warner]

On Tue, Feb 6, 2018 at 6:12 AM, Kristian Fiskerstrand 
wrote:

> On 02/06/2018 02:57 PM, Ulrich Müller wrote:
> > Fixes: https://bugs.gentoo.org/446422
>
> Bug or Closes, Fixes would be referencing a commit-id c.f GLEP 66.
>
> More generally though, should we start requiring more verbose commit
> messages for eclasses to make it easier to trace changes in our git repo
> directly without reaching out to bugs? At least including summaries of
> the respective bugs as a short description?
>

Nope, people can go read the bug.

-A


>
> --
> Kristian Fiskerstrand
> OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net
> fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3
>
>

eclass committ message verbosity (Was: Re: [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command.)

[Kristian Fiskerstrand]

On 02/06/2018 03:36 PM, Ulrich Mueller wrote:
>> On Tue, 6 Feb 2018, Kristian Fiskerstrand wrote:


>> More generally though, should we start requiring more verbose commit
>> messages for eclasses to make it easier to trace changes in our git
>> repo directly without reaching out to bugs? At least including
>> summaries of the respective bugs as a short description?
> 
> In the concrete example, the bug's summary is "bzr.eclass might need
> to use bzr pull's --overwrite-tags flag" which is not much different
> from the git commit message.

Right, this specific commit likely has little more to gain given the
summary line. But could easily benefit from some text in body still :)

But I generally think we can benefit from some more verbosity in our
commit messages, in particular for eclasses.

-- 
Kristian Fiskerstrand
OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net
fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3



signature.asc
Description: OpenPGP digital signature

Re: [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command.

[Ulrich Mueller]

> On Tue, 6 Feb 2018, Kristian Fiskerstrand wrote:

>> Fixes: https://bugs.gentoo.org/446422

> Bug or Closes, Fixes would be referencing a commit-id c.f GLEP 66.

Updated, thanks for catching this.

> More generally though, should we start requiring more verbose commit
> messages for eclasses to make it easier to trace changes in our git
> repo directly without reaching out to bugs? At least including
> summaries of the respective bugs as a short description?

In the concrete example, the bug's summary is "bzr.eclass might need
to use bzr pull's --overwrite-tags flag" which is not much different
from the git commit message.

Ulrich


pgpnLlL3h5eAR.pgp
Description: PGP signature

Re: [gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command.

[Kristian Fiskerstrand]

On 02/06/2018 02:57 PM, Ulrich Müller wrote:
> Fixes: https://bugs.gentoo.org/446422

Bug or Closes, Fixes would be referencing a commit-id c.f GLEP 66.

More generally though, should we start requiring more verbose commit
messages for eclasses to make it easier to trace changes in our git repo
directly without reaching out to bugs? At least including summaries of
the respective bugs as a short description?

-- 
Kristian Fiskerstrand
OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net
fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3



signature.asc
Description: OpenPGP digital signature

[gentoo-dev] [PATCH] bzr.eclass: Add --overwrite-tags option to pull command.

[Ulrich Müller]

Fixes: https://bugs.gentoo.org/446422
---
 eclass/bzr.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/eclass/bzr.eclass b/eclass/bzr.eclass
index ef1b47936867..792cc3bec36f 100644
--- a/eclass/bzr.eclass
+++ b/eclass/bzr.eclass
@@ -27,7 +27,7 @@ case "${EAPI:-0}" in
*)   EXPORT_FUNCTIONS src_unpack src_prepare ;;
 esac
 
-DEPEND=">=dev-vcs/bzr-2.0.1"
+DEPEND=">=dev-vcs/bzr-2.6.0"
 case "${EAPI:-0}" in
0|1) ;;
*) [[ ${EBZR_REPO_URI%%:*} = sftp ]] \
@@ -57,7 +57,7 @@ esac
 # @ECLASS-VARIABLE: EBZR_UPDATE_CMD
 # @DESCRIPTION:
 # The Bazaar command to update the sources.
-: ${EBZR_UPDATE_CMD:="bzr pull"}
+: ${EBZR_UPDATE_CMD:="bzr pull --overwrite-tags"}
 
 # @ECLASS-VARIABLE: EBZR_EXPORT_CMD
 # @DESCRIPTION:
-- 
2.16.1


pgpfAcAI_ChjH.pgp
Description: PGP signature