Re: [gentoo-dev] [PATCH] cmake.eclass: Remove duplicate eninja call from cmake_build

2023-08-23 Thread Matt Turner 
On Wed, Aug 23, 2023 at 2:51 AM Michał Górny  wrote:
>
> Signed-off-by: Michał Górny 
> ---
>  eclass/cmake.eclass | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
> index fb3f9b6352be..d0f6d0b4bd91 100644
> --- a/eclass/cmake.eclass
> +++ b/eclass/cmake.eclass
> @@ -661,7 +661,6 @@ cmake_build() {
> OFF) NINJA_VERBOSE=OFF eninja "$@" ;;
> *) eninja "$@" ;;
> esac
> -   eninja "$@"
> ;;
> esac
>
> --
> 2.42.0

Oops. Thanks. Looks good to me.

Re: [gentoo-dev] [PATCH] cmake.eclass: Remove duplicate eninja call from cmake_build

2023-08-23 Thread Sam James 


Michał Górny  writes:

> Signed-off-by: Michał Górny 
> ---
>  eclass/cmake.eclass | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
> index fb3f9b6352be..d0f6d0b4bd91 100644
> --- a/eclass/cmake.eclass
> +++ b/eclass/cmake.eclass
> @@ -661,7 +661,6 @@ cmake_build() {
>   OFF) NINJA_VERBOSE=OFF eninja "$@" ;;
>   *) eninja "$@" ;;
>   esac
> - eninja "$@"
>   ;;
>   esac

Maybe add a `Fixes: ...`, but lgtm, thanks.

[gentoo-dev] [PATCH] cmake.eclass: Remove duplicate eninja call from cmake_build

2023-08-23 Thread Michał Górny 
Signed-off-by: Michał Górny 
---
 eclass/cmake.eclass | 1 -
 1 file changed, 1 deletion(-)

diff --git a/eclass/cmake.eclass b/eclass/cmake.eclass
index fb3f9b6352be..d0f6d0b4bd91 100644
--- a/eclass/cmake.eclass
+++ b/eclass/cmake.eclass
@@ -661,7 +661,6 @@ cmake_build() {
OFF) NINJA_VERBOSE=OFF eninja "$@" ;;
*) eninja "$@" ;;
esac
-   eninja "$@"
;;
esac
 
-- 
2.42.0