Re: [gentoo-dev] [PATCH] meson.eclass: add meson_feature function

2019-03-11 Thread William Hubbs
On Mon, Mar 04, 2019 at 10:38:02AM +0200, Mart Raudsepp wrote:
> This can be used to simplify controlling meson_options.txt entries
> of type 'feature'.

I responded on irc a few days ago, but I'll go ahead and respond here.
This looks good to me.

Thanks,

William


signature.asc
Description: Digital signature


[gentoo-dev] [PATCH] meson.eclass: add meson_feature function

2019-03-04 Thread Mart Raudsepp
This can be used to simplify controlling meson_options.txt entries
of type 'feature'.

Signed-off-by: Mart Raudsepp 
---
 eclass/meson.eclass | 13 +
 1 file changed, 13 insertions(+)

diff --git a/eclass/meson.eclass b/eclass/meson.eclass
index 75291d7bdd1..65b09932a7a 100644
--- a/eclass/meson.eclass
+++ b/eclass/meson.eclass
@@ -188,6 +188,19 @@ meson_use() {
usex "$1" "-D${2-$1}=true" "-D${2-$1}=false"
 }
 
+# @FUNCTION: meson_feature
+# @USAGE:  [option name]
+# @DESCRIPTION:
+# Given a USE flag and meson project option, outputs a string like:
+#
+#   -Doption=enabled
+#   -Doption=disabled
+#
+# If the project option is unspecified, it defaults to the USE flag.
+meson_feature() {
+   usex "$1" "-D${2-$1}=enabled" "-D${2-$1}=disabled"
+}
+
 # @FUNCTION: meson_src_configure
 # @USAGE: [extra meson arguments]
 # @DESCRIPTION: