Re: [gentoo-dev] [PATCH] sys-libs/ncurses: Use --cache-file to speedup subsequent econf runs

2017-03-25 Thread Jeroen Roovers 
On Tue, 21 Mar 2017 19:33:46 +0100
Michał Górny  wrote:

> If you really believe users should suffer a 30-minute rebuild for
> a build-time fix, sure.

Your statement implies that indiscriminately using the unstable branch
shouldn't involve unnecessary suffering, whereas I thought suffering is
the sole purpose of indiscriminately using the unstable branch.


Kind regards,
 jer

Re: [gentoo-dev] [PATCH] sys-libs/ncurses: Use --cache-file to speedup subsequent econf runs

2017-03-21 Thread Kristian Fiskerstrand 
On 03/21/2017 07:33 PM, Michał Górny wrote:

>>
>>
>> yes you're right, but that still doesn't justify pushing straight to
>> stable for a package in @system
>> (the same applies to the other patches)
> 
> If you really believe users should suffer a 30-minute rebuild for
> a build-time fix, sure.
> 

sounds like the prudent thing to do to let it live a while in ~arch a
while still.

-- 
Kristian Fiskerstrand
OpenPGP keyblock reachable at hkp://pool.sks-keyservers.net
fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3



signature.asc
Description: OpenPGP digital signature

Re: [gentoo-dev] [PATCH] sys-libs/ncurses: Use --cache-file to speedup subsequent econf runs

2017-03-21 Thread Alexis Ballier 
On Tue, 21 Mar 2017 19:33:46 +0100
Michał Górny  wrote:

> On wto, 2017-03-21 at 17:55 +0100, Alexis Ballier wrote:
> > On Tue, 21 Mar 2017 17:30:29 +0100
> > Michał Górny  wrote:
> >   
> > > On wto, 2017-03-21 at 17:05 +0100, Alexis Ballier wrote:  
> > > > On Tue, 21 Mar 2017 16:46:43 +0100
> > > > Michał Górny  wrote:
> > > > 
> > > > > Use --cache-file to reuse the previous check results in the
> > > > > subsequent configure script runs. This gives a major speed
> > > > > advantage (beating the previous parallel runs) and significant
> > > > > CPU savings.
> > > > 
> > > > Just in case (didn't try nor do I know the reasons of this),
> > > > but I think this change deserves a round in ~arch:
> > > > https://bugs.gentoo.org/show_bug.cgi?id=162875
> > > 
> > > confcache is a completely different business. The problem with
> > > confcache is that it uses persistent, global cache for lots of
> > > packages, which can easily get stale or provide corrupted data.
> > > Using local cache is usually safe (except for very broken
> > > packages).  
> > 
> > 
> > yes you're right, but that still doesn't justify pushing straight to
> > stable for a package in @system
> > (the same applies to the other patches)  
> 
> If you really believe users should suffer a 30-minute rebuild for
> a build-time fix, sure.


that's the term 'fix' or the cache giving exactly the same results
which i'm unsure about

Re: [gentoo-dev] [PATCH] sys-libs/ncurses: Use --cache-file to speedup subsequent econf runs

2017-03-21 Thread Michał Górny 
On wto, 2017-03-21 at 17:55 +0100, Alexis Ballier wrote:
> On Tue, 21 Mar 2017 17:30:29 +0100
> Michał Górny  wrote:
> 
> > On wto, 2017-03-21 at 17:05 +0100, Alexis Ballier wrote:
> > > On Tue, 21 Mar 2017 16:46:43 +0100
> > > Michał Górny  wrote:
> > >   
> > > > Use --cache-file to reuse the previous check results in the
> > > > subsequent configure script runs. This gives a major speed
> > > > advantage (beating the previous parallel runs) and significant
> > > > CPU savings.  
> > > 
> > > Just in case (didn't try nor do I know the reasons of this), but I
> > > think this change deserves a round in ~arch:
> > > https://bugs.gentoo.org/show_bug.cgi?id=162875  
> > 
> > confcache is a completely different business. The problem with
> > confcache is that it uses persistent, global cache for lots of
> > packages, which can easily get stale or provide corrupted data. Using
> > local cache is usually safe (except for very broken packages).
> 
> 
> yes you're right, but that still doesn't justify pushing straight to
> stable for a package in @system
> (the same applies to the other patches)

If you really believe users should suffer a 30-minute rebuild for
a build-time fix, sure.

-- 
Best regards,
Michał Górny


signature.asc
Description: This is a digitally signed message part

Re: [gentoo-dev] [PATCH] sys-libs/ncurses: Use --cache-file to speedup subsequent econf runs

2017-03-21 Thread Alexis Ballier 
On Tue, 21 Mar 2017 17:30:29 +0100
Michał Górny  wrote:

> On wto, 2017-03-21 at 17:05 +0100, Alexis Ballier wrote:
> > On Tue, 21 Mar 2017 16:46:43 +0100
> > Michał Górny  wrote:
> >   
> > > Use --cache-file to reuse the previous check results in the
> > > subsequent configure script runs. This gives a major speed
> > > advantage (beating the previous parallel runs) and significant
> > > CPU savings.  
> > 
> > Just in case (didn't try nor do I know the reasons of this), but I
> > think this change deserves a round in ~arch:
> > https://bugs.gentoo.org/show_bug.cgi?id=162875  
> 
> confcache is a completely different business. The problem with
> confcache is that it uses persistent, global cache for lots of
> packages, which can easily get stale or provide corrupted data. Using
> local cache is usually safe (except for very broken packages).


yes you're right, but that still doesn't justify pushing straight to
stable for a package in @system
(the same applies to the other patches)

Re: [gentoo-dev] [PATCH] sys-libs/ncurses: Use --cache-file to speedup subsequent econf runs

2017-03-21 Thread Michał Górny 
On wto, 2017-03-21 at 17:05 +0100, Alexis Ballier wrote:
> On Tue, 21 Mar 2017 16:46:43 +0100
> Michał Górny  wrote:
> 
> > Use --cache-file to reuse the previous check results in the subsequent
> > configure script runs. This gives a major speed advantage (beating the
> > previous parallel runs) and significant CPU savings.
> 
> Just in case (didn't try nor do I know the reasons of this), but I
> think this change deserves a round in ~arch:
> https://bugs.gentoo.org/show_bug.cgi?id=162875

confcache is a completely different business. The problem with confcache
is that it uses persistent, global cache for lots of packages, which can
easily get stale or provide corrupted data. Using local cache is usually
safe (except for very broken packages).

-- 
Best regards,
Michał Górny


signature.asc
Description: This is a digitally signed message part

Re: [gentoo-dev] [PATCH] sys-libs/ncurses: Use --cache-file to speedup subsequent econf runs

2017-03-21 Thread Alexis Ballier 
On Tue, 21 Mar 2017 16:46:43 +0100
Michał Górny  wrote:

> Use --cache-file to reuse the previous check results in the subsequent
> configure script runs. This gives a major speed advantage (beating the
> previous parallel runs) and significant CPU savings.

Just in case (didn't try nor do I know the reasons of this), but I
think this change deserves a round in ~arch:
https://bugs.gentoo.org/show_bug.cgi?id=162875

[gentoo-dev] [PATCH] sys-libs/ncurses: Use --cache-file to speedup subsequent econf runs

2017-03-21 Thread Michał Górny 
Use --cache-file to reuse the previous check results in the subsequent
configure script runs. This gives a major speed advantage (beating the
previous parallel runs) and significant CPU savings.
---
 sys-libs/ncurses/ncurses-6.0-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys-libs/ncurses/ncurses-6.0-r1.ebuild 
b/sys-libs/ncurses/ncurses-6.0-r1.ebuild
index d98b23afb751..283b13aba394 100644
--- a/sys-libs/ncurses/ncurses-6.0-r1.ebuild
+++ b/sys-libs/ncurses/ncurses-6.0-r1.ebuild
@@ -93,7 +93,7 @@ src_configure() {
 multilib_src_configure() {
local t
for t in "${NCURSES_TARGETS[@]}" ; do
-   do_configure "${t}"
+   do_configure "${t}" --cache-file="${BUILD_DIR}"/config.cache
done
 }
 
-- 
2.12.0