Re: [gentoo-dev] [PATCH] unpacker.eclass: Don't assume the default tar is stdin

[Mike Gilbert]

On Thu, Apr 6, 2023 at 11:37 AM Arsen Arsenović  wrote:
>
> Despite common misconception, the default GNU tar tarfile is not stdin.
> On some systems, this can cause tar to fail to extract relevant files.
>
> See '(tar)file tutorial' for a description of how the default is picked.

Looks good to me.

[gentoo-dev] [PATCH] unpacker.eclass: Don't assume the default tar is stdin

[Arsen Arsenović]

Despite common misconception, the default GNU tar tarfile is not stdin.
On some systems, this can cause tar to fail to extract relevant files.

See '(tar)file tutorial' for a description of how the default is picked.

Bug: https://bugs.gentoo.org/903631
Closes: https://bugs.gentoo.org/903914
Closes: https://bugs.gentoo.org/903919

Signed-off-by: Arsen Arsenović 
---
This patch does not close https://bugs.gentoo.org/903631, as I intend to
turn that into a tracker bug.

 eclass/unpacker.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/unpacker.eclass b/eclass/unpacker.eclass
index 650de4bd3f75..652527b52ec6 100644
--- a/eclass/unpacker.eclass
+++ b/eclass/unpacker.eclass
@@ -325,7 +325,7 @@ unpack_deb() {
$(tc-getBUILD_AR) p "${deb}" "${f}" | ${decomp:-cat}
assert "unpacking ${f} from ${deb} failed"
fi
-   } | tar --no-same-owner -x
+   } | tar --no-same-owner -xf -
assert "unpacking ${deb} failed"
 }
 
-- 
2.40.0