Re: [gentoo-dev] [PATCH] unpacker.eclass: enable EAPI 8
On 8/26/21 5:43 PM, Mike Gilbert wrote:
On Thu, Aug 26, 2021 at 7:40 AM Ulrich Mueller wrote:
On Thu, 26 Aug 2021, Stephan Hartmann wrote:
--- a/eclass/unpacker.eclass
+++ b/eclass/unpacker.eclass
@@ -4,7 +4,7 @@
# @ECLASS: unpacker.eclass
# @MAINTAINER:
# base-sys...@gentoo.org
-# @SUPPORTED_EAPIS: 5 6 7
+# @SUPPORTED_EAPIS: 5 6 7 8
# @BLURB: helpers for extraneous file formats and consistent behavior across
EAPIs
# @DESCRIPTION:
# Some extraneous file formats are not part of PMS, or are only in certain
@@ -16,7 +16,7 @@
# - support partial unpacks?
case ${EAPI:-0} in
- [567]) ;;
+ [5678]) ;;
*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
esac
I think for EAPI 8 you'll need additional cases in _unpacker() for
7z, .rar, and .lha/.lzh, because package manager support for these
extensions has been dropped:
https://projects.gentoo.org/pms/8/pms.html#x1-135002r24
That would be a nice enhancement for the eclass, but I don't think it
needs to be implemented before EAPI 8 is allowed. It could wait until
some EAPI 8 ebuild actually needs to unpack one of these obscure
formats.
Almost implemented, just need some runtime testing. Will sent an updated
patch tomorrow.
Re: [gentoo-dev] [PATCH] unpacker.eclass: enable EAPI 8
On Thu, Aug 26, 2021 at 7:40 AM Ulrich Mueller wrote:
>
> > On Thu, 26 Aug 2021, Stephan Hartmann wrote:
>
> > --- a/eclass/unpacker.eclass
> > +++ b/eclass/unpacker.eclass
> > @@ -4,7 +4,7 @@
> > # @ECLASS: unpacker.eclass
> > # @MAINTAINER:
> > # base-sys...@gentoo.org
> > -# @SUPPORTED_EAPIS: 5 6 7
> > +# @SUPPORTED_EAPIS: 5 6 7 8
> > # @BLURB: helpers for extraneous file formats and consistent behavior
> > across EAPIs
> > # @DESCRIPTION:
> > # Some extraneous file formats are not part of PMS, or are only in certain
> > @@ -16,7 +16,7 @@
> > # - support partial unpacks?
> >
> > case ${EAPI:-0} in
> > - [567]) ;;
> > + [5678]) ;;
> > *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
> > esac
> >
>
> I think for EAPI 8 you'll need additional cases in _unpacker() for
> 7z, .rar, and .lha/.lzh, because package manager support for these
> extensions has been dropped:
> https://projects.gentoo.org/pms/8/pms.html#x1-135002r24
That would be a nice enhancement for the eclass, but I don't think it
needs to be implemented before EAPI 8 is allowed. It could wait until
some EAPI 8 ebuild actually needs to unpack one of these obscure
formats.
Re: [gentoo-dev] [PATCH] unpacker.eclass: enable EAPI 8
> On Thu, 26 Aug 2021, Stephan Hartmann wrote:
> --- a/eclass/unpacker.eclass
> +++ b/eclass/unpacker.eclass
> @@ -4,7 +4,7 @@
> # @ECLASS: unpacker.eclass
> # @MAINTAINER:
> # base-sys...@gentoo.org
> -# @SUPPORTED_EAPIS: 5 6 7
> +# @SUPPORTED_EAPIS: 5 6 7 8
> # @BLURB: helpers for extraneous file formats and consistent behavior across
> EAPIs
> # @DESCRIPTION:
> # Some extraneous file formats are not part of PMS, or are only in certain
> @@ -16,7 +16,7 @@
> # - support partial unpacks?
>
> case ${EAPI:-0} in
> - [567]) ;;
> + [5678]) ;;
> *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
> esac
>
I think for EAPI 8 you'll need additional cases in _unpacker() for
7z, .rar, and .lha/.lzh, because package manager support for these
extensions has been dropped:
https://projects.gentoo.org/pms/8/pms.html#x1-135002r24
Ulrich
signature.asc
Description: PGP signature
[gentoo-dev] [PATCH] unpacker.eclass: enable EAPI 8
Signed-off-by: Stephan Hartmann
---
eclass/unpacker.eclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/eclass/unpacker.eclass b/eclass/unpacker.eclass
index c9dab4345c9..424975ba8ba 100644
--- a/eclass/unpacker.eclass
+++ b/eclass/unpacker.eclass
@@ -4,7 +4,7 @@
# @ECLASS: unpacker.eclass
# @MAINTAINER:
# base-sys...@gentoo.org
-# @SUPPORTED_EAPIS: 5 6 7
+# @SUPPORTED_EAPIS: 5 6 7 8
# @BLURB: helpers for extraneous file formats and consistent behavior across
EAPIs
# @DESCRIPTION:
# Some extraneous file formats are not part of PMS, or are only in certain
@@ -16,7 +16,7 @@
# - support partial unpacks?
case ${EAPI:-0} in
- [567]) ;;
+ [5678]) ;;
*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
esac
--
2.31.1
