Re: [gentoo-dev] [PATCH 0/2] edo.eclass: enhace edob for usage with nosiy commands

2024-05-13 Thread Sam James
Florian Schmaus  writes:

> The motivation for this change is to allow edob to be used with noisy
> commands, i.e., commands that produce a lot of output, in cases where
> the output is in general not of interest. However, if the command
> fails, the output should be shown and appear in build.log.
>
> We do this by simply redirecting the output to a file in $T, and show
> this file if the command returned a non-zero exit status.
>
> We already have a few cases in ::gentoo where such output is simply
> redirected to /dev/null, hindering post-mortem analysis. Those could
> be converted to edob with its new behavior.
>
> PR at https://github.com/gentoo/gentoo/pull/36117
>

LGTM. I agree there's value in it.

> Florian Schmaus (2):
>   edo.eclass: enhace edob for usage with nosiy commands

s/nosiy/noisy/

>   eftmutil-sys: use edob
>
>  eclass/edo.eclass| 54 
>  eclass/texlive-common.eclass |  8 --
>  2 files changed, 53 insertions(+), 9 deletions(-)



[gentoo-dev] [PATCH 0/2] edo.eclass: enhace edob for usage with nosiy commands

2024-05-08 Thread Florian Schmaus
The motivation for this change is to allow edob to be used with noisy
commands, i.e., commands that produce a lot of output, in cases where
the output is in general not of interest. However, if the command
fails, the output should be shown and appear in build.log.

We do this by simply redirecting the output to a file in $T, and show
this file if the command returned a non-zero exit status.

We already have a few cases in ::gentoo where such output is simply
redirected to /dev/null, hindering post-mortem analysis. Those could
be converted to edob with its new behavior.

PR at https://github.com/gentoo/gentoo/pull/36117

Florian Schmaus (2):
  edo.eclass: enhace edob for usage with nosiy commands
  eftmutil-sys: use edob

 eclass/edo.eclass| 54 
 eclass/texlive-common.eclass |  8 --
 2 files changed, 53 insertions(+), 9 deletions(-)

-- 
2.43.2