Re: [gentoo-dev] [PATCH 29/44] meson.eclass: Set @PROVIDES
On Thu, 2021-09-02 at 10:17 -0400, Mike Gilbert wrote: > On Thu, Sep 2, 2021 at 6:47 AM Michał Górny wrote: > > > > Signed-off-by: Michał Górny > > --- > > eclass/meson.eclass | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/eclass/meson.eclass b/eclass/meson.eclass > > index eaff26709a75..c5e3b91f9a15 100644 > > --- a/eclass/meson.eclass > > +++ b/eclass/meson.eclass > > @@ -6,6 +6,7 @@ > > # William Hubbs > > # Mike Gilbert > > # @SUPPORTED_EAPIS: 6 7 8 > > +# @PROVIDES: ninja-utils > > # @BLURB: common ebuild functions for meson-based packages > > # @DESCRIPTION: > > # This eclass contains the default phase functions for packages which > > -- > > 2.33.0 > > Please drop this patch. meson.eclass does not use ninja-utils since > 5974284d8cb3c2b6d3dab3ad83c2f270db3b0798, and we certainly don't want > to implicitly provide it to consumers. > > We should probably remove the ninja-utils inherit from meson.eclass instead. > Removed. -- Best regards, Michał Górny
Re: [gentoo-dev] [PATCH 29/44] meson.eclass: Set @PROVIDES
On Thu, Sep 2, 2021 at 6:47 AM Michał Górny wrote: > > Signed-off-by: Michał Górny > --- > eclass/meson.eclass | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/eclass/meson.eclass b/eclass/meson.eclass > index eaff26709a75..c5e3b91f9a15 100644 > --- a/eclass/meson.eclass > +++ b/eclass/meson.eclass > @@ -6,6 +6,7 @@ > # William Hubbs > # Mike Gilbert > # @SUPPORTED_EAPIS: 6 7 8 > +# @PROVIDES: ninja-utils > # @BLURB: common ebuild functions for meson-based packages > # @DESCRIPTION: > # This eclass contains the default phase functions for packages which > -- > 2.33.0 Please drop this patch. meson.eclass does not use ninja-utils since 5974284d8cb3c2b6d3dab3ad83c2f270db3b0798, and we certainly don't want to implicitly provide it to consumers. We should probably remove the ninja-utils inherit from meson.eclass instead.
[gentoo-dev] [PATCH 29/44] meson.eclass: Set @PROVIDES
Signed-off-by: Michał Górny --- eclass/meson.eclass | 1 + 1 file changed, 1 insertion(+) diff --git a/eclass/meson.eclass b/eclass/meson.eclass index eaff26709a75..c5e3b91f9a15 100644 --- a/eclass/meson.eclass +++ b/eclass/meson.eclass @@ -6,6 +6,7 @@ # William Hubbs # Mike Gilbert # @SUPPORTED_EAPIS: 6 7 8 +# @PROVIDES: ninja-utils # @BLURB: common ebuild functions for meson-based packages # @DESCRIPTION: # This eclass contains the default phase functions for packages which -- 2.33.0
