Re: [gentoo-dev] [PATCH autotools-utils 1/9] Fix handling whitespace in filenames when looking for .la files.
On 21:53 Tue 13 Sep , Nirbheek Chauhan wrote: On Tue, Sep 13, 2011 at 8:43 PM, Dirkjan Ochtman d...@gentoo.org wrote: 2011/9/13 Michał Górny mgo...@gentoo.org: --- eclass/autotools-utils.eclass | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) I don't think sending 9 patches is very useful for this mailing list. Next time just sent a link to a git repo or something? On the contrary, I like that mgorny sent separate completely independent patches for review to the list instead of either sending on huge chunk, or not sending patches at all. +1, except parts of them were dependent. =) Maybe use some `git rebase --interactive` next time.. -- Thanks, Donnie Donnie Berkholz Council Member / Sr. Developer Gentoo Linux Blog: http://dberkholz.com pgp3Hnb8ts55I.pgp Description: PGP signature
[gentoo-dev] [PATCH autotools-utils 1/9] Fix handling whitespace in filenames when looking for .la files.
---
eclass/autotools-utils.eclass |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/eclass/autotools-utils.eclass b/eclass/autotools-utils.eclass
index ad5ffea..8bc365d 100644
--- a/eclass/autotools-utils.eclass
+++ b/eclass/autotools-utils.eclass
@@ -146,7 +146,7 @@ remove_libtool_files() {
debug-print-function ${FUNCNAME} $@
local f
- for f in $(find ${D} -type f -name '*.la'); do
+ find ${D} -type f -name '*.la' -print0 | while read -r -d '' f; do
# Keep only .la files with shouldnotlink=yes - likely plugins
local shouldnotlink=$(sed -ne '/^shouldnotlink=yes$/p' ${f})
if [[ $1 == 'all' || -z ${shouldnotlink} ]]; then
--
1.7.6.1
Re: [gentoo-dev] [PATCH autotools-utils 1/9] Fix handling whitespace in filenames when looking for .la files.
2011/9/13 Michał Górny mgo...@gentoo.org: --- eclass/autotools-utils.eclass | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) I don't think sending 9 patches is very useful for this mailing list. Next time just sent a link to a git repo or something? Cheers, Dirkjan
Re: [gentoo-dev] [PATCH autotools-utils 1/9] Fix handling whitespace in filenames when looking for .la files.
On Tue, Sep 13, 2011 at 8:43 PM, Dirkjan Ochtman d...@gentoo.org wrote: 2011/9/13 Michał Górny mgo...@gentoo.org: --- eclass/autotools-utils.eclass | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) I don't think sending 9 patches is very useful for this mailing list. Next time just sent a link to a git repo or something? On the contrary, I like that mgorny sent separate completely independent patches for review to the list instead of either sending on huge chunk, or not sending patches at all. -- ~Nirbheek Chauhan Gentoo GNOME+Mozilla Team
Re: [gentoo-dev] [PATCH autotools-utils 1/9] Fix handling whitespace in filenames when looking for .la files.
On Tue, 13 Sep 2011 17:13:11 +0200 Dirkjan Ochtman d...@gentoo.org wrote: 2011/9/13 Michał Górny mgo...@gentoo.org: --- eclass/autotools-utils.eclass | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) I don't think sending 9 patches is very useful for this mailing list. Next time just sent a link to a git repo or something? Erm, maybe I should've attached a complete diff as well, or complete updated eclass. -- Best regards, Michał Górny signature.asc Description: PGP signature
