Re: [gentoo-dev] [RFC] www-nginx/ category and nginx-module.eclass for nginx modules
Hi, Am Dienstag, dem 24.01.2023 um 18:11 +0100 schrieb Michał Górny: > How many packages do you expect to add to this new category? It's > not customary to create a new category for one package. We currently have 24 third party modules in www-apps/nginx pulled in conditionally via USE flags. With nginx-module.eclass we should be able to migrate all of them to separate packages, reducing extra compile overhead for users wanting to install one of those modules and reducing the ebuild size and complexity of www-apps/nginx. Best regards Adrian signature.asc Description: This is a digitally signed message part
Re: [gentoo-dev] [RFC] www-nginx/ category and nginx-module.eclass for nginx modules
On 2023-01-24 18:11, Michał Górny wrote: > How many packages do you expect to add to this new category? It's not > customary to create a new category for one package. Look at www-servers/nginx package, it's huge! Lots of modules (many of them are 3rd-party) could be separate packages.
Re: [gentoo-dev] [RFC] www-nginx/ category and nginx-module.eclass for nginx modules
On Tue, 2023-01-24 at 16:51 +0100, Adrian Schollmeyer wrote: > Hey there, > > a while back Jonas Licht (Cc) wrote an eclass for Nginx dynamic modules. > For a few years now, Nginx supports building third party dynamic modules > outside of the Nginx source tree with the help of Nginx's build system. > Since this involves quite some work to obtain information from the Nginx > build configuration and using Nginx's build system to actually build the > module, an eclass was written. The last RFC didn't make it into > ::gentoo, since the requested changes haven't been applied. > > However, we have been working on the eclass again and applied all the > requested changes, made it EAPI=8 compatible and were able to use it > successfully to package a third party Nginx module in ::fem-overlay [0]. > > This patchset contains the reworked nginx-module.eclass for building > third party modules using Nginx's build system as separate packages. > Furthermore the category www-nginx is added where these third party > modules shall be put. Lastly, www-nginx/nginx-vod-module is added as a > first package using this eclass. > > The patchset is also available as PR #16053 on GitHub [1]. If this > patchset is applied, the other PR for adding nginx-vod-module [2] > probably becomes obsolete [2]. > How many packages do you expect to add to this new category? It's not customary to create a new category for one package. -- Best regards, Michał Górny
[gentoo-dev] [RFC] www-nginx/ category and nginx-module.eclass for nginx modules
Hey there, a while back Jonas Licht (Cc) wrote an eclass for Nginx dynamic modules. For a few years now, Nginx supports building third party dynamic modules outside of the Nginx source tree with the help of Nginx's build system. Since this involves quite some work to obtain information from the Nginx build configuration and using Nginx's build system to actually build the module, an eclass was written. The last RFC didn't make it into ::gentoo, since the requested changes haven't been applied. However, we have been working on the eclass again and applied all the requested changes, made it EAPI=8 compatible and were able to use it successfully to package a third party Nginx module in ::fem-overlay [0]. This patchset contains the reworked nginx-module.eclass for building third party modules using Nginx's build system as separate packages. Furthermore the category www-nginx is added where these third party modules shall be put. Lastly, www-nginx/nginx-vod-module is added as a first package using this eclass. The patchset is also available as PR #16053 on GitHub [1]. If this patchset is applied, the other PR for adding nginx-vod-module [2] probably becomes obsolete [2]. Best regards Adrian and Jonas [0] https://gitlab.fem-net.de/gentoo/fem-overlay/-/tree/master/www-nginx/nginx-vod-module [1] https://github.com/gentoo/gentoo/pull/16053 [2] https://github.com/gentoo/gentoo/pull/11043
