Re: [gentoo-dev] Re: [RFC] New eclass for x11 packages

2010-02-24 Thread Tomáš Chvátal
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Dne 19.2.2010 02:22, Ryan Hill napsal(a):
 On Thu, 18 Feb 2010 23:33:42 +0100
 Tomáš Chvátal scarab...@gentoo.org wrote:
 
 Hi,
 we prepared new eclass for x11 packages that should be used as
 replacement for x-modular.eclass.

 After long discussion with others on irc we choose to name it as
 xorg-2.eclass.

 Whats new/changed:
 
 Fonts handling slightly rewritten to be done as written in specs (or i
 hope i did so :]).
 
 It'd be nice to move all of the fonts stuff to font.eclass.  Right now we
 have two similar-but-not-quite font systems that tend to do the same thing
 but drift apart sometimes in incompatible ways.
 
 But I know I don't have time to do it and it seems to work well enough right 
 now, so
 meh. ;)
 
[[ ${PN} == util-macros ]] || DEPEND+= =x11-misc/util-macros-1.3.0
[[ ${PN} == font-util ]] || DEPEND+= =media-fonts/font-util-1.1.1-r1 
  

 Do non-fonts really need font-util there?  Looks like that sets up a nice 
 circular dependency.  
 The same dep is in x-modular eclass. I spoted it in some fonts packages
 as required so i left it there.
 Good work/idea would be if someone doublecheck that one :]
 
 Hmm, I don't see it in x-modular.  It shouldn't be required for non-fonts
 unless something in git needs it for some wacky reason.
 
 
   remove_font_metadata() {
 if [[ ${FONT_DIR} != Speedo  ${FONT_DIR} != CID ]]; then
 einfo Removing font metadata
 rm -rf 
 ${ED}/usr/share/fonts/${FONT_DIR}/fonts.{scale,dir,cache-1}
 fi
   }
 
 Sorry, I forgot I was going to follow up on this..  FONT_DIR is a
 space-separated list of directories.  The only example of a font with
 multiple directories I know of is font-misc-ethiopic.  In that case, the
 command run here would be:
 
   rm -rf /usr/share/fonts/TTF OTF/fonts.{scale,dir,cache-1}
 
 :/
 
 cleanup_fonts(), create_fonts_scale(), and create_fonts_dir() are similarly
 broken with multiple directories.
 
 
   create_fonts_scale() {
 if [[ ${DIR} != Speedo  ${DIR} != CID ]]; then
 
 I think you mean ${FONT_DIR} here.  
YEAH :P Fixed in git.
 
 Honestly, you might consider dropping TTF from font-misc-ethiopic and only
 install the OTF version.  It would simplify things greatly.
 
 
Well everywhere the FONT_DIR is treated as one dir, so maybe we should
just bash to submission the one offending ebuild and be done with it.

I can of course write logic to count with space separated list...
You decide, after all you are font guy :P Or actually anyone share your
opinions about this :]

Tomas
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuFkh4ACgkQHB6c3gNBRYfQJQCfZnjWiT6GtKloZCMncnWe/Aas
VRsAoM5nHXldDiygrYMyZPg9aLB46G0V
=Kooc
-END PGP SIGNATURE-



[gentoo-dev] Re: [RFC] New eclass for x11 packages

2010-02-18 Thread Ryan Hill
On Thu, 18 Feb 2010 23:33:42 +0100
Tomáš Chvátal scarab...@gentoo.org wrote:

 Hi,
 we prepared new eclass for x11 packages that should be used as
 replacement for x-modular.eclass.
 
 After long discussion with others on irc we choose to name it as
 xorg-2.eclass.
 
 Whats new/changed:

 Fonts handling slightly rewritten to be done as written in specs (or i
 hope i did so :]).

It'd be nice to move all of the fonts stuff to font.eclass.  Right now we
have two similar-but-not-quite font systems that tend to do the same thing
but drift apart sometimes in incompatible ways.

But I know I don't have time to do it and it seems to work well enough right 
now, so
meh. ;)

 [[ ${PN} == util-macros ]] || DEPEND+= =x11-misc/util-macros-1.3.0
 [[ ${PN} == font-util ]] || DEPEND+= =media-fonts/font-util-1.1.1-r1 
  
 
 Do non-fonts really need font-util there?  Looks like that sets up a nice 
 circular dependency.  
The same dep is in x-modular eclass. I spoted it in some fonts packages
as required so i left it there.
Good work/idea would be if someone doublecheck that one :]

Hmm, I don't see it in x-modular.  It shouldn't be required for non-fonts
unless something in git needs it for some wacky reason.


  remove_font_metadata() {
  if [[ ${FONT_DIR} != Speedo  ${FONT_DIR} != CID ]]; then
  einfo Removing font metadata
  rm -rf 
${ED}/usr/share/fonts/${FONT_DIR}/fonts.{scale,dir,cache-1}
  fi
  }

Sorry, I forgot I was going to follow up on this..  FONT_DIR is a
space-separated list of directories.  The only example of a font with
multiple directories I know of is font-misc-ethiopic.  In that case, the
command run here would be:

  rm -rf /usr/share/fonts/TTF OTF/fonts.{scale,dir,cache-1}

:/

cleanup_fonts(), create_fonts_scale(), and create_fonts_dir() are similarly
broken with multiple directories.


  create_fonts_scale() {
  if [[ ${DIR} != Speedo  ${DIR} != CID ]]; then

I think you mean ${FONT_DIR} here.  

Honestly, you might consider dropping TTF from font-misc-ethiopic and only
install the OTF version.  It would simplify things greatly.


-- 
fonts,by design, by neglect
gcc-porting,  for a fact or just for effect
wxwidgets @ gentoo EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662


signature.asc
Description: PGP signature