Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-misc/gnote: gnote-3.8.1.ebuild ChangeLog

2013-08-22 Thread Michał Górny
Dnia 2013-08-22, o godz. 19:13:25
Markos Chandras  napisał(a):

> > RCS file: /var/cvsroot/gentoo-x86/app-misc/gnote/ChangeLog,v
> > retrieving revision 1.34
> > retrieving revision 1.35
> > diff -u -r1.34 -r1.35
> > --- ChangeLog   22 Aug 2013 16:14:52 -  1.34
> > +++ ChangeLog   22 Aug 2013 16:36:24 -  1.35
> > @@ -1,6 +1,9 @@
> >  # ChangeLog for app-misc/gnote
> >  # Copyright 1999-2013 Gentoo Foundation; Distributed under the GPL v2
> > -# $Header: /var/cvsroot/gentoo-x86/app-misc/gnote/ChangeLog,v 1.34 
> > 2013/08/22 16:14:52 jbartosik Exp $
> > +# $Header: /var/cvsroot/gentoo-x86/app-misc/gnote/ChangeLog,v 1.35 
> > 2013/08/22 16:36:24 jbartosik Exp $

And being a little picky, those changelog messages don't look very
helpful.

> > +  22 Aug 2013;   gnote-3.8.1.ebuild:
> > +  Fix a problem pointed out by Pacho Ramos.

What problem? You should describe the changes, at least with general
keyword like 'cleanup', 'missing dep', 'missing inherit' etc.

Pointed out where? Is there a bug about it? If yes, you should mention
it.

> >
> >22 Aug 2013;   gnote-3.8.1.ebuild:
> >Fix too hasty commit: use proper src_install.


-- 
Best regards,
Michał Górny


signature.asc
Description: PGP signature


[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-misc/gnote: gnote-3.8.1.ebuild ChangeLog

2013-08-22 Thread Markos Chandras
> RCS file: /var/cvsroot/gentoo-x86/app-misc/gnote/ChangeLog,v
> retrieving revision 1.34
> retrieving revision 1.35
> diff -u -r1.34 -r1.35
> --- ChangeLog   22 Aug 2013 16:14:52 -  1.34
> +++ ChangeLog   22 Aug 2013 16:36:24 -  1.35
> @@ -1,6 +1,9 @@
>  # ChangeLog for app-misc/gnote
>  # Copyright 1999-2013 Gentoo Foundation; Distributed under the GPL v2
> -# $Header: /var/cvsroot/gentoo-x86/app-misc/gnote/ChangeLog,v 1.34 
> 2013/08/22 16:14:52 jbartosik Exp $
> +# $Header: /var/cvsroot/gentoo-x86/app-misc/gnote/ChangeLog,v 1.35 
> 2013/08/22 16:36:24 jbartosik Exp $
> +
> +  22 Aug 2013;   gnote-3.8.1.ebuild:
> +  Fix a problem pointed out by Pacho Ramos.
>
>22 Aug 2013;   gnote-3.8.1.ebuild:
>Fix too hasty commit: use proper src_install.
>
>
>
>

Your ECHANGELOG_USER variable is incorrect. Your ChangeLogs have no
name and the email address looks a bit weird. I presume the correct
one should be jbarto...@gentoo.org

Please read this
http://devmanual.gentoo.org/tools-reference/echangelog/index.html

-- 
Regards,
Markos Chandras - Gentoo Linux Developer
http://dev.gentoo.org/~hwoarang