Re: [gentoo-dev] Re: New Eclasses: postgres and postgres-multi
On 2016-01-25 22:34, Jonathan Callen wrote:
> On 01/25/2016 07:29 AM, Aaron W. Swenson wrote:
> > On 2016-01-24 18:44, Michael Orlitzky wrote:
> >> On 01/24/2016 06:29 PM, Aaron W. Swenson wrote:
> >>> Okay, provided that the new USE_EXPAND is okay for
> >>> POSTGRES_TARGETS, attached are the eclasses that I'll commit to
> >>> the tree.
> >>>
> >>
> >>> case ${EAPI:-0} in 0|1|2|3|4) die "postgres-multi.eclass
> >>> requires EAPI 5 or higher" ;; *) ;; esac
> >>
> >> Does this really work with EAPI=6? I didn't try, but it looks
> >> like it would need an eapply_user somewhere in src_prepare. And,
> >> pedantry warning, there's no such thing as "EAPI 5 or higher."
> >> The lawyers will tell you to do something like this instead
> >> (stolen from git-r3):
> >>
> >> case "${EAPI:-0}" in 5|6) ;; *) die "Unsupported EAPI=${EAPI}
> >> (unknown) for ${ECLASS}" ;; esac
> >>
> >> That will require an edit for every new EAPI, but prevents weird
> >> crashes from things like a missing eapply_user.
> >>
> >>
> >
> > Thank you.
> >
> > I've added the eapply_user to postgres-multi and modified the case
> > condition to match the hot goods you're selling on the sly.
> >
>
> You missed the fix for EAPI in postgres-multi.eclass (it looks okay in
> the other eclass, though).
Fixed. Thanks!
signature.asc
Description: Digital signature
[gentoo-dev] Re: New Eclasses: postgres and postgres-multi
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 01/25/2016 07:29 AM, Aaron W. Swenson wrote:
> On 2016-01-24 18:44, Michael Orlitzky wrote:
>> On 01/24/2016 06:29 PM, Aaron W. Swenson wrote:
>>> Okay, provided that the new USE_EXPAND is okay for
>>> POSTGRES_TARGETS, attached are the eclasses that I'll commit to
>>> the tree.
>>>
>>
>>> case ${EAPI:-0} in 0|1|2|3|4) die "postgres-multi.eclass
>>> requires EAPI 5 or higher" ;; *) ;; esac
>>
>> Does this really work with EAPI=6? I didn't try, but it looks
>> like it would need an eapply_user somewhere in src_prepare. And,
>> pedantry warning, there's no such thing as "EAPI 5 or higher."
>> The lawyers will tell you to do something like this instead
>> (stolen from git-r3):
>>
>> case "${EAPI:-0}" in 5|6) ;; *) die "Unsupported EAPI=${EAPI}
>> (unknown) for ${ECLASS}" ;; esac
>>
>> That will require an edit for every new EAPI, but prevents weird
>> crashes from things like a missing eapply_user.
>>
>>
>
> Thank you.
>
> I've added the eapply_user to postgres-multi and modified the case
> condition to match the hot goods you're selling on the sly.
>
You missed the fix for EAPI in postgres-multi.eclass (it looks okay in
the other eclass, though).
- --
Jonathan Callen
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
iQIcBAEBCgAGBQJWpukoAAoJEEIQbvYRB3mgD/8P/iCbnkSZGcwnbQ7EsV55apJ+
+AqzVJVbgvNkrK23JysYfDcT9Qthld5W1CX66YBg38PBJbDHrQPZQiAYypybVxo8
Liv8P2O4smBdYhIdFfcMw6ARyOpfRec1kiYiZr0YI/sM1pQF/UV2RuG+zJJILMwJ
f3gNoRN0u58hMX5F1LZn0vRcrp9FqovNy1MMQ83u1qZp6SwK81IZFmHXoyyEWmaO
zh1plMRfs9iD7DK6CzHBvRyIyShzJGcNLOkNM7qKU5GhAXi7bWuwx5ZZpD1peWLI
Rn9xXfffyA62eU7EGvUQG/PuAU1PErT9+nFhH6qqSBnOpcR3kFO8a5zgfLHogzJT
cDQf4XU9MxDCjvSF2c/2tnt1tXqBO7CTjvsaIgaok8vzLsmh6wwJCiqGb80gRWX7
4HIAKqH1QbBLfPkb54NQp8ixw1b+LmtcbgJQrpXpxJTrUqtnJKDaaXKblFO8eOW2
LeLYYxdzEz3rh6RiqT7NZ3iKKP6cFy7S4qlfe4qsXD7mns1eIqcx9Hdt8LuwDMnC
zGLb7TBThrhBTt1gRdsXNDZUhkO5YohNqIgeUO1+bEnWS2UGZNf4Mv69HZTgipLO
vZ2vPFevEW5zAqj8kXgZQjuyrq59TlCY9l2q/etf4oxk6e2Sge1TZ8dcfLA9kJ/E
SIdeJ4XRl36+p1ANzG6c
=F4Y9
-END PGP SIGNATURE-
