[gentoo-dev] perl-app.eclass -- review

[Torsten Veller]

Not much to say about it: It's a useless eclass anyway.
Now it has EAPI=2 support too.

The new eclass and
a diff of the relevant parts of current perl-module.eclass and perl-apps.eclass
are attached.

I want to commit it soon too.

Thanks

# Copyright 1999-2004 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: /var/cvsroot/gentoo-x86/eclass/perl-app.eclass,v 1.10 2006/12/09 
14:34:01 mcummings Exp $

# Author: Michael Cummings <mcummi...@gentoo.org>
# Maintained by the Perl herd <p...@gentoo.org>

inherit perl-module

case "${EAPI:-0}" in
        0|1) EXPORT_FUNCTIONS src_compile ;;
        2)   EXPORT_FUNCTIONS src_configure src_compile ;;
esac

perl-app_src_prep() {
        perl-app_src_configure
}

perl-app_src_configure() {
        perl-module_src_configure
}

perl-app_src_compile() {
        has "${EAPI:-0}" 0 1 && perl-app_src_prep
        perl-module_src_compile
}

--- perl-module.eclass.orig_minimal     2009-03-05 15:39:47.000000000 +0100
+++ perl-app.eclass.orig_minimal        2009-03-05 15:40:13.000000000 +0100
@@ -1,9 +1,13 @@
-inherit base
+# The perl-app eclass is designed to allow easier installation of perl
+# apps, ineheriting the full structure of the perl-module eclass but allowing
+# man3 pages to be built. This is to work around a collision-protect bug in the
+# default perl-module eclass
 
-EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_postinst pkg_prerm pkg_postrm 
src_compile src_install src_test src_unpack
+inherit perl-module
 
-perl-module_src_prep() {
+EXPORT_FUNCTIONS src_compile
 
+perl-app_src_prep() {
        perlinfo
 
        export PERL_MM_USE_DEFAULT=1
@@ -12,10 +16,10 @@
 
 
        SRC_PREP="yes"
-       find ${S} -type d -name "\.svn" -exec /bin/rm -rf {} \; 2>/dev/null
+       pwd
        if [ "${PREFER_BUILDPL}" == "yes" ] && ( [ -f Build.PL ] || [ ${PN} == 
"module-build" ] ); then
                einfo "Using Module::Build"
-               echo "$pm_echovar" | perl Build.PL ${myconf} 
--installdirs=vendor --destdir=${D} --libdoc= || die "Unable to build! (are you 
using USE=\"build\"?)"
+               echo "$pm_echovar" | perl Build.PL --installdirs=vendor 
--destdir=${D} --libdoc= || die "Unable to build! (are you using 
USE=\"build\"?)"
        elif [ -f Makefile.PL ] && [ ! ${PN} == "module-build" ]; then
                einfo "Using ExtUtils::MakeMaker"
                echo "$pm_echovar" | perl Makefile.PL ${myconf} 
INSTALLMAN3DIR='none'\
@@ -27,10 +31,10 @@
        fi
 }
 
-perl-module_src_compile() {
+perl-app_src_compile() {
 
        perlinfo
-       [ "${SRC_PREP}" != "yes" ] && perl-module_src_prep
+       [ "${SRC_PREP}" != "yes" ] && perl-app_src_prep
        if [ -f Makefile ]; then
                make ${mymake} || die "compilation failed"
        elif [ -f Build ]; then