Re: [gentoo-dev] symlinks in the tree

2015-09-12 Thread NP-Hardass
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

In my wine-a-holics overlay, I used symlinks.  I found that
occassionally, git would act up and replace the symlink with the linked
file when committing.  I never found out how or why, but for this
reason alone, I highly recommend against it.

Regarding the comment about regular and live versions, I'd also
recommend against this for the simple reason that sometimes something
changes upstream before a release comes out, and it adds an additional
complication of worrying about edits to the live version changing a
versioned ebuild.

- --NP-Hardass

On Sat, 12 Sep 2015 15:12:08 +0200
"Justin Lecher (jlec)"  wrote:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
> 
> Hi,
> 
> I would like to discuss the pro and cons of usage of symlinks in the
> tree, which are possible now as we aren't bound to CVS anymore
> 
> We have quite a number of ebuilds already in the tree defining
> functionality for both, regular version and live versions. These are
> typical candidates. Same for different package versions with the same
> ebuild.
> 
> What is your opinion on making heavy use of symlinks here?
> 
> Personally I would ban symlinks and duplicated code. One ebuild for
> one version. And in case you like to propagate changes over several
> ebuilds, just use tools like meld.
> 
> A drawback is that tools like sed break symlinks and write back a
> plain files.
> 
> And last, we have potential breakages if people don't give enough care
> when doing stabilizations and removal of version.
> 
> nevertheless, we would slim the tree and reduce work when changing
> things like HOMEPAGE.
> 
> So please discuss this matter.
> 
> Justin
> -BEGIN PGP SIGNATURE-
> Version: GnuPG/MacGPG2 v2.0
> 
> iQJ8BAEBCgBmBQJV9CSoXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
> ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF
> OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiIZ0P/0q6jSuGZzZ4lDiu87GIYMiC
> ndRzHsR/OGT9paB01pkoQogOt9+AMKdNd434n2to+HbuNf7Le5cWP7MBAdD/ydzV
> H+5zE98Mu9h8IXTRvuxv6eTSRPFsnnDPuMAS+28D7WwDBcmOhl4we/hRyfq0+JFw
> s5XojNlrk7YZLynZs8SHcgqq5CbaKbjLMsVSTnVXKeA1NcaB0lPFjI0JraCqW4xS
> BgIA2MrrR5XM2imvmBInanwJZ+VOVvHD1jxTlfUQeF7qJusTY5fTnVncvnIo72Fh
> E2Rz/+vrWFe+CvQV63IpgbtC2oYP5OMidnfZSQynRbGsK9w3rm25cXOlyXjLA98O
> sv/wNHvVk3+SIvIviN3yDjOOG5q1zeW33UtZfz5iKu3E7dUGw6B2a/qjC9m9lIQH
> GGDu7csYnW8aSLiEJPGsJsduTqw/+G5p8DWMGuHss6xu6DyZKJPRxgd4VlDkLIiE
> ZCgoHCGhQX3LDEOlzh7+j01A1AOO4SfTZqqDch8f6jiLYmx0dw4Rcz6Lth+cAzn+
> fjTdq8A1P5umV8NiwGZtx8GtPoEWRpEV0zuhZHWXjvFSIxpn2TBUi+pETo421wXH
> 9QDQD5Q/9Wf/Wckyb86+OEhwBGoPXib2sF1BOTWONXHECvQ5xuqXy2Ux34HJHbou
> Que3NfC4OiQKXSJv1jae
> =K93a
> -END PGP SIGNATURE-
> 

-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCAAGBQJV9PKMAAoJEBzZQR2yrxj7498P/3ITnQ3Ji8MaPGbv3AWK52SN
hccXU3Bjyq7I/A+1H/ZYzmBRtLkANczeCcqOBQTIr2p7s3lFfnvRVAfrpyRsmo1s
ix9Pmf/9ixDZ+dHUxliARiYNZHWNtisxCF5ehmo8+q/F5efLslrjKNf81X9xDpaL
Haz5ywWUfVRXWZwWjgc5dSLfqauPYZSE9B3NzOgjKnRT9OeYT/5dMHf6rgkPi2jT
O2NeYI2zKL93hspxM4ot1QBhlmKAw2ArjDMoV5UkjpvKa/4FKXu8h34dgwZH0AYJ
2WlIMXREUt1iR+FYQ+hUEzOsEO7HgSlz7wfn0Z7SJUFObhXTzIlMLjm5wbVbjsVx
rzz/XEXJlU8OFjy5h2MfoFWn0I46ysgFtie7OaRl/Rq3jqLg6irLAmwgiqJbLgCa
qcwUt3EhbWqSr5NlHdxCHfjnOwYsTrd+cX0FEhMNW2pFO8oBXa4Xz+x4PiZAz07M
RyRftQucd2JbY+TE2nS51HzJYN8157ZkPJ1SnNN38Nftd0oD0XJ9UmeYhO45Gc6W
wRpX75af1dUhgs3nh6CpnYCXuWe8Aa08vf2WWTpw72QdcurI3cSrYcjScDXbF4Yw
hthsaaP+rwDCFacFdY24Rglg01Q45mWq23mylVwnmMUtG3qvE0Nhu3ZIBtqx+j5O
gsujfaXNV5U/jsnCWDMf
=8n1u
-END PGP SIGNATURE-


Re: [gentoo-dev] symlinks in the tree

2015-09-12 Thread Michał Górny
Dnia 2015-09-12, o godz. 15:30:45
"Justin Lecher (jlec)"  napisał(a):

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
> 
> On 12/09/15 15:19, hasufell wrote:
> > +1 for banning symlinks
> > 
> 
> mrueg just mentioned a very crucial point. There are filesystem which
> don't support symlinks and would break everything.

Just to be clear, I don't see that as being a problem.

I would expect Gentoo development to occur on systems which support
symlinks properly. For user systems, I would expect rsync mirrors to
replace symlinks with duplicated files.

That said, I have the same stance for symlinks as I have for
'if [[ ${PV} ==  ]]' blocks in ebuilds -- I don't like them but I
can live with them.

-- 
Best regards,
Michał Górny



pgpUc3xUtZP5v.pgp
Description: OpenPGP digital signature


Re: [gentoo-dev] symlinks in the tree

2015-09-12 Thread Andreas K. Huettel
Am Samstag, 12. September 2015, 15:12:08 schrieb Justin Lecher (jlec):
> Hi,
> 
> I would like to discuss the pro and cons of usage of symlinks in the
> tree, which are possible now as we aren't bound to CVS anymore
> 

Please please just ban them completely. 

-- 

Andreas K. Huettel
Gentoo Linux developer 
dilfri...@gentoo.org
http://www.akhuettel.de/




Re: [gentoo-dev] symlinks in the tree

2015-09-12 Thread Ulrich Mueller
> On Sat, 12 Sep 2015, Justin Lecher (jlec) wrote:

> I would like to discuss the pro and cons of usage of symlinks in the
> tree, which are possible now as we aren't bound to CVS anymore

> We have quite a number of ebuilds already in the tree defining
> functionality for both, regular version and live versions. These are
> typical candidates. Same for different package versions with the
> same ebuild.

> [...]

> nevertheless, we would slim the tree and reduce work when changing
> things like HOMEPAGE.

IIUC git will only store one copy of duplicate files, so using
symlinks won't save any space in the repository.

Also I suspect that symlinks would soon cause a mess when package
versions are stabilised.

Ulrich


pgp1WXtcM9j9K.pgp
Description: PGP signature


Re: [gentoo-dev] symlinks in the tree

2015-09-12 Thread Patrice Clement
Saturday 12 Sep 2015 15:30:45, Justin Lecher (jlec) wrote :
> On 12/09/15 15:19, hasufell wrote:
> > +1 for banning symlinks
> > 
> 
> mrueg just mentioned a very crucial point. There are filesystem which
> don't support symlinks and would break everything.
> 
> 
+1 too

A functionality that causes a maintenance burden should be avoided. It's just
common sense.

-- 
Patrice Clement
Gentoo Linux developer
http://www.gentoo.org


signature.asc
Description: PGP signature


Re: [gentoo-dev] symlinks in the tree

2015-09-12 Thread Kristian Fiskerstrand
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On 09/12/2015 03:12 PM, Justin Lecher (jlec) wrote:
> Hi,
> 
> I would like to discuss the pro and cons of usage of symlinks in
> the tree, which are possible now as we aren't bound to CVS anymore
> 
> We have quite a number of ebuilds already in the tree defining 
> functionality for both, regular version and live versions. These
> are typical candidates. Same for different package versions with
> the same ebuild.
> 
> What is your opinion on making heavy use of symlinks here?

I'm not in favor of it, I see an increase in maintenance complexity in
particular with regards to stabilization and version cleanup without
any obvious benefit. If the argument is the duplicate ebuild info
after a copy is too much, there are likely too many versions for that
package around.

- -- 
Kristian Fiskerstrand
Public PGP key 0xE3EDFAE3 at hkp://pool.sks-keyservers.net
fpr:94CB AFDD 3034 5109 5618 35AA 0B7F 8B60 E3ED FAE3
-BEGIN PGP SIGNATURE-

iQEcBAEBCgAGBQJV9CjnAAoJECULev7WN52FbNsH/jeN9wN257cu9rk/tDMEKrXB
JLizxjTQSSXQAPGR262bQ8T8vL40vW4rxYDUdEfO+l/tA88iqA7gIUN5RIULclBG
7bJt2OBD6nX+ySwavklU+kT/sCTX9xhKz6FyPMNREhR97utTPuhAefgyuDhFS1+T
M+RkMmtrEya34FK0K4jg2s9S67FE1HEhe60AHCYILKpDqBR6/ESkd3jCgSDOwl51
rdQ5QqlX0eblmXossWbA34SbWA2u8yr7cMAYP6Y/wUCLI0MkDoNDbC7d4lOpJ6pe
PLxLC4vPOmIJC1vRri1R5aiKeHywE80/KcfraMBAhHzgPgJ8QjHlpuIgbblBets=
=5jWI
-END PGP SIGNATURE-



Re: [gentoo-dev] symlinks in the tree

2015-09-12 Thread Justin Lecher (jlec)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On 12/09/15 15:19, hasufell wrote:
> +1 for banning symlinks
> 

mrueg just mentioned a very crucial point. There are filesystem which
don't support symlinks and would break everything.


-BEGIN PGP SIGNATURE-
Version: GnuPG/MacGPG2 v2.0

iQJ8BAEBCgBmBQJV9CkFXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF
OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmi1ZoP/RwfCG1w0Rz9NcMx+ZSI2BaU
sQ5AJnvGK44G3v+H7gCz5GtdHUVkFcKzZ0o6FPQnBeSO4B2Ja42d4Sl/L5Hp+K11
h3lMzqZ8t4d2g+d5Vdu4dSt2doPwH0hPQmSZJ3mUUtTZphacxo3iAL1oYZ6c6FKw
thU4Cd52VLVuYIzekFP3pqW5g2iAyOKP/Z2+icJ8ljF9Y1NgdHjqDkKHLZ7U0cHt
RmCj0K6xctIH+nJ5PEIo2z5EvJqMb7f9B8ijkCGAZFu8mWI0BBma+OSnPvF6zjtF
e1X6IP7B7j2q57oRCHpnSG19T1wDnfJZaqZD+wpUb4EV6ITme8E3JT/4OG4OJF/0
W7/dJHYNkEAbgWoDjagsEQNuqda3BbOyv6IoXze0CUlTkGwW8wOVDUhPPnTBF8JL
Yf9WEbbECT4sRSi8ZdaUd+8M0b1gnazPBdRHCndxn530mxdicHZ6Ereup7fhRUPx
OoqvRNHJhQPX5UazbBhw/YyFq7Y1G5dg1kvZFuv50Uohmy4D1plE1dyPg0hdFwRB
UewKUl5j6CA2VKUTBFsdSBMhu/KRG/Bv4ThO7vTKhqITTwAoUXpTmLO1T7FoadIe
0DohHo3lMg2B45f0aRq8rMcgGFv8LGa5hYAzy11uU07CVHAWxfIGkMUFUvwVo3cO
PsyI27ZZVfrE38MflVgs
=4NpN
-END PGP SIGNATURE-



Re: [gentoo-dev] symlinks in the tree

2015-09-12 Thread hasufell
+1 for banning symlinks



[gentoo-dev] symlinks in the tree

2015-09-12 Thread Justin Lecher (jlec)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hi,

I would like to discuss the pro and cons of usage of symlinks in the
tree, which are possible now as we aren't bound to CVS anymore

We have quite a number of ebuilds already in the tree defining
functionality for both, regular version and live versions. These are
typical candidates. Same for different package versions with the same
ebuild.

What is your opinion on making heavy use of symlinks here?

Personally I would ban symlinks and duplicated code. One ebuild for
one version. And in case you like to propagate changes over several
ebuilds, just use tools like meld.

A drawback is that tools like sed break symlinks and write back a
plain files.

And last, we have potential breakages if people don't give enough care
when doing stabilizations and removal of version.

nevertheless, we would slim the tree and reduce work when changing
things like HOMEPAGE.

So please discuss this matter.

Justin
-BEGIN PGP SIGNATURE-
Version: GnuPG/MacGPG2 v2.0

iQJ8BAEBCgBmBQJV9CSoXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF
OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiIZ0P/0q6jSuGZzZ4lDiu87GIYMiC
ndRzHsR/OGT9paB01pkoQogOt9+AMKdNd434n2to+HbuNf7Le5cWP7MBAdD/ydzV
H+5zE98Mu9h8IXTRvuxv6eTSRPFsnnDPuMAS+28D7WwDBcmOhl4we/hRyfq0+JFw
s5XojNlrk7YZLynZs8SHcgqq5CbaKbjLMsVSTnVXKeA1NcaB0lPFjI0JraCqW4xS
BgIA2MrrR5XM2imvmBInanwJZ+VOVvHD1jxTlfUQeF7qJusTY5fTnVncvnIo72Fh
E2Rz/+vrWFe+CvQV63IpgbtC2oYP5OMidnfZSQynRbGsK9w3rm25cXOlyXjLA98O
sv/wNHvVk3+SIvIviN3yDjOOG5q1zeW33UtZfz5iKu3E7dUGw6B2a/qjC9m9lIQH
GGDu7csYnW8aSLiEJPGsJsduTqw/+G5p8DWMGuHss6xu6DyZKJPRxgd4VlDkLIiE
ZCgoHCGhQX3LDEOlzh7+j01A1AOO4SfTZqqDch8f6jiLYmx0dw4Rcz6Lth+cAzn+
fjTdq8A1P5umV8NiwGZtx8GtPoEWRpEV0zuhZHWXjvFSIxpn2TBUi+pETo421wXH
9QDQD5Q/9Wf/Wckyb86+OEhwBGoPXib2sF1BOTWONXHECvQ5xuqXy2Ux34HJHbou
Que3NfC4OiQKXSJv1jae
=K93a
-END PGP SIGNATURE-