Re: Pass ${@} in phase functions Re: [gentoo-dev] [PATCH] Introduce cmake-multilib wrapper for cmake-utils.

2013-04-13 Thread Michał Górny 
On Sat, 13 Apr 2013 03:04:51 +0200
Michael Weber x...@gentoo.org wrote:

 Hi,
 
 I'm not sure if it's a sane way to push make -j1 via
 
 src_compile() {
 cmake-multilib_src_compile -j1
 }
 
 but I detected a lack of functionality in the current
 cmake-multilib.eclass. Both cmake-utils.eclass and multilib-build.eclass
 have it, so it might be sound to continue with this behavior.

That's my mistake most likely. Please commit the patch.

-- 
Best regards,
Michał Górny


signature.asc
Description: PGP signature

Re: Pass ${@} in phase functions Re: [gentoo-dev] [PATCH] Introduce cmake-multilib wrapper for cmake-utils.

2013-04-13 Thread Ciaran McCreesh 
On Sat, 13 Apr 2013 03:04:51 +0200
Michael Weber x...@gentoo.org wrote:
 I'm not sure if it's a sane way to push make -j1 via
 
 src_compile() {
 cmake-multilib_src_compile -j1
 }

Well the Council doesn't approve of it for default phase functions...

-- 
Ciaran McCreesh


signature.asc
Description: PGP signature

Re: Pass ${@} in phase functions Re: [gentoo-dev] [PATCH] Introduce cmake-multilib wrapper for cmake-utils.

2013-04-13 Thread Michael Weber 
On 04/13/2013 05:50 PM, Michał Górny wrote:
 That's my mistake most likely. Please commit the patch.
done.

+  13 Apr 2013; Michael Weber x...@gentoo.org cmake-multilib.eclass:
+  Pass ${@} in phase functions. Approved by author on dev-ml.
+


-- 
Michael Weber
Gentoo Developer
web: https://xmw.de/
mailto: Michael Weber x...@gentoo.org

Pass ${@} in phase functions Re: [gentoo-dev] [PATCH] Introduce cmake-multilib wrapper for cmake-utils.

2013-04-12 Thread Michael Weber 
Hi,

I'm not sure if it's a sane way to push make -j1 via

src_compile() {
cmake-multilib_src_compile -j1
}

but I detected a lack of functionality in the current
cmake-multilib.eclass. Both cmake-utils.eclass and multilib-build.eclass
have it, so it might be sound to continue with this behavior.

Comments, pls.

   Michael


Index: cmake-multilib.eclass
===
RCS file: /var/cvsroot/gentoo-x86/eclass/cmake-multilib.eclass,v
retrieving revision 1.1
diff -u -B -r1.1 cmake-multilib.eclass
--- cmake-multilib.eclass   10 Feb 2013 11:44:55 -  1.1
+++ cmake-multilib.eclass   13 Apr 2013 00:58:17 -
@@ -33,24 +33,24 @@
 EXPORT_FUNCTIONS src_configure src_compile src_test src_install

 cmake-multilib_src_configure() {
-   multilib_parallel_foreach_abi cmake-utils_src_configure
+   multilib_parallel_foreach_abi cmake-utils_src_configure ${@}
 }

 cmake-multilib_src_compile() {
-   multilib_foreach_abi cmake-utils_src_compile
+   multilib_foreach_abi cmake-utils_src_compile ${@}
 }

 cmake-multilib_src_test() {
-   multilib_foreach_abi cmake-utils_src_test
+   multilib_foreach_abi cmake-utils_src_test ${@}
 }

 cmake-multilib_src_install() {
cmake-multilib_secure_install() {
-   cmake-utils_src_install
+   cmake-utils_src_install ${@}

# Make sure all headers are the same for each ABI.
multilib_check_headers
}

-   multilib_foreach_abi cmake-multilib_secure_install
+   multilib_foreach_abi cmake-multilib_secure_install ${@}
 }


-- 
Michael Weber
Gentoo Developer
web: https://xmw.de/
mailto: Michael Weber x...@gentoo.org