Re: [gentoo-dev] [PATCH] metadata: add vcs tag

2016-10-18 Thread Gilles Dartiguelongue 
Le mercredi 12 octobre 2016 à 09:44 -0700, Robin H. Johnson a écrit :
> 
> [...]
> @@ -52,6 +52,8 @@
>  
>  
>     module|cpe|cran|ctan|freecode|freshmeat|gentoo|github|gitlab|gitoriou
> s|google-
> code|launchpad|pear|pecl|pypi|rubyforge|rubygems|sourceforge|sourcefo
> rge-jp|vim) #REQUIRED>
> +
> +

I am probably nitpicking here but if you expect this element to contain
a valid URL, then maybe using #CDATA makes more sense ?

-- 
Gilles Dartiguelongue 
Gentoo

signature.asc
Description: This is a digitally signed message part

Re: [gentoo-dev] [PATCH] metadata: add vcs tag

2016-10-12 Thread Michał Górny 
On Wed, 12 Oct 2016 09:44:41 -0700
"Robin H. Johnson"  wrote:

> Signed-off-by: Robin H. Johnson 
> ---
>  metadata.xsd | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/metadata.xsd b/metadata.xsd
> index cad8304..20423f8 100644
> --- a/metadata.xsd
> +++ b/metadata.xsd
> @@ -83,6 +83,10 @@
>   
>   
>   
> + 
> + 
> + 
> + 

Is there a reason to disallow more than one occurrence of ?

>   
>   
>   

You are missing actually adding the element... You just added
a constraint on a non-existing element.

-- 
Best regards,
Michał Górny



pgpB6qP6RPBH9.pgp
Description: OpenPGP digital signature